[secdir] secdir review of draft-dekok-radext-datatypes

Sean Turner <sean@sn3rd.com> Sun, 07 August 2016 15:43 UTC

Return-Path: <sean@sn3rd.com>
X-Original-To: secdir@ietfa.amsl.com
Delivered-To: secdir@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id C78D912D0ED for <secdir@ietfa.amsl.com>; Sun, 7 Aug 2016 08:43:06 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.001
X-Spam-Level:
X-Spam-Status: No, score=-2.001 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, SPF_PASS=-0.001] autolearn=unavailable autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=sn3rd.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id iJAsL_mZAs0D for <secdir@ietfa.amsl.com>; Sun, 7 Aug 2016 08:43:04 -0700 (PDT)
Received: from mail-qk0-x229.google.com (mail-qk0-x229.google.com [IPv6:2607:f8b0:400d:c09::229]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 6C05A12D0BF for <secdir@ietf.org>; Sun, 7 Aug 2016 08:43:04 -0700 (PDT)
Received: by mail-qk0-x229.google.com with SMTP id v123so170298320qkh.3 for <secdir@ietf.org>; Sun, 07 Aug 2016 08:43:04 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sn3rd.com; s=google; h=from:content-transfer-encoding:subject:message-id:date:to :mime-version; bh=3ho9s/1np6+oboFQvQ2Zum/ks38d30dRkuiHIKap/+0=; b=fNvYPZz4jtt1yGCOpMHc4WWLLIhkxph1ABn+r+xbtsthBOHONn70Kc9X25xYAbCbog AEFXlFYIK96gHO0vdF+16bM63EWrVFPeNzJhqGTqFIvhVPRe182AXIoZ9tHPghzzoie5 VHbGvUYwVhmo7a5Cs618z23Qrc5CiBAm5GZ5E=
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:content-transfer-encoding:subject :message-id:date:to:mime-version; bh=3ho9s/1np6+oboFQvQ2Zum/ks38d30dRkuiHIKap/+0=; b=geW/sxPi5MCrflZNFIFXIAJ8OwZyCdnysLkEGbySCj9PTe03ARcdN1wekMrtOq2NdE GyXbhZtE9CiqcKeSefG/mMdT5fYWgWiY1AMR7sdIjoUR9SU9L/4fmXVrXGUkqfvwYdGC l2R7goBTad01cJ/DoIscFU67+lIXKKxU5PaDttQe93AmrwLywzdGzG+Arj9GEisWq+Yy hWNb72w1UC3X7kSJ+LJotf96pYG1OTZjWvYz6V5Tj/bsh5S8wJFez4Jog41g5aW07wcd 9o01RbSBddxSxR+zhnsUB80hKQuttPzfRKQ4qpvdxr0lMxot+kbopMAKqylUcJ6d1mu7 z1mg==
X-Gm-Message-State: AEkoousnQHw3p9I193jxZhQWBCc834vyv83DOKfdEirETnU4crGZJVimJfbYHkfm9jfONA==
X-Received: by 10.55.94.135 with SMTP id s129mr22235245qkb.80.1470584583518; Sun, 07 Aug 2016 08:43:03 -0700 (PDT)
Received: from [172.16.0.112] (pool-173-73-123-93.washdc.east.verizon.net. [173.73.123.93]) by smtp.gmail.com with ESMTPSA id 55sm15170034qtp.32.2016.08.07.08.43.02 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sun, 07 Aug 2016 08:43:02 -0700 (PDT)
From: Sean Turner <sean@sn3rd.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Message-Id: <242FE537-8205-4CAC-85BD-AC9CB740AFC4@sn3rd.com>
Date: Sun, 7 Aug 2016 11:43:01 -0400
To: draft-dekok-radext-datatypes.all@ietf.org, The IESG <iesg@ietf.org>, secdir@ietf.org
Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\))
X-Mailer: Apple Mail (2.3124)
Archived-At: <https://mailarchive.ietf.org/arch/msg/secdir/bTpq7JWnahrkkbE6_7RWiAs36_A>
Subject: [secdir] secdir review of draft-dekok-radext-datatypes
X-BeenThere: secdir@ietf.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: Security Area Directorate <secdir.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/secdir>, <mailto:secdir-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/secdir/>
List-Post: <mailto:secdir@ietf.org>
List-Help: <mailto:secdir-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/secdir>, <mailto:secdir-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sun, 07 Aug 2016 15:43:07 -0000

All,

I have reviewed this document as part of the security directorate's ongoing effort to review all IETF documents being processed by the IESG. These comments were written primarily for the benefit of the security area directors.  Document editors and WG chairs should treat these comments just like any other last call comments.

This document is essentially one long IANA consideration; the document defines an IANA registry for data types, and updates the RADIUS Attribute Type registry to use those newly defined data types.  It’s not just busy work though because the document does recommend implementations should use the data types.  Finally, this document mandates no changes to any RADIUS implementation.

Summary: ready

nits (take ‘em or leave ‘em, but please don’t hold anything up for these):

s2.1.4:r/a new data type, it should follow the/a new data type, it SHOULD follow the

s2.1.4: r/fields “Name”, … /field’s “Name”, …

s2.1.4:r/The "Value" field should be given as to be determined or “TBD” in specifications./The "Value" field SHOULD be "to be determined" or “TBD".

spt