Re: [secdir] SecDir review of draft-ietf-mpls-ldp-hello-crypto-auth-05

"Bhatia, Manav (Manav)" <manav.bhatia@alcatel-lucent.com> Wed, 21 May 2014 08:08 UTC

Return-Path: <manav.bhatia@alcatel-lucent.com>
X-Original-To: secdir@ietfa.amsl.com
Delivered-To: secdir@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id CD8721A029E; Wed, 21 May 2014 01:08:55 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.9
X-Spam-Level:
X-Spam-Status: No, score=-6.9 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_HI=-5] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id FT40AKCgFvfl; Wed, 21 May 2014 01:08:52 -0700 (PDT)
Received: from ihemail3.lucent.com (ihemail3.lucent.com [135.245.0.37]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 719B71A0313; Wed, 21 May 2014 01:08:51 -0700 (PDT)
Received: from us70uusmtp4.zam.alcatel-lucent.com (h135-5-2-66.lucent.com [135.5.2.66]) by ihemail3.lucent.com (8.13.8/IER-o) with ESMTP id s4L88lYj021311 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 21 May 2014 03:08:48 -0500 (CDT)
Received: from US70TWXCHHUB03.zam.alcatel-lucent.com (us70twxchhub03.zam.alcatel-lucent.com [135.5.2.35]) by us70uusmtp4.zam.alcatel-lucent.com (GMO) with ESMTP id s4L88lOP017930 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=FAIL); Wed, 21 May 2014 04:08:47 -0400
Received: from SG70XWXCHHUB02.zap.alcatel-lucent.com (135.253.2.47) by US70TWXCHHUB03.zam.alcatel-lucent.com (135.5.2.35) with Microsoft SMTP Server (TLS) id 14.2.247.3; Wed, 21 May 2014 04:08:47 -0400
Received: from SG70YWXCHMBA05.zap.alcatel-lucent.com ([169.254.5.212]) by SG70XWXCHHUB02.zap.alcatel-lucent.com ([135.253.2.47]) with mapi id 14.02.0247.003; Wed, 21 May 2014 16:07:47 +0800
From: "Bhatia, Manav (Manav)" <manav.bhatia@alcatel-lucent.com>
To: Stephen Farrell <stephen.farrell@cs.tcd.ie>, IETF Security Directorate <secdir@ietf.org>, The IESG <iesg@ietf.org>, "draft-ietf-mpls-ldp-hello-crypto-auth.all@tools.ietf.org" <draft-ietf-mpls-ldp-hello-crypto-auth.all@tools.ietf.org>
Thread-Topic: SecDir review of draft-ietf-mpls-ldp-hello-crypto-auth-05
Thread-Index: AQHPcRACnDeFnD7gHUOXWsSAGM4MlZtGKCeAgAGxPwCAAaG6AIABLjlg//+CUQCAAIezIA==
Date: Wed, 21 May 2014 08:07:46 +0000
Message-ID: <20211F91F544D247976D84C5D778A4C32E60B6A8@SG70YWXCHMBA05.zap.alcatel-lucent.com>
References: <53761B24.1060501@gmail.com> <20211F91F544D247976D84C5D778A4C32E60982F@SG70YWXCHMBA05.zap.alcatel-lucent.com> <537A694C.60101@gmail.com> <537BC7B6.5040406@cs.tcd.ie> <20211F91F544D247976D84C5D778A4C32E60B609@SG70YWXCHMBA05.zap.alcatel-lucent.com> <537C5BCE.4010801@cs.tcd.ie>
In-Reply-To: <537C5BCE.4010801@cs.tcd.ie>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [135.253.19.16]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Archived-At: http://mailarchive.ietf.org/arch/msg/secdir/ddE3CsEp6YLUs_sS-bOjeT3IxiE
Cc: "manavbhatia@gmail.com" <manavbhatia@gmail.com>
Subject: Re: [secdir] SecDir review of draft-ietf-mpls-ldp-hello-crypto-auth-05
X-BeenThere: secdir@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: Security Area Directorate <secdir.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/secdir>, <mailto:secdir-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/secdir/>
List-Post: <mailto:secdir@ietf.org>
List-Help: <mailto:secdir-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/secdir>, <mailto:secdir-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 21 May 2014 08:08:55 -0000

Stephen,

> > The Apad is now employed for RIP, OSPF, OSPFv3. I see no reason why
> > LDP should be an exception. The same has been proposed for BFD btw.
> 
> Even given the above, I fail to see why you repeat this text over
> and over and over. Is there a real logic for that?

Yes. The logic is that Apad keeps changing based on the protocol. There are some specific attacks that can be prevented by defining Apad to mean something specific. In case of OSPFv2 it means the source address of the sender. In case of OSPFv3, it is a value where the first 16 octets contain the IPv6 source address followed by the hexadecimal value 0x878FE1F3 repeated (L-16)/4 times. L in this case is the length of the hash. 

In case of RIpv2 and IS-IS it's a fixed constant.

In this draft Apad is defined as:

In case of IPv4, the first 4 octets contain the IPv4 source address followed by the hexadecimal value 0x878FE1F3 repeated (L-4)/4 times.  
In case of IPv6, the first 16 octets contain the IPv6 source address followed by the hexadecimal value 0x878FE1F3 repeated (L-16)/4 times.

One way to avoid this duplication is by writing a new RFC that redefines HMAC and includes the Apad. Other documents can only mention the Apad value, while including a normative reference to that RFC.

This however is a long drawn discussion because everyone needs to be convinced on the merits of updating the HMAC specification -- which I am not sure will take how long.

Cheers, Manav


> 
> S
> 
> >
> > Cheers, Manav
> >
> >> -----Original Message----- From: Stephen Farrell
> >> [mailto:stephen.farrell@cs.tcd.ie] Sent: Wednesday, May 21, 2014
> >> 2:53 AM To: Bhatia, Manav (Manav); IETF Security Directorate; The
> >> IESG; draft- ietf-mpls-ldp-hello-crypto-auth.all@tools.ietf.org Cc:
> >> Yaron Sheffer; manavbhatia@gmail.com Subject: Re: SecDir review of
> >> draft-ietf-mpls-ldp-hello-crypto-auth-05
> >>
> >>
> >>
> >> On 19/05/14 21:27, Yaron Sheffer wrote:
> >>>>>
> >>>>> * 5.1: Redefining HMAC (RFC 2104) is an extremely bad idea.
> >>>>> This reviewer does not have the appropriate background to
> >>>>> critique the proposed solution, but there must be an
> >>>>> overwhelming reason to
> >> reopen> >>>>> cryptographic primitives.
> >>>>
> >>>> This is a decision that was taken by Sec Ads when we were doing
> >>>> the crypto protection for the IGPs based on some feedback from
> >>>> NIST.
> >> This
> >>>> mathematics is not new and has been done for all IGPs and has
> >>>> been approved and rather encouraged by the Security ADs.
> >>
> >> The above does not sound like something I recognise. I have
> >> repeatedly asked that documents not re-define HMAC. Perhaps this
> >> time, I'll make that a DISCUSS and not budge. I probably should
> >> have done that before TBH.
> >>
> >> If you are revising that doc, *please* get rid of the re-definition
> >> and just properly refer to HMAC. Its about time to stop repeating
> >> that error.
> >>
> >> S.
> >
> >
> >