IETF Logo Mail Archive

Re: [secdir] SecDir Review of draft-ietf-httpauth-scram-auth-11

Alexey Melnikov <alexey.melnikov@isode.com> Sat, 05 December 2015 21:30 UTC

Return-Path: <alexey.melnikov@isode.com>
X-Original-To: secdir@ietfa.amsl.com
Delivered-To: secdir@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id ADE001B2D3B; Sat, 5 Dec 2015 13:30:12 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.011
X-Spam-Level:
X-Spam-Status: No, score=-2.011 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 1mWPkX510Ga3; Sat, 5 Dec 2015 13:30:11 -0800 (PST)
Received: from statler.isode.com (Statler.isode.com [62.232.206.189]) by ietfa.amsl.com (Postfix) with ESMTP id 994011B2D30; Sat, 5 Dec 2015 13:30:11 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1449351010; d=isode.com; s=selector; i=@isode.com; bh=vCbtbWMjvvfNGns8tB98Stf4baPI5nNlIaKAzuPSIqI=; h=From:Sender:Reply-To:Subject:Date:Message-ID:To:Cc:MIME-Version: In-Reply-To:References:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description; b=Gg65kA5Ow+R+P/hBqwPqfUTz92FywUt/nj6p+FWJi+9WH2DmE4f6N8XHpGAq5G3BEH4Tfs Wo/SjNl6RA3EIEjpTZeeq0rz4jjG+wyT8I9r+pQNNz1mGa+6MRmZbOF/Xg6hIbxU4Phdqi 8LDkIpUvD9Q2B75oce5vhSlmCW9hy3E=;
Received: from [192.168.0.5] (cpc5-nmal20-2-0-cust24.19-2.cable.virginm.net [92.234.84.25]) by statler.isode.com (submission channel) via TCP with ESMTPSA id <VmNXYQAlTqag@statler.isode.com>; Sat, 5 Dec 2015 21:30:10 +0000
From: Alexey Melnikov <alexey.melnikov@isode.com>
To: Russ Housley <housley@vigilsec.com>, draft-ietf-httpauth-scram-auth.all@ietf.org
References: <B8DA7647-3F10-4D46-B416-2DC905E4807F@vigilsec.com>
X-Enigmail-Draft-Status: N1110
Message-ID: <56635764.6040600@isode.com>
Date: Sat, 05 Dec 2015 21:30:12 +0000
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0
In-Reply-To: <B8DA7647-3F10-4D46-B416-2DC905E4807F@vigilsec.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="windows-1252"
Content-Transfer-Encoding: quoted-printable
Archived-At: <http://mailarchive.ietf.org/arch/msg/secdir/eMSWhr7xBkHvZ6A_UHdM_IhjCNk>
Cc: IETF SecDir <secdir@ietf.org>
Subject: Re: [secdir] SecDir Review of draft-ietf-httpauth-scram-auth-11
X-BeenThere: secdir@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: Security Area Directorate <secdir.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/secdir>, <mailto:secdir-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/secdir/>
List-Post: <mailto:secdir@ietf.org>
List-Help: <mailto:secdir-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/secdir>, <mailto:secdir-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sat, 05 Dec 2015 21:30:12 -0000

Hi Russ,

I think I addressed everything from your review other than a couple of nits:

On 01/12/2015 17:54, Russ Housley wrote:
> Nits:
>
>
> I think it would be more readable if the Hi function were described in
> its own section.  Also, since the INT function is only used in this one
> place to handle a constant, I wonder if 0x00000001 would be easier to
> understand.
>
> The paragraph beginning with "Formally" in Section 5.1 does not need an
> extra level of indentation.
Can you check the latest version and confirm?

Thank you,
Alexey

v2.23.0 | Report a Bug | By Email