[secdir] Secdir last call review of draft-ietf-sipcore-originating-cdiv-parameter-05

Kyle Rose <krose@krose.org> Mon, 22 October 2018 20:45 UTC

Return-Path: <krose@krose.org>
X-Original-To: secdir@ietf.org
Delivered-To: secdir@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id 53695130F1D; Mon, 22 Oct 2018 13:45:57 -0700 (PDT)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
From: Kyle Rose <krose@krose.org>
To: <secdir@ietf.org>
Cc: sipcore@ietf.org, ietf@ietf.org, draft-ietf-sipcore-originating-cdiv-parameter.all@ietf.org
X-Test-IDTracker: no
X-IETF-IDTracker: 6.87.1
Auto-Submitted: auto-generated
Precedence: bulk
Message-ID: <154024115730.13565.4561513275762767750@ietfa.amsl.com>
Date: Mon, 22 Oct 2018 13:45:57 -0700
Archived-At: <https://mailarchive.ietf.org/arch/msg/secdir/g-d-XIh4M09sXO5MIaZhjysn3d8>
Subject: [secdir] Secdir last call review of draft-ietf-sipcore-originating-cdiv-parameter-05
X-BeenThere: secdir@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Security Area Directorate <secdir.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/secdir>, <mailto:secdir-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/secdir/>
List-Post: <mailto:secdir@ietf.org>
List-Help: <mailto:secdir-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/secdir>, <mailto:secdir-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 22 Oct 2018 20:46:03 -0000

Reviewer: Kyle Rose
Review result: Ready

I have reviewed this document as part of the security directorate's ongoing
effort to review all IETF documents being processed by the IESG.  These
comments were written primarily for the benefit of the security area directors.
 Document editors and WG chairs should treat these comments just like any other
last call comments.

Background: SIP currently provides no standard way to indicate that an invite
via diversion from the original terminating user (e.g., via busy response or an
unconditional call forward) is the result of diversion rather than a new
origination, making it impossible in the absence of proprietary signaling to
distinguish between the two cases. This draft adds an orig-cdiv signal to the
P-Served-User header to indicate an invite resulting from a diversion, allowing
an application server to take different actions in the two cases.

Security evaluation: The addition of a new actionable signal is properly noted
as the main security consideration of this change, along with a reminder that
the P-Served-User header must be implemented as a privileged channel within a
single trust domain and not transited into a domain from an untrusted entity.

Other comments: As a reviewer new to SIP, I found the document very easy to
follow. The introduction contained basic background about the use case, a clear
explanation of the problem, and a high-level overview of the proposed solution.
The normative section of the document was very clearly illustrated by the later
examples section, containing two typical use-cases with clear diagrams. This is
a model internet draft.