Re: [secdir] [TLS] Secdir review of draft-ietf-tls-session-hash-04

Charlie Kaufman <charliekaufman@outlook.com> Fri, 17 April 2015 05:38 UTC

Return-Path: <charliekaufman@outlook.com>
X-Original-To: secdir@ietfa.amsl.com
Delivered-To: secdir@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 95CE51ACE44; Thu, 16 Apr 2015 22:38:01 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.9
X-Spam-Level:
X-Spam-Status: No, score=-1.9 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Wkn_t5Q9haom; Thu, 16 Apr 2015 22:37:58 -0700 (PDT)
Received: from BAY004-OMC2S1.hotmail.com (bay004-omc2s1.hotmail.com [65.54.190.76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id D322F1ACD37; Thu, 16 Apr 2015 22:37:58 -0700 (PDT)
Received: from BAY405-EAS211 ([65.54.190.124]) by BAY004-OMC2S1.hotmail.com over TLS secured channel with Microsoft SMTPSVC(7.5.7601.22751); Thu, 16 Apr 2015 22:37:58 -0700
X-TMN: [mtzEsnJqUbOdfWTmjRVXHku3aK3ma7WP]
X-Originating-Email: [charliekaufman@outlook.com]
Message-ID: <BAY405-EAS2119492891C09C473182F8EDFE30@phx.gbl>
From: Charlie Kaufman <charliekaufman@outlook.com>
To: "'Watson Ladd'" <watsonbladd@gmail.com>, "'Karthikeyan Bhargavan'" <karthik.bhargavan@gmail.com>
References: <CAFOuuo7MA9Rd7zbsic8pJgShYF8NRgnddyC5JHfA6hGcGkkAfA@mail.gmail.com> <BB1534CC-76ED-482E-BA9B-D11E8B52C7AE@gmail.com> <CACsn0cmJBk0BVbktwyf0Qkyd0P8YOwfKz22kUAQmQcKT6W8hUQ@mail.gmail.com>
In-Reply-To: <CACsn0cmJBk0BVbktwyf0Qkyd0P8YOwfKz22kUAQmQcKT6W8hUQ@mail.gmail.com>
Date: Thu, 16 Apr 2015 22:38:00 -0700
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Mailer: Microsoft Outlook 15.0
Thread-Index: AQABAgMEOWnyltKQ8w0oTN5VCJ+wxaDvljJw
Content-Language: en-us
X-OriginalArrivalTime: 17 Apr 2015 05:37:58.0604 (UTC) FILETIME=[A98068C0:01D078D0]
Archived-At: <http://mailarchive.ietf.org/arch/msg/secdir/gtC5FDRnridc3UXngb_cJAfwplo>
Cc: draft-ietf-tls-session-hash.all@tools.ietf.org, 'The IESG' <iesg@ietf.org>, secdir@ietf.org
Subject: Re: [secdir] [TLS] Secdir review of draft-ietf-tls-session-hash-04
X-BeenThere: secdir@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: Security Area Directorate <secdir.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/secdir>, <mailto:secdir-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/secdir/>
List-Post: <mailto:secdir@ietf.org>
List-Help: <mailto:secdir-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/secdir>, <mailto:secdir-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 17 Apr 2015 05:38:01 -0000

Making a completely breaking change to a protocol - where no new implementation will interoperate with any existing implementation - seems like a bad idea under almost all circumstances. Am I reading the document correctly and that is the implication of implementing the features labelled "SHOULD"?

At the very least, if you are going to break interoperability, I would think you would introduce a new version number to the protocol rather than (and do I have this right?) make this change to all versions of TLS so that there will be a new TLS 1.0, TLS 1.1, and TLS 1.2 with this extension but none of them will interoperate with old implementations of any version of TLS?

And worst of all, if you are going to completely break interoperability without introducing a new version number, you should warn people about it in dramatic terms in the introduction to the RFC rather than have it be something that alert people will figure out when reading the spec and others will discover only when they try to deploy it.

The vulnerability that this extension addresses affects a tiny fraction of scenarios. I would expect that most people would decline to upgrade their implementation of TLS to fix that vulnerability if the cost were to break everything.

In the best case, people will ignore the fact that the step in the algorithm that breaks interoperability is labelled SHOULD and will instead deploy it such that the mitigation is effective only after both ends are upgraded, with a configuration switch allowing the mitigation to be required in scenarios where a single customer controls both ends of the connection. It would be reasonable to require the more secure behavior in TLS v1.3 (assuming that is the next version), since implementations not supporting it will negotiate down to a lower version.

But specifying a SHOULD behavior and hoping implementers will have the good sense to ignore it seems like we're looking for trouble.

	--Charlie

-----Original Message-----
From: secdir [mailto:secdir-bounces@ietf.org] On Behalf Of Watson Ladd
Sent: Thursday, April 16, 2015 8:33 AM
To: Karthikeyan Bhargavan
Cc: secdir@ietf.org; draft-ietf-tls-session-hash.all@tools.ietf.org; The IESG
Subject: Re: [secdir] [TLS] Secdir review of draft-ietf-tls-session-hash-04

On Thu, Apr 16, 2015 at 12:06 AM, Karthikeyan Bhargavan <karthik.bhargavan@gmail.com>; wrote:
> Hi Radia,
>
> Thanks for the comments. I made many of the smaller changes, and have 
> some questions about the interop concerns.
>
>> In particular, section 5.2 paragraph 4 & 5 say:
>>
>> "If the server receives a ClientHello without the extension, it 
>> SHOULD abort the handshake. If it chooses to continue, then it MUST 
>> NOT include the extension in the ServerHello."
>>
>> "If a client receives a ServerHello without the extension, it SHOULD 
>> abort the handshake.”
>
> The style we chose was to say that the client/server SHOULD abort the 
> handshake, but we also say in paragraph 7:
>
> "If the client or server choose to continue a full handshake without the extension, they use the legacy master secret derivation for the new session. In this case, the considerations in section 5.4 apply.”
>
> That is, we do offer them the choice of opting out of this draft for 
> interoperability, by following the recommendations in 5.4.
>
> We could make this forward pointer more explicit by saying instead:
>
> β€œIn order to interoperate with legacy peers, some lients and servers 
> may choose to  to continue a full handshake without the extension. In 
> this case, they use  the  legacy master secret derivation for the new 
> session, and the  considerations in section 5.4 apply.”
>
> Would this assuage the security/interoperability concern?
>
>
>> In section 5.3, there is similar language to disable session 
>> resumption when the extension is not present. While this may be more 
>> acceptable because it will not break interoperability, it *will* 
>> cause a significant performance degradation in some important 
>> scenarios. I would again recommend that it be a configuration 
>> parameter so that no one will refuse to deploy this change because of performance concerns.

I seem to recall a discussion about this, where my minority position was that breaking renegotiation instead was more acceptable. We need to break one, and renegotiation is not used nearly as commonly for browsers.

>
> During resumption we use similar language to point forward to section 
> 5.2 if the client or server chooses to continue without the extension.
>
>> Section 5.4 also mandates breaking behavior (and here it is a MUST) 
>> in scenarios where there is most likely to be a triple handshake vulnerability.
>> Given that there are cases with no such vulnerability and given that 
>> people will be reluctant to deploy software that turns a subtle 
>> security vulnerability into non-interoperability, I believe this 
>> should be a matter of configuration.
>
> This case seems most difficult, because section 5.4 is the defense of 
> last resort. Weakening the MUST requirements here would, in our mind, 
> be tantamount to disabling the extension altogether.

Web browsers have adopted a more minimal solution, namely not permitting renegotiation to change certificates. I doubt that the stricter defense in 5.4 will cause interoperability issues, and it may have been adopted by some of them. Input from browser writers would be greatly appreciated.

Sincerely,
Watson Ladd

>
> Recall that in  the triple handshake attack, the man-in-the-middle is 
> a valid peer who is trying to fool both the client and the server. 
> Hence, we cannot rely on this man-in-the-middle sending the extension. 
> If we allow handshakes without the extension, the attack cannot be prevented, only mitigated.
> The MUSTs in this section try to enforce these mitigations.
>
> Best regards,
> Karthik
>
>
>>
>> Section 5.4 paragraph 4 seems to be undermining earlier requirements, 
>> saying that it MAY be safe (to break rules stated earlier). Taking 
>> this to heart, I would propose that the "MUST abort" clauses in 
>> sections 5.2 and 5.3 be softened to at least allow - and perhaps 
>> recommend - implementations to support this scenario.
>>
>> -------
>>
>> Nits:
>>
>> In section 6.2, it is claimed that the security of TLS depends on the 
>> hash function used being collision resistant, use of MD5 and SHA1 is 
>> NOT RECOMMENDED. That would rule out use of TLS 1.0 and TLS 1.1. 
>> While a worthy goal, I don't believe this enhancement makes migration 
>> away from TLS 1.0 and TLS 1.1 any more urgent. I also don't believe 
>> that TLS depends on the hash function being collision resistant (but 
>> only that it is second preimage resistant).
>>
>> P9: "each other identity" -> "each other's identities"
>> P10: "that where hence" -> "that were hence"
>> P11: "server/ Hence," -> "server. Hence,
>
> _______________________________________________
> TLS mailing list
> TLS@ietf.org
> https://www.ietf.org/mailman/listinfo/tls



--
"Man is born free, but everywhere he is in chains".
--Rousseau.

_______________________________________________
secdir mailing list
secdir@ietf.org
https://www.ietf.org/mailman/listinfo/secdir
wiki: http://tools.ietf.org/area/sec/trac/wiki/SecDirReview