Re: [secdir] [Idr] Secdir early review of draft-ietf-idr-te-pm-bgp-13

"Les Ginsberg (ginsberg)" <ginsberg@cisco.com> Sun, 21 October 2018 20:33 UTC

Return-Path: <ginsberg@cisco.com>
X-Original-To: secdir@ietfa.amsl.com
Delivered-To: secdir@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id E7B3F130DEE; Sun, 21 Oct 2018 13:33:08 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -14.5
X-Spam-Level:
X-Spam-Status: No, score=-14.5 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_MED=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, URIBL_BLOCKED=0.001, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cisco.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id aYE3svPChysl; Sun, 21 Oct 2018 13:33:06 -0700 (PDT)
Received: from alln-iport-1.cisco.com (alln-iport-1.cisco.com [173.37.142.88]) (using TLSv1.2 with cipher DHE-RSA-SEED-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 8F9371200D7; Sun, 21 Oct 2018 13:33:05 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=17594; q=dns/txt; s=iport; t=1540153985; x=1541363585; h=from:to:cc:subject:date:message-id:references: in-reply-to:mime-version; bh=J83RDefrqaCsDynJ1mVF04lQiO0EMKyAk4NeqE7hmAg=; b=TUpcdxhbqdpprrxjGW6BwIssi0TSE8rpCUtrrF84owz2kMy78R7mYFSl PeQNEDEAyMpWie2J8F9Y7IwGHa6HIY847hocWT3uqoije4HhxlWNMITdN I9C0d09eUYQjCdX0hn8NCiispw/2fgVeNPz3VmOfwGSGLF+rfeT9ixqin c=;
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: A0AFAABO4cxb/5JdJa1iGQEBAQEBAQEBAQEBAQcBAQEBAQGBUQQBAQEBAQsBgQ1IL2Z/KAqDa4gYjBmCDYh6iFOFSIF6CwEBI4RJAheEcSE0DQ0BAwEBAgEBAm0cDIU6AQEBBCMKRQcQAgEIDgMEAQEoAwICAh8RFAkIAgQOBQgXgwOBHUwDFQ+kHYEuh24NghMFi1IXgUE/gRABgmQuglZFAQECAYF1DxCCTYJXAopXg16GEolTLgkChmCCYoQKgxwfgVKEc4lpjFh4iGYCERSBJh04gVVwFYMnixmFPm8BAYpYgR8BAQ
X-IronPort-AV: E=Sophos;i="5.54,409,1534809600"; d="scan'208,217";a="189383103"
Received: from rcdn-core-10.cisco.com ([173.37.93.146]) by alln-iport-1.cisco.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 Oct 2018 20:33:04 +0000
Received: from XCH-RCD-004.cisco.com (xch-rcd-004.cisco.com [173.37.102.14]) by rcdn-core-10.cisco.com (8.15.2/8.15.2) with ESMTPS id w9LKX40H008322 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=FAIL); Sun, 21 Oct 2018 20:33:04 GMT
Received: from xch-aln-001.cisco.com (173.36.7.11) by XCH-RCD-004.cisco.com (173.37.102.14) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Sun, 21 Oct 2018 15:33:03 -0500
Received: from xch-aln-001.cisco.com ([173.36.7.11]) by XCH-ALN-001.cisco.com ([173.36.7.11]) with mapi id 15.00.1395.000; Sun, 21 Oct 2018 15:33:03 -0500
From: "Les Ginsberg (ginsberg)" <ginsberg@cisco.com>
To: Yoav Nir <ynir.ietf@gmail.com>
CC: Robert Raszuk <robert@raszuk.net>, "kaduk@mit.edu" <kaduk@mit.edu>, "idr@ietf.org" <idr@ietf.org>, "draft-ietf-idr-te-pm-bgp.all@ietf.org" <draft-ietf-idr-te-pm-bgp.all@ietf.org>, "ietf@ietf.org" <ietf@ietf.org>, "secdir@ietf.org" <secdir@ietf.org>
Thread-Topic: [Idr] [secdir] Secdir early review of draft-ietf-idr-te-pm-bgp-13
Thread-Index: AQHUZZW9XPWYyIUJa0CAw27zofyhmaUihppwgAGMV4D//8FaoIABtlGA///AT8CAAMKMAIAAa5YAgAAtaFCAA62rgP//2v5w
Date: Sun, 21 Oct 2018 20:33:03 +0000
Message-ID: <c204c2699675433cad9ac5342cdf0cc9@XCH-ALN-001.cisco.com>
References: <153972468642.9298.14442375581871750001@ietfa.amsl.com> <ec43e712e8024930831a206f8e843cbb@XCH-ALN-001.cisco.com> <7655493D-9EF0-42FF-B2D3-B9CE4E78178D@gmail.com> <feec42a72bd64f31afbcb3b340dad52b@XCH-ALN-001.cisco.com> <1FFA9449-D03C-4EB6-9D08-BA4A1AA93FE3@gmail.com> <92af26fef2da470d853f292c84f026a0@XCH-ALN-001.cisco.com> <20181019002642.GX19309@kduck.kaduk.org> <CAOj+MMH1=SBV=ikiNE6UHEe1mzf5xKLPOZXnnqPEvyFHTC=83A@mail.gmail.com> <c22b55313bc54157853d5668a146038c@XCH-ALN-001.cisco.com> <14949BEE-1EC4-46A0-A1FD-8FE4BCD5D417@gmail.com>
In-Reply-To: <14949BEE-1EC4-46A0-A1FD-8FE4BCD5D417@gmail.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ms-exchange-transport-fromentityheader: Hosted
x-originating-ip: [10.24.113.215]
Content-Type: multipart/alternative; boundary="_000_c204c2699675433cad9ac5342cdf0cc9XCHALN001ciscocom_"
MIME-Version: 1.0
X-Outbound-SMTP-Client: 173.37.102.14, xch-rcd-004.cisco.com
X-Outbound-Node: rcdn-core-10.cisco.com
Archived-At: <https://mailarchive.ietf.org/arch/msg/secdir/hscRrQWIs1MQ8nwNmfe0CxYpQ-k>
Subject: Re: [secdir] [Idr] Secdir early review of draft-ietf-idr-te-pm-bgp-13
X-BeenThere: secdir@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Security Area Directorate <secdir.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/secdir>, <mailto:secdir-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/secdir/>
List-Post: <mailto:secdir@ietf.org>
List-Help: <mailto:secdir-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/secdir>, <mailto:secdir-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sun, 21 Oct 2018 20:33:09 -0000

Yoav –

Thanx for the suggestion. I have just posted V14 of the draft which I believe addresses your concerns – please review and confirm.

   Les


From: Yoav Nir <ynir.ietf@gmail.com>
Sent: Sunday, October 21, 2018 10:45 AM
To: Les Ginsberg (ginsberg) <ginsberg@cisco.com>
Cc: Robert Raszuk <robert@raszuk.net>; kaduk@mit.edu; idr@ietf.org; draft-ietf-idr-te-pm-bgp.all@ietf.org; ietf@ietf.org; secdir@ietf.org
Subject: Re: [Idr] [secdir] Secdir early review of draft-ietf-idr-te-pm-bgp-13

See inline.


On 19 Oct 2018, at 17:51, Les Ginsberg (ginsberg) <ginsberg@cisco.com<mailto:ginsberg@cisco.com>> wrote:

Robert’s post addresses points I also want to make.

What is being done here is to add additional BGP-LS codepoints to advertise IGP information that was not defined at the time RFC 7752 was written. We haven’t changed the  BGP-LS transport mechanism – nor is the information being advertised here (some additional TE related link attribute information) qualitatively different than a number of existing TLVs defined in RFC 7752 (see https://tools.ietf.org/html/rfc7752#section-3.3.2 ). If this information had already been defined in the IGPs at the time RFC 7752 was written it would simply have been included as a section of RFC 7752 and no additional changes to RFC 7752 would have been required.

In theory, we could have simply updated RFC 7752 rather writing a separate draft, but practically this would be a poor strategy as it would incorrectly suggest that some change was being made to the existing text in RFC 7752.

I appreciate that from the POV of the Security Area you folks are not as intimately familiar with the routing drafts and the relationship between them. It is therefore understandable that you start looking at the new draft as a standalone document – and in that context your comments are absolutely correct. But the document you are reviewing is most accurately seen as an “addendum” to RFC 7752.

[YN] Right, and as such, I believe that this document should address the part that it adds to RFC 7752. IOW it should state that the new IGP information that will now be sent through BGP does not present new/different risk to the information already defined in 7752. This is information that has up until now only been sent in IS-IS and OSPF and will not be sent in BGP, so we need a statement that it’s OK to send these attributes in BGP as well. Of course, such a statement could be challenged in WGLC or IETF LC, but it should be made.


The issues you raise have already been addressed in RFC 7752 and it is therefore very appropriate that we address your concerns by including a reference to the RFC 7752 security discussion.

I think it is important that you note this relationship, because the nature of BGP-LS is that whenever IGP extensions are defined to advertise new information it is necessary to define corresponding BGP-LS codepoints. This is not the first such BGP-LS extension document – and it is safe to say it won’t be the last. It would be helpful to all if we reached a common understanding or this discussion will take place every time a BGP-LS extension document is being reviewed – which will cost us all time needlessly.

   Les