Re: [secdir] Secdir last call review of draft-ietf-calext-eventpub-extensions-12

Daniel Migault <daniel.migault@ericsson.com> Tue, 23 April 2019 13:02 UTC

Return-Path: <daniel.migault@ericsson.com>
X-Original-To: secdir@ietfa.amsl.com
Delivered-To: secdir@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 6616912042D; Tue, 23 Apr 2019 06:02:51 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.001
X-Spam-Level:
X-Spam-Status: No, score=-2.001 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=ericsson.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id mJgtyg-AL91c; Tue, 23 Apr 2019 06:02:49 -0700 (PDT)
Received: from NAM05-DM3-obe.outbound.protection.outlook.com (mail-eopbgr730084.outbound.protection.outlook.com [40.107.73.84]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id DA870120429; Tue, 23 Apr 2019 06:02:45 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericsson.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fgnshjnX6hY74jeoUypE04h8e/79anQ6QcqWnitx16M=; b=jV5QSgIMiUPyuzTzZ2JRclQW5mjoCtt+3w/HXe0TZuVWLzltyFqB8rSwkvosfFeZE4SzO8617yM0XuUMFFBOl2bYA7P8dAygEoOzqnH4RpFrliRIb32jb5bPx9zf5EQ0Cll6TXgoFi7mnRfrOgZo10H637uDPe2WhMt8hgu0/qc=
Received: from MN2PR15MB3310.namprd15.prod.outlook.com (20.179.21.142) by MN2PR15MB2941.namprd15.prod.outlook.com (20.178.252.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1813.16; Tue, 23 Apr 2019 13:02:42 +0000
Received: from MN2PR15MB3310.namprd15.prod.outlook.com ([fe80::1526:901b:cb1a:5fef]) by MN2PR15MB3310.namprd15.prod.outlook.com ([fe80::1526:901b:cb1a:5fef%3]) with mapi id 15.20.1813.017; Tue, 23 Apr 2019 13:02:42 +0000
From: Daniel Migault <daniel.migault@ericsson.com>
To: Rich Salz <rsalz@akamai.com>, "secdir@ietf.org" <secdir@ietf.org>
CC: "draft-ietf-calext-eventpub-extensions.all@ietf.org" <draft-ietf-calext-eventpub-extensions.all@ietf.org>, "ietf@ietf.org" <ietf@ietf.org>, "calsify@ietf.org" <calsify@ietf.org>
Thread-Topic: Secdir last call review of draft-ietf-calext-eventpub-extensions-12
Thread-Index: AQHU+Tc7pc5UYH8MwUCRn5sj/IlATaZJtyFw
Date: Tue, 23 Apr 2019 13:02:42 +0000
Message-ID: <MN2PR15MB33108E41A1A75A033987C79DE3230@MN2PR15MB3310.namprd15.prod.outlook.com>
References: <155595686177.21216.4076761255030943970@ietfa.amsl.com>
In-Reply-To: <155595686177.21216.4076761255030943970@ietfa.amsl.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: spf=none (sender IP is ) smtp.mailfrom=daniel.migault@ericsson.com;
x-originating-ip: [192.75.88.130]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 58d2e83c-d93f-4155-eac5-08d6c7ebf901
x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600141)(711020)(4605104)(2017052603328)(7193020); SRVR:MN2PR15MB2941;
x-ms-traffictypediagnostic: MN2PR15MB2941:
x-microsoft-antispam-prvs: <MN2PR15MB2941B8F8CAB2C6DA3B41B982E3230@MN2PR15MB2941.namprd15.prod.outlook.com>
x-forefront-prvs: 0016DEFF96
x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(366004)(136003)(346002)(39860400002)(376002)(396003)(199004)(189003)(13464003)(51914003)(4326008)(110136005)(54906003)(66946007)(66476007)(73956011)(66556008)(66446008)(71200400001)(99286004)(6436002)(229853002)(66066001)(64756008)(8936002)(71190400001)(7696005)(86362001)(2501003)(14454004)(7736002)(76176011)(44832011)(33656002)(305945005)(478600001)(2906002)(26005)(76116006)(256004)(14444005)(186003)(74316002)(3846002)(6246003)(53936002)(476003)(11346002)(5660300002)(97736004)(6116002)(316002)(81166006)(6506007)(81156014)(486006)(25786009)(8676002)(53546011)(52536014)(102836004)(68736007)(446003)(9686003)(55016002); DIR:OUT; SFP:1101; SCL:1; SRVR:MN2PR15MB2941; H:MN2PR15MB3310.namprd15.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1;
received-spf: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam-message-info: iI27AL15Bj4z9TcBMjbhm6fheg1lzsrVgwEYepsvKc/ncYb9Bcbnc3LbkjY/S6lHS8RO1ZUalT9/G+EhoZm5LpENcz2dJEkkNIvxjPNGw3fSzyJy7Z2QOGjwV4DPwq3ZEW+vnWF12YQbVhrDzKlSE0FoFS6Wq7mVbsgoQJw4vnblmwc7WV36P3vawHit3+XYqWj127w8/n9SknxivwKtrvzEQ9RlSmtH/unNLQJHmqVCPvZ00v7E4RXGmnlLT9QFlCaHVWPvH4sc0BLBh5MDDXX/4LKIHO+q8vagqayzInTtOB5TpxanY+Zj0tm+36mF9AsfqahgivuQ4qmeQQdhC6Wxjs4PUwoRkP3Uj+G9I4UHlZFSKiiP75234dBRfoOjvibpzyqs8WA0YK+utDT6CuGBTd2WbdqywBDJI2lmUS4=
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: ericsson.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 58d2e83c-d93f-4155-eac5-08d6c7ebf901
X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Apr 2019 13:02:42.6707 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 92e84ceb-fbfd-47ab-be52-080c6b87953f
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR15MB2941
Archived-At: <https://mailarchive.ietf.org/arch/msg/secdir/lzZXu7IKXQlFuzOLxezbMrp3VeY>
Subject: Re: [secdir] Secdir last call review of draft-ietf-calext-eventpub-extensions-12
X-BeenThere: secdir@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Security Area Directorate <secdir.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/secdir>, <mailto:secdir-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/secdir/>
List-Post: <mailto:secdir@ietf.org>
List-Help: <mailto:secdir-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/secdir>, <mailto:secdir-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 23 Apr 2019 13:02:52 -0000

Thanks for the review Rich!
Yours, 
Daniel

-----Original Message-----
From: Rich Salz via Datatracker <noreply@ietf.org>; 
Sent: Monday, April 22, 2019 2:14 PM
To: secdir@ietf.org
Cc: draft-ietf-calext-eventpub-extensions.all@ietf.org; ietf@ietf.org; calsify@ietf.org
Subject: Secdir last call review of draft-ietf-calext-eventpub-extensions-12

Reviewer: Rich Salz
Review result: Has Nits

This is the SECDIR last-call review, intended to be input to the Security AD's.

Ready with nits.

The Security Considerations and Privacy Considerations are short, but they seem to reasonably refer to already-published documents.

Following are nits I noticed.

Abstract "a number of new iCalendar properties and components" -> "a new iCalendar component and a number of properties"  Maybe stike "iCalendar"

Sec 1, STRUCTURED-DATA. In my opinion the confirmation code would be the most useful new info :)

Sec 1, SOURCE Is it redefined or extended?

Sec 2, para 2.  "In a break with this 'tradition' ..." --> "Breaking with this practice, ..."

Sec 3, "When a calendar client receives a calendar component" Should the second calendar be CALENDAR? Should the first be "iCalendar"?

Sec 3.1.1, uppercase "vcard"?

Sec 3.1.2.1 "non of which" --> "none of which"

Sec 4 Perhaps add a sentence saying where this syntax is defined. Is this the complete iCalendar spec or is it just changing a few things?

Sec 5.1, etc "as laid down in" Is kind of informal wording.

Sec 6, the notation has "value=URI" but the example has "URL" (Sec 7.3, etc., uses URI in both parts)

Sec 10, "applications using" Is "acting on" better?