[secdir] Re: Secdir last call review of draft-ietf-teas-enhanced-vpn-18

"Dongjie (Jimmy)" <jie.dong@huawei.com> Wed, 22 May 2024 03:23 UTC

Return-Path: <jie.dong@huawei.com>
X-Original-To: secdir@ietfa.amsl.com
Delivered-To: secdir@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id C7F64C1C3D54; Tue, 21 May 2024 20:23:10 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.897
X-Spam-Level:
X-Spam-Status: No, score=-6.897 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_HI=-5, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id N9so0Avkki0o; Tue, 21 May 2024 20:23:08 -0700 (PDT)
Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 59CDBC1D6FD1; Tue, 21 May 2024 20:23:08 -0700 (PDT)
Received: from mail.maildlp.com (unknown [172.18.186.31]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4Vkc6w3GJLz6J7Q4; Wed, 22 May 2024 11:22:16 +0800 (CST)
Received: from lhrpeml500001.china.huawei.com (unknown [7.191.163.213]) by mail.maildlp.com (Postfix) with ESMTPS id B8BF81404F9; Wed, 22 May 2024 11:23:05 +0800 (CST)
Received: from dggpemm500008.china.huawei.com (7.185.36.136) by lhrpeml500001.china.huawei.com (7.191.163.213) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Wed, 22 May 2024 04:23:04 +0100
Received: from kwepemf100006.china.huawei.com (7.202.181.220) by dggpemm500008.china.huawei.com (7.185.36.136) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Wed, 22 May 2024 11:23:02 +0800
Received: from kwepemf100006.china.huawei.com ([7.202.181.220]) by kwepemf100006.china.huawei.com ([7.202.181.220]) with mapi id 15.02.1544.004; Wed, 22 May 2024 11:23:02 +0800
From: "Dongjie (Jimmy)" <jie.dong@huawei.com>
To: Rich Salz <rsalz@akamai.com>, "secdir@ietf.org" <secdir@ietf.org>
Thread-Topic: Secdir last call review of draft-ietf-teas-enhanced-vpn-18
Thread-Index: AQHaq6CmgSHrROpJ1U+zPxhjXqbg+rGik+4g
Date: Wed, 22 May 2024 03:23:02 +0000
Message-ID: <1f07c09b433f46698580e4b81cd7dbc8@huawei.com>
References: <171631086609.49957.9599834466479684914@ietfa.amsl.com>
In-Reply-To: <171631086609.49957.9599834466479684914@ietfa.amsl.com>
Accept-Language: en-US, zh-CN
Content-Language: zh-CN
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [10.112.40.66]
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
Message-ID-Hash: EGAXYBRKI6NHFRWAZXRQYTGS3XMQR3WY
X-Message-ID-Hash: EGAXYBRKI6NHFRWAZXRQYTGS3XMQR3WY
X-MailFrom: jie.dong@huawei.com
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-secdir.ietf.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header
CC: "draft-ietf-teas-enhanced-vpn.all@ietf.org" <draft-ietf-teas-enhanced-vpn.all@ietf.org>, "last-call@ietf.org" <last-call@ietf.org>, "teas@ietf.org" <teas@ietf.org>
X-Mailman-Version: 3.3.9rc4
Precedence: list
Subject: [secdir] Re: Secdir last call review of draft-ietf-teas-enhanced-vpn-18
List-Id: Security Area Directorate <secdir.ietf.org>
List-Archive: <https://mailarchive.ietf.org/arch/browse/secdir>
List-Help: <mailto:secdir-request@ietf.org?subject=help>
List-Owner: <mailto:secdir-owner@ietf.org>
List-Post: <mailto:secdir@ietf.org>
List-Subscribe: <mailto:secdir-join@ietf.org>
List-Unsubscribe: <mailto:secdir-leave@ietf.org>

Hi Rich, 

Thanks a lot for the review. We will produce an update version to address your comments. 

> -----Original Message-----
> From: Rich Salz via Datatracker [mailto:noreply@ietf.org]
> Sent: Wednesday, May 22, 2024 1:01 AM
> To: secdir@ietf.org
> Cc: draft-ietf-teas-enhanced-vpn.all@ietf.org; last-call@ietf.org; teas@ietf.org
> Subject: Secdir last call review of draft-ietf-teas-enhanced-vpn-18
> 
> Reviewer: Rich Salz
> Review result: Has Nits
> 
> All page references are to the text version available at
> https://datatracker.ietf.org/doc/draft-ietf-teas-enhanced-vpn/
> 
> I found it frustrating that the VPN acronym was explained in the Introduction
> but it wasn't until the bottom of p4 that NRP was spelled out.

We will expand NRP with brief description in the abstract and introduction.

> 
> Bottom of page 5 has "The required layered network structure ..."  Hubris? ;)
> Maybe "One possible layered network ..."

OK, we will make this change accordingly.

> 
> Other then that, the introduction does a GREAT job of explaining the motivation,
> issues, and technology involved. This holds true, analogously, for all the other
> sections. As a result, I am bothered that I have to say "it has nits" because they
> really pale in comparison to the rest of the text. Congrats to the authors.

Thanks:)
 
> I paid special attention to the security considerations and could not think of
> anything not already well-covered there.
> 
> Even if not addressed, this document is ready and really brings up the quality
> average of IETF RFCs.
> 
> 

Best regards,
Jie