IETF Logo Mail Archive

Re: [secdir] SECDIR Review of draft-ietf-lamps-rfc5990bis-05

Donald Eastlake <d3e3e3@gmail.com> Tue, 23 April 2024 15:32 UTC

Return-Path: <d3e3e3@gmail.com>
X-Original-To: secdir@ietfa.amsl.com
Delivered-To: secdir@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id C06E4C14F70C; Tue, 23 Apr 2024 08:32:41 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.847
X-Spam-Level:
X-Spam-Status: No, score=-1.847 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id un_zkO3OBB0G; Tue, 23 Apr 2024 08:32:39 -0700 (PDT)
Received: from mail-lj1-x235.google.com (mail-lj1-x235.google.com [IPv6:2a00:1450:4864:20::235]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 0CD17C14F6BC; Tue, 23 Apr 2024 08:32:18 -0700 (PDT)
Received: by mail-lj1-x235.google.com with SMTP id 38308e7fff4ca-2de232989aaso9283931fa.1; Tue, 23 Apr 2024 08:32:17 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713886336; x=1714491136; darn=ietf.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=EC6ErGhQN9s3UxH+7++4M6sIucyxPfoKWPn/1T+U99o=; b=hyg3zWPvKai1hEnRhhmpApLhzRSuNBp+I5Vyq3gICes6L7/FYqPFTWaApDt2/WagXv 6OIOPqp9UrHsZV6JRH75KVgX9nvNGjB+ZQxxey4+op6d5zs9x4yeW0hSO5WFHCPqXo9U Pcybx0mQxTOyj+yjgPkRuUwG4+3vfWTA12Tfk2v7ug9kmDzWolN5/poQk981nGX9ElzJ VVo8aM8KgbVJ1+k0KwumpbXYZpt/NR8hOg4OiQAl5jT273SiNKk4DPd/MmIKzCG+mor4 3mc3S5od/hcdjJmbUXlFBpr0GtW6moXTMc3xDrNDn3P+C/m4jQ/Zd+IxuaeSRcZSUrcy rqFA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713886336; x=1714491136; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=EC6ErGhQN9s3UxH+7++4M6sIucyxPfoKWPn/1T+U99o=; b=FuoUSkmBTor3EKAKfnd4uwdMpfViofMFKifaxp0yFFfCIvSAY+gTVolW7oqEiD4rvF jGe2esAqYlbXNqxqsKIBn6S7DvvqweMT3cLyDn5JGG2/5cD96vlI+hDYCPqBbq0NF6x4 yrmGy6OVU2VUS9u0p+uD6nRq/138o+USTOSNxLS78UI0pPHBmq8qP41UmA3GzsAsOJBt ejj1Hh4U5oxwXiIxacz6UFZlqyKaIRqreu7tyrGEAjvIbDnKQTWDbZOGG19Z4HPMwjgo eNgNHZoIfzhueo+a4HPASJ4+3dQOVwwyb4Owqr80Lir9scFHpImVjNlq1LcNHpYPAiC9 EASg==
X-Forwarded-Encrypted: i=1; AJvYcCWoczSRq9oG2ZCe+h3PNRa6EvtXEqZ2DapOtv7Tsv3VpQJZEdyxPf/rXbJgXY5xs+szRF8NwzMkbgIHXfWI0C6MfhNHBwYJj5RvGCiEIpAdSzkl3+h5dMruPxXpYlp1a/swZ/Q5bftvws8=
X-Gm-Message-State: AOJu0YyE0nLo3ya9r8hGFsw94Q9Yu0+9m3nc6/MbeqM+Y1ACKNensfh7 vLLBB58+p4m7DdGwGjdo9rlwrNSx+CnF80ZdPW3xhs4AwQ9EdCBRHN5k89+Crc61EwM69WzjVYC /F3XIDz9ZzEE/77ZhkkWh7EFAcapDXw==
X-Google-Smtp-Source: AGHT+IEARq39HobC2d2RJ3R0hSI7Wf/DpgCaDr9JvukoAKZu7EO1n7t/bhGRZwZKNC3zNsVLNytLYPo0P9iJHn+qnPg=
X-Received: by 2002:a05:651c:1688:b0:2d3:f095:ff2a with SMTP id bd8-20020a05651c168800b002d3f095ff2amr7473313ljb.47.1713886335912; Tue, 23 Apr 2024 08:32:15 -0700 (PDT)
MIME-Version: 1.0
References: <CAF4+nEHOBxpdVj-b1-VDAFRJpKyp9+xykVaY1XJUOmuDb=+HiA@mail.gmail.com> <EB0522B9-B1BA-47C1-A24E-01DB77FE2977@vigilsec.com> <0419DBE9-0B6F-4BA7-B0CA-7EEBE6A22903@vigilsec.com>
In-Reply-To: <0419DBE9-0B6F-4BA7-B0CA-7EEBE6A22903@vigilsec.com>
From: Donald Eastlake <d3e3e3@gmail.com>
Date: Tue, 23 Apr 2024 11:32:03 -0400
Message-ID: <CAF4+nEEfNkOCvmYFzmdGDa+1g8P8fCDHDzDp9-ygp7-Mr1m04Q@mail.gmail.com>
To: Russ Housley <housley@vigilsec.com>
Cc: IESG <iesg@ietf.org>, IETF SecDir <secdir@ietf.org>, draft-ietf-lamps-rfc5990bis.all@ietf.org
Content-Type: multipart/alternative; boundary="0000000000003cd8470616c54217"
Archived-At: <https://mailarchive.ietf.org/arch/msg/secdir/m3GkB3B4_j5BkY_sNv-yT_5A8qA>
Subject: Re: [secdir] SECDIR Review of draft-ietf-lamps-rfc5990bis-05
X-BeenThere: secdir@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: Security Area Directorate <secdir.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/secdir>, <mailto:secdir-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/secdir/>
List-Post: <mailto:secdir@ietf.org>
List-Help: <mailto:secdir-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/secdir>, <mailto:secdir-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 23 Apr 2024 15:32:41 -0000

Looks good.

Thanks,
Donald
===============================
 Donald E. Eastlake 3rd   +1-508-333-2270 (cell)
 2386 Panoramic Circle, Apopka, FL 32703 USA
 d3e3e3@gmail.com


On Tue, Apr 23, 2024 at 10:29 AM Russ Housley <housley@vigilsec.com> wrote:

> I believe this resolves you comments:
> https://github.com/lamps-wg/rfc5990bis/pull/18
>
> Russ
>
>
> On Apr 23, 2024, at 10:11 AM, Russ Housley <housley@vigilsec.com> wrote:
>
> Donald:
>
> Thanks for the review.
>
> Trivia:
>
> Note duplicated phrase in the 2nd sentence of this paragraph:
>  The RSA-KEM Algorithm provides a fixed-length ciphertext.  The
>  recipient MUST check that the received byte string is the expected
>  length and the expected length and corresponds to an integer in the
>  expected range prior to attempting decryption with their RSA private
>  key as described in Steps 1 and 2 of Appendix A.2.
>
>
> s/length and the expected length and corresponds/length and corresponds/
>
> Appendix A: Inconsistent capitalization: SS, ss
>
>
> s/same shared secret (ss)/same shared secret (SS)/
>
> Also noticed: s/ssLen bytes fron/ssLen bytes from/
>
> Russ
>
>
>

v2.43.4 | Report a Bug | By Email | System Status