Re: [secdir] SECDIR review of draft-josefsson-gss-capsulate-04

Simon Josefsson <simon@josefsson.org> Wed, 18 May 2011 06:42 UTC

Return-Path: <simon@josefsson.org>
X-Original-To: secdir@ietfa.amsl.com
Delivered-To: secdir@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id C6B3EE0806; Tue, 17 May 2011 23:42:44 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -102.599
X-Spam-Level:
X-Spam-Status: No, score=-102.599 tagged_above=-999 required=5 tests=[BAYES_00=-2.599, USER_IN_WHITELIST=-100]
Received: from mail.ietf.org ([64.170.98.30]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id QCAc-dogu0wU; Tue, 17 May 2011 23:42:44 -0700 (PDT)
Received: from yxa-v.extundo.com (yxa-v.extundo.com [213.115.69.139]) by ietfa.amsl.com (Postfix) with ESMTP id 5F081E0822; Tue, 17 May 2011 23:42:38 -0700 (PDT)
Received: from latte.josefsson.org (c80-216-4-108.bredband.comhem.se [80.216.4.108]) (authenticated bits=0) by yxa-v.extundo.com (8.14.3/8.14.3/Debian-5+lenny1) with ESMTP id p4I6gNoC000734 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); Wed, 18 May 2011 08:42:25 +0200
From: Simon Josefsson <simon@josefsson.org>
To: Chris Lonvick <clonvick@cisco.com>
References: <Pine.GSO.4.63.1104151342060.1613@sjc-cde-011.cisco.com>
OpenPGP: id=B565716F; url=http://josefsson.org/key.txt
X-Hashcash: 1:22:110518:draft-josefsson-gss-capsulate.all@tools.ietf.org::6Ux4xI3P7ObB/Hlk:0n4A
X-Hashcash: 1:22:110518:secdir@ietf.org::ntTVd2Z8AnmYILhg:BUrr
X-Hashcash: 1:22:110518:iesg@ietf.org::QT75CiVLexIAuu3i:HV3T
X-Hashcash: 1:22:110518:clonvick@cisco.com::93CtUh5j5A26piKa:pj84
Date: Wed, 18 May 2011 08:42:23 +0200
In-Reply-To: <Pine.GSO.4.63.1104151342060.1613@sjc-cde-011.cisco.com> (Chris Lonvick's message of "Wed, 20 Apr 2011 16:29:49 -0700 (PDT)")
Message-ID: <87liy4se5s.fsf@latte.josefsson.org>
User-Agent: Gnus/5.110018 (No Gnus v0.18) Emacs/23.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Virus-Scanned: clamav-milter 0.97 at yxa-v
X-Virus-Status: Clean
Cc: draft-josefsson-gss-capsulate.all@tools.ietf.org, iesg@ietf.org, secdir@ietf.org
Subject: Re: [secdir] SECDIR review of draft-josefsson-gss-capsulate-04
X-BeenThere: secdir@ietf.org
X-Mailman-Version: 2.1.12
Precedence: list
List-Id: Security Area Directorate <secdir.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/secdir>, <mailto:secdir-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/secdir>
List-Post: <mailto:secdir@ietf.org>
List-Help: <mailto:secdir-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/secdir>, <mailto:secdir-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 18 May 2011 06:42:44 -0000

Hi Chris,

Thanks for review!  I agree with all your suggestions, and have
published -05 that should address them.  Please verify.

/Simon

Chris Lonvick <clonvick@cisco.com> writes:

> Hi,
>
> I have reviewed this document as part of the security directorate's
> ongoing effort to review all IETF documents being processed by the
> IESG.  These comments were written primarily for the benefit of the
> security area directors.  Document editors and WG chairs should treat
> these comments just like any other last call comments.
>
> Overall, I find the document to be of good quality and ready to progress.
>
> One editorial suggestion I'd make would be to either include or
> directly reference the security section of RFC 2743 in your own
> security considerations section.
>
> Also, I'm just not partial towards the use of "otherwise" to describe
> a return code from gss_oid_equal.  Personally, I think it should be
> directly specified.
>
> Finally, I think you have a formatting inconsistency in Section 4.1;
> the "otherwise" should be tabbed out to line up in the other column.
>
> Regards,
> Chris