Re: [secdir] Secdir last call review of draft-ietf-ace-cbor-web-token-12

Kathleen Moriarty <kathleen.moriarty.ietf@gmail.com> Fri, 02 March 2018 18:29 UTC

Return-Path: <kathleen.moriarty.ietf@gmail.com>
X-Original-To: secdir@ietfa.amsl.com
Delivered-To: secdir@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 9A61E12E8B1; Fri, 2 Mar 2018 10:29:33 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2
X-Spam-Level:
X-Spam-Status: No, score=-2 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id PHYkLQhid0S7; Fri, 2 Mar 2018 10:29:32 -0800 (PST)
Received: from mail-ot0-x22a.google.com (mail-ot0-x22a.google.com [IPv6:2607:f8b0:4003:c0f::22a]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 0071812E878; Fri, 2 Mar 2018 10:29:28 -0800 (PST)
Received: by mail-ot0-x22a.google.com with SMTP id 108so9539856otv.3; Fri, 02 Mar 2018 10:29:28 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=0zAH+2wKqkP0d+h5Q5oQgM1GXDXGT4P2Oh7SddYN7Ok=; b=BIm+3Ixb2SKeTczgTe4O75T1LW7RfT9RGk+Q3WSBiMHQuRxfz4kK2rCf75l8va8QpV io0io15B8nCP/EZh0CkgxqyFpyhC54BmLOPAiHA9U+q8vxpuw5j6Z+laS3Atl116KuKo Jpt7JBpgaUeHbA8e2nIkIQvCAi/Orh092/lBKWpNiEYa6ZROf1ujHbE+glRy4Ss6BUvj c8rXVO0jE0asLjLeBmn1VlsaaKlxM2XsUtoMyPrjiV7b+I/qGvG35889PuM/Qsert6I0 WxSF8bIhsKqbSyqFPaJA1N6mnUk5OVxgwYrOTKz6fUZJyHjRkRw7RHti6guB8f5Z4g6s 3o9Q==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=0zAH+2wKqkP0d+h5Q5oQgM1GXDXGT4P2Oh7SddYN7Ok=; b=b0gh8b0lgIeVxw1sEEtjrMBiJOGBtfTWcaluFXdr2fznSUz8dm1s78zpq7ATT1PhVs JQa061gL1NiPvl6WahGpNC7CM7197m7S6d4CXWEXUC8Nhj+lPi6yfyOp2gq1HTQxXiNa N9wXw+Mdq3HU4zseanLyAjXchWJ3L/L3wBpViyzxWp0wBXASlLSuuRiHT0osSg2lI6Y9 zjjeSd0nE8Jg/lUH8y0WMAE15kp2sYqdefniToKyk3WYZ1xLCSoTX/ZIa4V6vLaB6K15 odbf9M0PDuSGhSl3dOtbJA17YJ6jH7Vn4u1ErXz/UXd6ASre52sJY4D9J4W/0+iV2+bO z8dQ==
X-Gm-Message-State: AElRT7FX8c9H63Ef/WZQ80oiqshs5RRJX3IHvytDtVPu0EqaqQ8TU88a 2U6KOSmI/LYaaoc0aru2AA1P4Y+xpXz04zdC/v4=
X-Google-Smtp-Source: AG47ELtRsEEN1s02yqwoLezN2LCCXR5AKuB+7G90QwB1wvpMLENWQ8P3nWKuv6Tf2xGZkCZUdx4pmXIra+SA/GySXkA=
X-Received: by 10.157.64.189 with SMTP id n58mr4348283ote.215.1520015368430; Fri, 02 Mar 2018 10:29:28 -0800 (PST)
MIME-Version: 1.0
Received: by 10.157.46.119 with HTTP; Fri, 2 Mar 2018 10:28:48 -0800 (PST)
In-Reply-To: <CAJU8_nWatM=_reHiUMcshA0twHMSKrmgSkaorgtaOkbUb-1uuQ@mail.gmail.com>
References: <CAJU8_nWatM=_reHiUMcshA0twHMSKrmgSkaorgtaOkbUb-1uuQ@mail.gmail.com>
From: Kathleen Moriarty <kathleen.moriarty.ietf@gmail.com>
Date: Fri, 2 Mar 2018 13:28:48 -0500
Message-ID: <CAHbuEH4M2QqtSYMZFeqMs_-TfCE8ZvvsuxmBA9j0kBcnN2hBMw@mail.gmail.com>
To: Kyle Rose <krose@krose.org>
Cc: IETF SecDir <secdir@ietf.org>, The IESG <iesg@ietf.org>, draft-ietf-ace-cbor-web-token.all@ietf.org
Content-Type: text/plain; charset="UTF-8"
Archived-At: <https://mailarchive.ietf.org/arch/msg/secdir/pq_9HnEvP11Z80xw9VGkfFK3pS8>
Subject: Re: [secdir] Secdir last call review of draft-ietf-ace-cbor-web-token-12
X-BeenThere: secdir@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: Security Area Directorate <secdir.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/secdir>, <mailto:secdir-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/secdir/>
List-Post: <mailto:secdir@ietf.org>
List-Help: <mailto:secdir-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/secdir>, <mailto:secdir-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 02 Mar 2018 18:29:35 -0000

Thanks for your review, Kyle!

On Fri, Mar 2, 2018 at 1:16 PM, Kyle Rose <krose@krose.org>; wrote:
> Reviewer: Kyle Rose
> Review result: Ready with nits
>
> I have reviewed this document as part of the security directorate's ongoing
> effort to review all IETF documents being processed by the IESG.  These
> comments were written primarily for the benefit of the security area
> directors.  Document editors and WG chairs should treat these comments just
> like any other last call comments.
>
> This draft specifies a means for representing claims in CBOR, and for using
> COSE to encrypt and authenticate such claims. The listed security
> considerations seem to cover the same ground as the respective slices of the
> corresponding JWT references: the COSE RFC 8152 covers issues of trust
> establishment, as well as the vagaries of signature algorithms and key
> reuse, in more depth.
>
> My only nit for this document is the repeated use of the phrasing "...has
> the same meaning, syntax, and processing rules as..." throughout section
> 3.1: specifically, the inclusion of "syntax". For example, it doesn't seem
> to make sense to talk about the syntax of a CBOR NumericDate being the same
> as, or different from, the syntax of a JSON NumericDate: clearly, the binary
> representation is different, and it's not at all clear that it makes sense
> to talk about the human-readable source representation in this context. That
> said, there is some parallelism with respect to StringOrURI, as presumably
> the intent is to require that all strings containing a colon also be valid
> URIs.
>

Good point.  Authors, please put these adjustments in your working
copy of the draft and ack the changes made here.

Thank you,
Kathleen



-- 

Best regards,
Kathleen