Re: [secdir] Review of draft-ietf-avtext-splicing-notificaiton-04

"Huangyihong (Rachel)" <rachel.huang@huawei.com> Wed, 02 March 2016 02:23 UTC

Return-Path: <rachel.huang@huawei.com>
X-Original-To: secdir@ietfa.amsl.com
Delivered-To: secdir@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 490251B44E7; Tue, 1 Mar 2016 18:23:53 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -4.207
X-Spam-Level:
X-Spam-Status: No, score=-4.207 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RP_MATCHES_RCVD=-0.006, SPF_PASS=-0.001] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id oFtEa3LVi2wX; Tue, 1 Mar 2016 18:23:51 -0800 (PST)
Received: from lhrrgout.huawei.com (lhrrgout.huawei.com [194.213.3.17]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 33D661B44E2; Tue, 1 Mar 2016 18:23:50 -0800 (PST)
Received: from 172.18.7.190 (EHLO lhreml705-cah.china.huawei.com) ([172.18.7.190]) by lhrrg02-dlp.huawei.com (MOS 4.3.7-GA FastPath queued) with ESMTP id CFE99388; Wed, 02 Mar 2016 02:23:47 +0000 (GMT)
Received: from nkgeml409-hub.china.huawei.com (10.98.56.40) by lhreml705-cah.china.huawei.com (10.201.5.168) with Microsoft SMTP Server (TLS) id 14.3.235.1; Wed, 2 Mar 2016 02:23:46 +0000
Received: from NKGEML513-MBS.china.huawei.com ([169.254.2.35]) by nkgeml409-hub.china.huawei.com ([10.98.56.40]) with mapi id 14.03.0235.001; Wed, 2 Mar 2016 10:23:41 +0800
From: "Huangyihong (Rachel)" <rachel.huang@huawei.com>
To: "Matt Miller (mamille2)" <mamille2@cisco.com>, "draft-ietf-avtext-splicing-notification.all@ietf.org" <draft-ietf-avtext-splicing-notification.all@ietf.org>, The IESG <iesg@ietf.org>, "gen-art@ietf.org" <gen-art@ietf.org>, "secdir@ietf.org" <secdir@ietf.org>
Thread-Topic: Review of draft-ietf-avtext-splicing-notificaiton-04
Thread-Index: AQHRdAAjr6g+Q/FgyEGL9pH6QLQVn59FYJKg
Date: Wed, 02 Mar 2016 02:23:40 +0000
Message-ID: <51E6A56BD6A85142B9D172C87FC3ABBB86E8C0B1@nkgeml513-mbs.china.huawei.com>
References: <BE1B519D-1BD0-4AC4-B8B7-8B4C59B642EF@cisco.com>
In-Reply-To: <BE1B519D-1BD0-4AC4-B8B7-8B4C59B642EF@cisco.com>
Accept-Language: zh-CN, en-US
Content-Language: zh-CN
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [10.136.79.191]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-CFilter-Loop: Reflected
X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A090203.56D64EB4.0083, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0, ip=169.254.2.35, so=2013-06-18 04:22:30, dmn=2013-03-21 17:37:32
X-Mirapoint-Loop-Id: e5d5a7c46660ff78856ea663d1375354
Archived-At: <http://mailarchive.ietf.org/arch/msg/secdir/qDmy_jhQHvhHgfesJa5VAnE90_U>
Subject: Re: [secdir] Review of draft-ietf-avtext-splicing-notificaiton-04
X-BeenThere: secdir@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: Security Area Directorate <secdir.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/secdir>, <mailto:secdir-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/secdir/>
List-Post: <mailto:secdir@ietf.org>
List-Help: <mailto:secdir-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/secdir>, <mailto:secdir-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 02 Mar 2016 02:23:53 -0000

Hi Matt,

Please see my replies inline.

BR,
Rachel


> -----Original Message-----
> From: Matt Miller (mamille2) [mailto:mamille2@cisco.com]
> Sent: Wednesday, March 02, 2016 5:20 AM
> To: draft-ietf-avtext-splicing-notification.all@ietf.org; The IESG;
> gen-art@ietf.org; secdir@ietf.org
> Subject: Review of draft-ietf-avtext-splicing-notificaiton-04
> 
> I am the coincidentally-assigned Gen-ART and SecDir reviewer for this draft.
> The General Area Review Team (Gen-ART) reviews all IETF documents being
> processed by the IESG for the IETF Chair.  The Security Directorate reviews all
> IETF documents being processed by the IESG for the security area directors.
> Please treat these comments just like any other last call comments that arrived
> on time.
> 
> For more information on Gen-Art, please see the FAQ at
> 
> < http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq >.
> 
> Document: draft-ietf-avtext-splicing-notification-04
> Reviewer: Matthew Miller
> Review Date: 2016-02-26
> IETF LC End Date: 2016-02-26
> IESG Telechat date: N/A
> 
> Summary:
> 
> Ready with a minor issue.
> 
> Major issues:
> 
> Minor issues:
> 
> * I didn't see any discussion of the case where the RTP extension and the RTCP
> message don't agree on the interval.  Well-behaved software shouldn't do this,
> but it seems like something that could happen.  I'm not sure what should be
> done in this case, but it seems to me like something to at least acknowledge it.

[Rachel]: Good question. Since RTCP message and RTP extension packets are all from the same main RTP sender, it's the sender's duty to keep them contain the same interval information. So I don't see any chance that inconsistent intervals appear. But, I do think it's worth to mention it in the draft. How about adding a sentence in first paragraph, Section 3.2, like this
"The main RTP sender MUST make sure the splicing information contained in the RTCP splicing notification message consistent with the information included in the RTP header extensions. "
So what do you think?

> 
> Nits/editorial comments:
> 
> * idnits is reporting a bad reference to "3711" Section 7 "Security
> Considerations", and that RFC 3711 is an unused normative reference.  I think
> this is because the pointer to it in Section 7 doesn't start with "RFC".

[Rachel]: Right. Will fix it.
> 
> * In Section 1. "Introduction", it seems to me "However" would be a better
> word than "Nevertheless" to use here.

[Rachel]: All right.

> 
> 
> --
> - m&m
> 
> Matt Miller
> Cisco Systems, Inc.