Re: [secdir] Secdir last call review of draft-ietf-calext-eventpub-extensions-12

Michael Douglass <mdouglass@sphericalcowgroup.com> Tue, 23 April 2019 14:56 UTC

Return-Path: <mdouglass@sphericalcowgroup.com>
X-Original-To: secdir@ietfa.amsl.com
Delivered-To: secdir@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 9FA28120033 for <secdir@ietfa.amsl.com>; Tue, 23 Apr 2019 07:56:41 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.899
X-Spam-Level:
X-Spam-Status: No, score=-1.899 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=sphericalcowgroup-com.20150623.gappssmtp.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id HNWEOLCu_uSZ for <secdir@ietfa.amsl.com>; Tue, 23 Apr 2019 07:56:39 -0700 (PDT)
Received: from mail-qk1-x72d.google.com (mail-qk1-x72d.google.com [IPv6:2607:f8b0:4864:20::72d]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id ABB651200F9 for <secdir@ietf.org>; Tue, 23 Apr 2019 07:56:39 -0700 (PDT)
Received: by mail-qk1-x72d.google.com with SMTP id g1so8753901qki.5 for <secdir@ietf.org>; Tue, 23 Apr 2019 07:56:39 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sphericalcowgroup-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=5NFBL185QZVEpCuj6eVajLRQYiAXyxm9CgKlZoUY3cA=; b=ywlbYjDeQ9wLpRNTJV2Xd1aCKsDAHnJcN51/C/rDvUWRkQhQcDUUeUXZJiMKEL2Mh3 1hqKmM/6hO9fbNB9xN9eJxwD9R3ZzGPrkNdgbVVb6U+U/V60wz/pq7Je0cZVD1vxaXt/ SsYhVPbUZrT18GNpnLm2VYUhMyWQ93mKzFA0eXSxyDy4RLvgus6QF3v+Cogx1JERGYsT 49KuVCzItiTsrceOYGEZ+i0zkP5k8ENjoctS4sY8owB9pSqNAVw/rrc/NdkvkGSwRcCm 3ccSjLBCIkX6tM9svD4aXi0LE/1PiE8EgnvLDfwzyth2Rz0d95PvRAQL8KWRcD5QoAbH InyA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=5NFBL185QZVEpCuj6eVajLRQYiAXyxm9CgKlZoUY3cA=; b=EBiXoC/pT+9s12ggmpbcSJy41KFKV4IwFZqcnUWgUBPspogKgR1FhEr2hInS3ym2bX grC+bAdDU+o4VbOp9gjAMmhu6KK8kP739Zyt78XUfOyTNo4E7oNFNWuBuBK9DZLOkyu9 /pwfk1xxdVNc6vnwzEOUGfmtzknIls5Fy49oOPBu7ZLkyB7rjAQTsQA1IXn4XB5o8yPA TAVpfE/FoOeJgiV29LCxS3syGuha7WzE2uIbix4qxbunbU3fjDe8GbgeRNGTxyEzAUQL PlldnTgymLR2MT8xLAxNRg52PavhHk5Ln+cthrPPx9FMhAvWZ3hlQwvbcUAVsKY5qb/x dZ4Q==
X-Gm-Message-State: APjAAAU518nQCbpsq0Ckj9ejk/mivxiOhjWDzs1XBCKgxgWLisv5xIhP ZNiPHLJJjm//7ZdccxKYtkMtfw==
X-Google-Smtp-Source: APXvYqzRrnAnDR6fOB4niF0a0urhF3iYZd8WRSCzdTpfYfK5WSNIe4xtxhYggJIbpwXDne8l8TbaJg==
X-Received: by 2002:ae9:f00e:: with SMTP id l14mr20043781qkg.127.1556031398522; Tue, 23 Apr 2019 07:56:38 -0700 (PDT)
Received: from a-192-168-131-11.dynapool.vpn.nyu.edu (vpnrasa-wwh-pat-01.natpool.nyu.edu. [216.165.95.84]) by smtp.gmail.com with ESMTPSA id x8sm9343729qtj.45.2019.04.23.07.56.36 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 23 Apr 2019 07:56:37 -0700 (PDT)
To: Daniel Migault <daniel.migault@ericsson.com>, Rich Salz <rsalz@akamai.com>, "secdir@ietf.org" <secdir@ietf.org>
Cc: "draft-ietf-calext-eventpub-extensions.all@ietf.org" <draft-ietf-calext-eventpub-extensions.all@ietf.org>, "ietf@ietf.org" <ietf@ietf.org>, "calsify@ietf.org" <calsify@ietf.org>
References: <155595686177.21216.4076761255030943970@ietfa.amsl.com> <MN2PR15MB33108E41A1A75A033987C79DE3230@MN2PR15MB3310.namprd15.prod.outlook.com>
From: Michael Douglass <mdouglass@sphericalcowgroup.com>
Message-ID: <af513417-3ca9-50a8-e92a-f407b5bb83c7@sphericalcowgroup.com>
Date: Tue, 23 Apr 2019 10:56:35 -0400
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:60.0) Gecko/20100101 Thunderbird/60.6.1
MIME-Version: 1.0
In-Reply-To: <MN2PR15MB33108E41A1A75A033987C79DE3230@MN2PR15MB3310.namprd15.prod.outlook.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Archived-At: <https://mailarchive.ietf.org/arch/msg/secdir/qPh5H7EEyXagcSojT8FV6bBvlSM>
Subject: Re: [secdir] Secdir last call review of draft-ietf-calext-eventpub-extensions-12
X-BeenThere: secdir@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Security Area Directorate <secdir.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/secdir>, <mailto:secdir-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/secdir/>
List-Post: <mailto:secdir@ietf.org>
List-Help: <mailto:secdir-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/secdir>, <mailto:secdir-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 23 Apr 2019 14:56:42 -0000

Thanks for the comments:

All useful - and yes - I'll add the confirmation code.

I'll incorporate these changes

On 4/23/19 09:02, Daniel Migault wrote:
> Thanks for the review Rich!
> Yours,
> Daniel
>
> -----Original Message-----
> From: Rich Salz via Datatracker <noreply@ietf.org>;
> Sent: Monday, April 22, 2019 2:14 PM
> To: secdir@ietf.org
> Cc: draft-ietf-calext-eventpub-extensions.all@ietf.org; ietf@ietf.org; calsify@ietf.org
> Subject: Secdir last call review of draft-ietf-calext-eventpub-extensions-12
>
> Reviewer: Rich Salz
> Review result: Has Nits
>
> This is the SECDIR last-call review, intended to be input to the Security AD's.
>
> Ready with nits.
>
> The Security Considerations and Privacy Considerations are short, but they seem to reasonably refer to already-published documents.
>
> Following are nits I noticed.
>
> Abstract "a number of new iCalendar properties and components" -> "a new iCalendar component and a number of properties"  Maybe stike "iCalendar"
>
> Sec 1, STRUCTURED-DATA. In my opinion the confirmation code would be the most useful new info :)
>
> Sec 1, SOURCE Is it redefined or extended?
>
> Sec 2, para 2.  "In a break with this 'tradition' ..." --> "Breaking with this practice, ..."
>
> Sec 3, "When a calendar client receives a calendar component" Should the second calendar be CALENDAR? Should the first be "iCalendar"?
>
> Sec 3.1.1, uppercase "vcard"?
>
> Sec 3.1.2.1 "non of which" --> "none of which"
>
> Sec 4 Perhaps add a sentence saying where this syntax is defined. Is this the complete iCalendar spec or is it just changing a few things?
>
> Sec 5.1, etc "as laid down in" Is kind of informal wording.
>
> Sec 6, the notation has "value=URI" but the example has "URL" (Sec 7.3, etc., uses URI in both parts)
>
> Sec 10, "applications using" Is "acting on" better?
>
>