[secdir] Secdir last call review of draft-ietf-pim-source-discovery-bsr-07

Liang Xia <frank.xialiang@huawei.com> Mon, 08 January 2018 06:22 UTC

Return-Path: <frank.xialiang@huawei.com>
X-Original-To: secdir@ietf.org
Delivered-To: secdir@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id CEEDC1270AB; Sun, 7 Jan 2018 22:22:17 -0800 (PST)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
From: Liang Xia <frank.xialiang@huawei.com>
To: secdir@ietf.org
Cc: draft-ietf-pim-source-discovery-bsr.all@ietf.org, ietf@ietf.org, pim@ietf.org, iesg@ietf.org
X-Test-IDTracker: no
X-IETF-IDTracker: 6.68.2
Auto-Submitted: auto-generated
Precedence: bulk
Message-ID: <151539253778.11305.7448095057192632663@ietfa.amsl.com>
Date: Sun, 07 Jan 2018 22:22:17 -0800
Archived-At: <https://mailarchive.ietf.org/arch/msg/secdir/reOxA1eVfJ6yrNZMi96NfHumGPE>
Subject: [secdir] Secdir last call review of draft-ietf-pim-source-discovery-bsr-07
X-BeenThere: secdir@ietf.org
X-Mailman-Version: 2.1.22
List-Id: Security Area Directorate <secdir.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/secdir>, <mailto:secdir-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/secdir/>
List-Post: <mailto:secdir@ietf.org>
List-Help: <mailto:secdir-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/secdir>, <mailto:secdir-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 08 Jan 2018 06:22:18 -0000

Reviewer: Liang Xia
Review result: Has Issues

Nits:
1. In Abstract, the abbreviation is missed when the Term are firstly appeared,
such as: Sparse-Mode, Rendezvous Point; 2. Every word in the section titles
should be in the capital form

Issues:
1. In Security Considerations section,  should one sentence be "even if the
sources are actually not active"? 2. Generally, the peer authentication (by
certificate, shared key...) and the message integration protection are always
helpful to defend against the forged routers and PEM messages, even the
resulted resource consumption. But in current Security Considerations section,
there is nothing discussed about these countermeasures, even in the general
way. Suggest to consider this point personally.