Re: [secdir] secdir review of draft-ietf-ice-trickle-16

David Mandelberg <david+work@mandelberg.org> Thu, 22 February 2018 03:05 UTC

Return-Path: <david+work@mandelberg.org>
X-Original-To: secdir@ietfa.amsl.com
Delivered-To: secdir@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 3F50912E8B1 for <secdir@ietfa.amsl.com>; Wed, 21 Feb 2018 19:05:30 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.9
X-Spam-Level:
X-Spam-Status: No, score=-1.9 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, URIBL_BLOCKED=0.001] autolearn=unavailable autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id axIOMsnfXo8M for <secdir@ietfa.amsl.com>; Wed, 21 Feb 2018 19:05:29 -0800 (PST)
Received: from smtp.rcn.com (smtp.rcn.com [69.168.97.78]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 664FC12E8AE for <secdir@ietf.org>; Wed, 21 Feb 2018 19:05:28 -0800 (PST)
X_CMAE_Category: , ,
X-CNFS-Analysis: v=2.2 cv=IeLFYiia c=1 sm=1 tr=0 a=OXtaa+9CFT7WVSERtyqzJw==:117 a=OXtaa+9CFT7WVSERtyqzJw==:17 a=KGjhK52YXX0A:10 a=IkcTkHD0fZMA:10 a=NTnny0joGdQA:10 a=Op4juWPpsa0A:10 a=bmmO2AaSJ7QA:10 a=BTUBnpS-AAAA:8 a=N4ERlS6yprhKTvH9DewA:9 a=QEXdDO2ut3YA:10 a=pblkFgjdBCuYZ9-HdJ6i:22
X-CM-Score: 0
X-Scanned-by: Cloudmark Authority Engine
X-Authed-Username: ZHNlb21uQHJjbi5jb20=
Authentication-Results: smtp02.rcn.cmh.synacor.com smtp.mail=david+work@mandelberg.org; spf=neutral; sender-id=neutral
Authentication-Results: smtp02.rcn.cmh.synacor.com header.from=david+work@mandelberg.org; sender-id=neutral
Authentication-Results: smtp02.rcn.cmh.synacor.com smtp.user=dseomn@rcn.com; auth=pass (LOGIN)
Received-SPF: neutral (smtp02.rcn.cmh.synacor.com: 209.6.43.168 is neither permitted nor denied by domain of mandelberg.org)
Received: from [209.6.43.168] ([209.6.43.168:33484] helo=uriel.mandelberg.org) by smtp.rcn.com (envelope-from <david+work@mandelberg.org>) (ecelerity 3.6.25.56547 r(Core:3.6.25.0)) with ESMTPSA (cipher=DHE-RSA-AES256-GCM-SHA384) id 36/5F-63577-6733E8A5; Wed, 21 Feb 2018 22:05:26 -0500
Received: from [192.168.1.152] (DD-WRT [192.168.1.1]) by uriel.mandelberg.org (Postfix) with ESMTPSA id 61F801C609C; Wed, 21 Feb 2018 21:58:46 -0500 (EST)
To: Peter Saint-Andre <stpeter@mozilla.com>, iesg@ietf.org, secdir@ietf.org, draft-ietf-ice-trickle.all@ietf.org
References: <02c7b2a3-6e15-7a1c-7781-19cd3c8656ab@mandelberg.org> <28d45621-7f57-5f76-d85e-ab220fe4061d@mozilla.com>
From: David Mandelberg <david+work@mandelberg.org>
Organization: David Mandelberg, LLC
Message-ID: <fc57f203-ec30-d5b4-e79f-37caab46c2d9@mandelberg.org>
Date: Wed, 21 Feb 2018 21:58:43 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0
MIME-Version: 1.0
In-Reply-To: <28d45621-7f57-5f76-d85e-ab220fe4061d@mozilla.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Archived-At: <https://mailarchive.ietf.org/arch/msg/secdir/sfANaBPzOxnbDPKOFLV4nkNRTgo>
X-Mailman-Approved-At: Mon, 26 Feb 2018 06:32:11 -0800
Subject: Re: [secdir] secdir review of draft-ietf-ice-trickle-16
X-BeenThere: secdir@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: Security Area Directorate <secdir.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/secdir>, <mailto:secdir-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/secdir/>
List-Post: <mailto:secdir@ietf.org>
List-Help: <mailto:secdir-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/secdir>, <mailto:secdir-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 22 Feb 2018 03:05:30 -0000

On 02/21/2018 06:56 PM, Peter Saint-Andre wrote:
> Good catch - in-order delivery applies here as well.
> 
> OLD
>     o  A signaling protocol MUST deliver each trickled candidate not more
>        than once and in the same order it was conveyed (see Section 8).
> 
> NEW
>     o  A signaling protocol MUST deliver each trickled candidate or
>        end-of-candidates indication not more than once and in the same
>        order it was conveyed (see Section 8).
> 
> We might want to also modify the text in Section 8, as follows:
> 
> OLD
>     When candidates are trickled, the signaling protocol MUST deliver
>     each candidate to the receiving Trickle ICE implementation not more
>     than once and in the same order it was conveyed.  If the signaling
>     protocol provides any candidate retransmissions, they need to be
>     hidden from the ICE implementation.
> 
> NEW
>     When candidates are trickled, the signaling protocol MUST deliver
>     each candidate (and any end-of-candidates indication as described in
>     Section 8.2) to the receiving Trickle ICE implementation not more
>     than once and in the same order it was conveyed.  If the signaling
>     protocol provides any candidate retransmissions, they need to be
>     hidden from the ICE implementation.

Looks good to me.

-- 
Freelance cyber security consultant, software developer, and more
https://david.mandelberg.org/