[secdir] Re: SECDIR review of draft-ietf-radext-reverse-coa

Alan DeKok <aland@deployingradius.com> Sun, 17 August 2025 21:38 UTC

Return-Path: <aland@deployingradius.com>
X-Original-To: secdir@mail2.ietf.org
Delivered-To: secdir@mail2.ietf.org
Received: from localhost (localhost [127.0.0.1]) by mail2.ietf.org (Postfix) with ESMTP id 07B9E552BAD9; Sun, 17 Aug 2025 14:38:02 -0700 (PDT)
X-Virus-Scanned: amavisd-new at ietf.org
X-Spam-Flag: NO
X-Spam-Score: -1.898
X-Spam-Level:
X-Spam-Status: No, score=-1.898 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Received: from mail2.ietf.org ([166.84.6.31]) by localhost (mail2.ietf.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 1Ob_0BjefzyJ; Sun, 17 Aug 2025 14:38:01 -0700 (PDT)
Received: from mail2.networkradius.com (mail2.networkradius.com [184.95.211.25]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-256) server-digest SHA256) (No client certificate requested) by mail2.ietf.org (Postfix) with ESMTPS id 74D38552BAD4; Sun, 17 Aug 2025 14:38:01 -0700 (PDT)
Received: from mail.servers.fr.internal.networkradius.com ([192.168.42.56]:53240 helo=mail.networkradius.com) by mail2.networkradius.com with esmtp (Exim 4.93) (envelope-from <aland@deployingradius.com>) id 1unl4i-001L7v-45; Sun, 17 Aug 2025 21:38:00 +0000
Received: from smtpclient.apple (24-246-4-149.cable.teksavvy.com [24.246.4.149]) by mail.networkradius.com (Postfix) with ESMTPSA id 082A827B; Sun, 17 Aug 2025 21:37:58 +0000 (UTC)
Content-Type: text/plain; charset="utf-8"
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.700.81\))
From: Alan DeKok <aland@deployingradius.com>
In-Reply-To: <CAF4+nEHKZuaX9oCjbXusep4uUd=weaJXTFpfXcog-A4h04ETXA@mail.gmail.com>
Date: Sun, 17 Aug 2025 17:37:44 -0400
Content-Transfer-Encoding: quoted-printable
Message-Id: <2FC6578F-B536-451E-950B-787B359F82CD@deployingradius.com>
References: <CAF4+nEHKZuaX9oCjbXusep4uUd=weaJXTFpfXcog-A4h04ETXA@mail.gmail.com>
To: Donald Eastlake <d3e3e3@gmail.com>
X-Mailer: Apple Mail (2.3826.700.81)
Message-ID-Hash: MEUJATWNVOH6OM77DQN3QYT5PZHBBP5R
X-Message-ID-Hash: MEUJATWNVOH6OM77DQN3QYT5PZHBBP5R
X-MailFrom: aland@deployingradius.com
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-secdir.ietf.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header
CC: "iesg@ietf.org" <iesg@ietf.org>, secdir <secdir@ietf.org>, draft-ietf-radext-reverse-coa.all@ietf.org
X-Mailman-Version: 3.3.9rc6
Precedence: list
Subject: [secdir] Re: SECDIR review of draft-ietf-radext-reverse-coa
List-Id: Security Area Directorate <secdir.ietf.org>
Archived-At: <https://mailarchive.ietf.org/arch/msg/secdir/v-nEaIDt3OHbbW418qOTmJgJDaE>
List-Archive: <https://mailarchive.ietf.org/arch/browse/secdir>
List-Help: <mailto:secdir-request@ietf.org?subject=help>
List-Owner: <mailto:secdir-owner@ietf.org>
List-Post: <mailto:secdir@ietf.org>
List-Subscribe: <mailto:secdir-join@ietf.org>
List-Unsubscribe: <mailto:secdir-leave@ietf.org>

On Aug 6, 2025, at 6:13 PM, Donald Eastlake <d3e3e3@gmail.com> wrote:
> Security
> --------
> 
> The Security Considerations Section 8 just says (in different words)
> that the document improves security by standardizing reverse paths for
> CoA-Request and Disconnect-Request packets. I would add a little bit
> about why, if there is a need to disconnect or change authentication,
> it can be a security problem if you cannot do that.

  Done.

> Also, Section 4
> just says that in various cases of misconfiguration CoA (which is
> defined to also include Disconnect in this document) packets will not
> flow and says this causes no further issues. I suggest "there will be
> no other issues with this misconfiguration" -> "which may reduce
> security (see Section 8)".

   Done.

> Nits / trivial issues
> ---------------------
> 
> Section 1, 2nd and 3rd paragraphs: Perhaps these should be merged or
> something as on initial reading it was not clear to me that the
> "Section 3.4" in the 3rd paragraph was that section in RFC 6614 which
> is referenced in the 2nd paragraph.

  I've reworded the introduction to make it clearer.

> Section 1, 3rd paragraph: Should "which types of packets are supported
> on a server" be "which types of packets it supports"?

  That's a quote from another specification, so I'll leave it alone, and make it clearer that it's a quote.

> Section 3: "a configuration and signalling," -> "a configuration and
> signalling method,"

  Done.

> Section 3 says there are two additions. These are then discussed in
> Section 4 and 5 but there is no tie between those sections and Section
> 3. Suggest adding at the end of Section 3: "These additions are
> discussed in Sections 4 and 5 respectively."

  Done.

> Section 5.1, 2nd paragraph: "have the choice more than one" -> "have a
> choice of more than one"

  Fixed.

> Section 5.2, 2nd paragraph: the server's connection choice is not
> unconstrained. "chooses one connection" -> "chooses one of these
> connections"

  Fixed.

> Section 6.3, I didn't review Section 6 very closely but it seems odd
> that in Section 6.3 there is a raw direct reference rather than
> indirecting through the Informational References section. But, since
> Section 6 is going away, it does not matter much.

  OK.