Re: [secdir] draft-ietf-appsawg-json-pointer-07 SECDIR Review

Donald Eastlake <d3e3e3@gmail.com> Wed, 02 January 2013 05:18 UTC

Return-Path: <d3e3e3@gmail.com>
X-Original-To: secdir@ietfa.amsl.com
Delivered-To: secdir@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id A6FE021E8049; Tue, 1 Jan 2013 21:18:41 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -103.381
X-Spam-Level:
X-Spam-Status: No, score=-103.381 tagged_above=-999 required=5 tests=[AWL=0.218, BAYES_00=-2.599, RCVD_IN_DNSWL_LOW=-1, USER_IN_WHITELIST=-100]
Received: from mail.ietf.org ([64.170.98.30]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id xeMD9OQ+9MRb; Tue, 1 Jan 2013 21:18:40 -0800 (PST)
Received: from mail-ob0-f172.google.com (mail-ob0-f172.google.com [209.85.214.172]) by ietfa.amsl.com (Postfix) with ESMTP id 6F79921E8042; Tue, 1 Jan 2013 21:18:39 -0800 (PST)
Received: by mail-ob0-f172.google.com with SMTP id za17so12543059obc.17 for <multiple recipients>; Tue, 01 Jan 2013 21:18:39 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=iW7C9D08kI8u+BF5dQJkhF226hMG9ilm1JJHrOjvpKg=; b=BkXUBdLcSMHxwIJj+llhEukVgdAiNJzEdCdc41gLqM3NTngewzZFuccs/Hff3BbwmL 7Jl1nHQbKVSv4t6kmp3x47Eyaygj2AQtpCg40k7WWQkmlWplLGcw7Yj9gGhRL114AHdB vxK2xj82LpZM5iz+lbqSctJGNWUDs8QNdEVuuxEHPia2VpwyqO0qAp0291fwT+8B/Xz2 V5Xum85Hkf2K+iUK4ERXBxgPZ4NvMzqIuG/cwFM9G81RmF3e8hc/RKb44J6uAV0/SuOw yPcvV9zq4bg3sHiFPkcKb5c66c9SdGzASr45ypsCX52QwWCx992987Q8TpP4RVEh1hhP 9yNw==
Received: by 10.182.185.12 with SMTP id ey12mr37503480obc.7.1357103919354; Tue, 01 Jan 2013 21:18:39 -0800 (PST)
MIME-Version: 1.0
Received: by 10.76.144.105 with HTTP; Tue, 1 Jan 2013 21:18:19 -0800 (PST)
In-Reply-To: <F8C63186-C869-46DC-8C05-EBCD5BEE8D13@mnot.net>
References: <CAF4+nEEDfhv=J_BnXJjj7q2_9tf16RCUpTHspQcky1+F_0JTzA@mail.gmail.com> <F8C63186-C869-46DC-8C05-EBCD5BEE8D13@mnot.net>
From: Donald Eastlake <d3e3e3@gmail.com>
Date: Wed, 2 Jan 2013 00:18:19 -0500
Message-ID: <CAF4+nEGChp0KtUDf-RtGweTZhzKk1OEU-+4a+JJ4mMvuWN061w@mail.gmail.com>
To: Mark Nottingham <mnot@mnot.net>
Content-Type: text/plain; charset=ISO-8859-1
Cc: draft-ietf-appsawg-json-pointer.all@tools.ietf.org, iesg@ietf.org, secdir@ietf.org
Subject: Re: [secdir] draft-ietf-appsawg-json-pointer-07 SECDIR Review
X-BeenThere: secdir@ietf.org
X-Mailman-Version: 2.1.12
Precedence: list
List-Id: Security Area Directorate <secdir.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/secdir>, <mailto:secdir-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/secdir>
List-Post: <mailto:secdir@ietf.org>
List-Help: <mailto:secdir-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/secdir>, <mailto:secdir-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 02 Jan 2013 05:18:41 -0000

Hi Mark,

On Tue, Jan 1, 2013 at 11:12 PM, Mark Nottingham <mnot@mnot.net> wrote:
> Thanks for the review; replies below.
>
> On 31/12/2012, at 2:11 PM, Donald Eastlake <d3e3e3@gmail.com> wrote:
>
>> I have reviewed this document as part of the security directorate's
>> ongoing effort to review all IETF documents being processed by the
>> IESG.  Document editors and WG chairs should treat these comments just
>> like any other last call comments.
>>
>> This draft describes two closely related syntaxes for pointers to
>> objects within a JSON (JavaScript Object Notation) document. One is a
>> JSON string syntax, the other is a URI fragment identifier for URIs
>> defined to take such a fragment identifier.
>>
>> Security:
>>
>> I do not see any security problems with this document. The syntax
>> appears to be unambiguously specified, including ABNF, and the
>> Security Considerations Section is adequate and touches on the
>> potential pit-falls that JSON pointers can contain NULs.
>>
>> Miscellaneous:
>>
>> I found significant ambiguity in the semantics of a JSON pointer
>> string. Is the result of the successful evaluation ("evaluation" is a
>> term used in the draft) of such a pointer string a structure that
>> points into a JSON document or is it the objection pointed to? It
>> mostly seems to be an object but it is specifically provided that
>> array references could point beyond the end of an array and at least
>> in that case perhaps some sort of pointer structure would be returned
>> with the error condition. It probably doesn't matter, because these
>> syntaxes are intended to be used in a variety of applications and it
>> will be up to the application to clarify the semantics.
>
> I think it's purposefully ambiguous, to accommodate a variety of applications.

OK.

>> Minor:
>>
>> The expansion for the acronym JSON should be given in the title and abstract.
>
> In SVN.

What does that mean? If you mean to say that you agree with the change
suggested and that it will be in the next version posted, you should
say that.

>> In the first line of the second paragraph of Section 6, I found the
>> word "nominate" kind of odd. Why not "specify" or "select" or "use"?
>
> In SVN.

Same response as above.

>> None of the Authors Addresses given includes a postal address.
>
> Yes.

I think they should. I find that such corner cutting typically goes
with other sloppiness.

Thanks,
Donald
=============================
 Donald E. Eastlake 3rd   +1-508-333-2270 (cell)
 155 Beaver Street, Milford, MA 01757 USA
 d3e3e3@gmail.com

> --
> Mark Nottingham   http://www.mnot.net/