Re: [secdir] SecDir review of draft-ietf-p2psip-service-discovery-14

[Alexey Melnikov <[e-mail]>]

On 07/08/2014 13:33, Jouni Mäenpää wrote:
> Hi,
Hi,
> Thanks for the comments! Please find my answers inline below.
>
> Regards,
> Jouni
>
>> -----Original Message-----
>> From: Alexey Melnikov [mailto:[e-mail]]
>> Sent: 7. elokuuta 2014 13:34
>> To: [e-mail]; [e-mail];
>> [e-mail]
>> Subject: SecDir review of draft-ietf-p2psip-service-discovery-14
  [snip]
>> While I was able to follow the document, I think it lacks attention to details
>> which are not obvious for somebody not following the technology.
>> Minor issues that should be easy to fix:
>>
>>    On page 4: H(x) - missing reference to SHA-1. Any specific properties required
>> from H(x)?
> I will add a reference to SHA-1. The requirements are the same as in the RELOAD base specification (RFC 6940).
>>    Namespace - missing reference to UTF-8.
> Ok, I'll add that reference as well.
>
>>    On page 6: H() with multiple arguments is not defined, especially if they can
>> be both strings and integers (what byte order)? b' is not defined. Typo in the
>> description?
> I will clarify this in the next revision of the draft. H(namespace,level,j) refers to taking a hash over a concatenated string consisting of the namespace (string), level in the ReDiR tree (integer), and the node location j (integer).
>
> Related to byte order, would it be sufficient/correct to say that it is big-endian?
Yes, although I prefer "network byte order" :-).
> And you are right, b'  was not defined in the draft. It refers to the number of the interval within a given tree node at a given level in the ReDiR tree.
Ok. Please add the definition.
>> In 4.2 I read "the mode of those depths". Can you explain what this means? Or
>> is this a typo?
> Mode (statistics) refers to the value that appears most often in a set of data. I will add also this definition to the next revision of the draft.
Right. Yes, that would help.