Re: [secdir] SecDir review of draft-ietf-p2psip-service-discovery-14

Alexey Melnikov <alexey.melnikov@isode.com> Thu, 07 August 2014 13:04 UTC

Return-Path: <alexey.melnikov@isode.com>
X-Original-To: secdir@ietfa.amsl.com
Delivered-To: secdir@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id C26CC1B29B1; Thu, 7 Aug 2014 06:04:14 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.101
X-Spam-Level:
X-Spam-Status: No, score=-1.101 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, J_CHICKENPOX_19=0.6, MIME_8BIT_HEADER=0.3, RP_MATCHES_RCVD=-0.001] autolearn=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id CQws4JPpAlXX; Thu, 7 Aug 2014 06:04:13 -0700 (PDT)
Received: from waldorf.isode.com (ext-bt.isode.com [217.34.220.158]) by ietfa.amsl.com (Postfix) with ESMTP id C3C011B29CB; Thu, 7 Aug 2014 06:04:12 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1407416652; d=isode.com; s=selector; i=@isode.com; bh=O1D2YQK5YUH/UbobUZSJF1AgoxDhGt/yfy52H6QkH5A=; h=From:Sender:Reply-To:Subject:Date:Message-ID:To:Cc:MIME-Version: In-Reply-To:References:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description; b=lztFywP5/lwOEI5OGmRDFRmr/VOacBmB4y1Pw2/4HmlhwZJBLxkiH0VX7rTvI9jJSMA8jB HKojCgo6lK4JrFAUWlqy8g/Jrz0OVWMXf22+Jd6shjhcKontiKTQ5qERv8pAelnLuXW3vl rvdRYYa3IiuzNtrkFj7bfFQCmFccckU=;
Received: from [172.20.1.47] ((unknown) [217.34.220.158]) by waldorf.isode.com (submission channel) via TCP with ESMTPA id <U-N5SwAvQ2j8@waldorf.isode.com>; Thu, 7 Aug 2014 14:04:11 +0100
X-SMTP-Protocol-Errors: NORDNS
Message-ID: <53E37953.8030502@isode.com>
Date: Thu, 07 Aug 2014 14:04:19 +0100
From: Alexey Melnikov <alexey.melnikov@isode.com>
User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:24.0) Gecko/20100101 Thunderbird/24.6.0
To: =?ISO-8859-1?Q?Jouni_M=E4enp=E4=E4?= <jouni.maenpaa@ericsson.com>, "draft-ietf-p2psip-service-discovery.all@tools.ietf.org" <draft-ietf-p2psip-service-discovery.all@tools.ietf.org>, "iesg@ietf.org" <iesg@ietf.org>, "secdir@ietf.org" <secdir@ietf.org>
References: <53E355FB.5000101@isode.com> <27112A697EB8204D9943EAB8A0E16B7110865DB6@ESESSMB305.ericsson.se>
In-Reply-To: <27112A697EB8204D9943EAB8A0E16B7110865DB6@ESESSMB305.ericsson.se>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-transfer-encoding: quoted-printable
Archived-At: http://mailarchive.ietf.org/arch/msg/secdir/wjlYjW0eKceVE4-iQW4GYKc18-Q
Subject: Re: [secdir] SecDir review of draft-ietf-p2psip-service-discovery-14
X-BeenThere: secdir@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: Security Area Directorate <secdir.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/secdir>, <mailto:secdir-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/secdir/>
List-Post: <mailto:secdir@ietf.org>
List-Help: <mailto:secdir-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/secdir>, <mailto:secdir-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 07 Aug 2014 13:04:14 -0000

On 07/08/2014 13:33, Jouni Mäenpää wrote:
> Hi,
Hi,
> Thanks for the comments! Please find my answers inline below.
>
> Regards,
> Jouni
>
>> -----Original Message-----
>> From: Alexey Melnikov [mailto:alexey.melnikov@isode.com]
>> Sent: 7. elokuuta 2014 13:34
>> To: draft-ietf-p2psip-service-discovery.all@tools.ietf.org; iesg@ietf.org;
>> secdir@ietf.org
>> Subject: SecDir review of draft-ietf-p2psip-service-discovery-14
  [snip]
>> While I was able to follow the document, I think it lacks attention to details
>> which are not obvious for somebody not following the technology.
>> Minor issues that should be easy to fix:
>>
>>    On page 4: H(x) - missing reference to SHA-1. Any specific properties required
>> from H(x)?
> I will add a reference to SHA-1. The requirements are the same as in the RELOAD base specification (RFC 6940).
>>    Namespace - missing reference to UTF-8.
> Ok, I'll add that reference as well.
>
>>    On page 6: H() with multiple arguments is not defined, especially if they can
>> be both strings and integers (what byte order)? b' is not defined. Typo in the
>> description?
> I will clarify this in the next revision of the draft. H(namespace,level,j) refers to taking a hash over a concatenated string consisting of the namespace (string), level in the ReDiR tree (integer), and the node location j (integer).
>
> Related to byte order, would it be sufficient/correct to say that it is big-endian?
Yes, although I prefer "network byte order" :-).
> And you are right, b'  was not defined in the draft. It refers to the number of the interval within a given tree node at a given level in the ReDiR tree.
Ok. Please add the definition.
>> In 4.2 I read "the mode of those depths". Can you explain what this means? Or
>> is this a typo?
> Mode (statistics) refers to the value that appears most often in a set of data. I will add also this definition to the next revision of the draft.
Right. Yes, that would help.