[secdir] Secdir last call review of draft-campbell-sip-messaging-smime-03

Liang Xia <frank.xialiang@huawei.com> Mon, 08 October 2018 08:02 UTC

Return-Path: <frank.xialiang@huawei.com>
X-Original-To: secdir@ietf.org
Delivered-To: secdir@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id 2723B12008A; Mon, 8 Oct 2018 01:02:50 -0700 (PDT)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
From: Liang Xia <frank.xialiang@huawei.com>
To: <secdir@ietf.org>
Cc: draft-campbell-sip-messaging-smime.all@ietf.org, ietf@ietf.org
X-Test-IDTracker: no
X-IETF-IDTracker: 6.85.1
Auto-Submitted: auto-generated
Precedence: bulk
Message-ID: <153898577006.31775.15728490877822751593@ietfa.amsl.com>
Date: Mon, 08 Oct 2018 01:02:50 -0700
Archived-At: <https://mailarchive.ietf.org/arch/msg/secdir/wpgbtpnAnCMRstXnjKgOClosuUM>
Subject: [secdir] Secdir last call review of draft-campbell-sip-messaging-smime-03
X-BeenThere: secdir@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Security Area Directorate <secdir.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/secdir>, <mailto:secdir-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/secdir/>
List-Post: <mailto:secdir@ietf.org>
List-Help: <mailto:secdir-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/secdir>, <mailto:secdir-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 08 Oct 2018 08:02:50 -0000

Reviewer: Liang Xia
Review result: Ready

In general, this draft is clear and well written.

I have 2 comments as below:
1. For Section 6, is it required to protect the UA capabilities negotiation
messages? Have you considered the possible downgrade attack, like: the
adversary tampered the UA capabilities negotiation message to make the UA work
without s/mime?

2. For Section 12, is there any general way to defend against the attacks from
malicious or compromised intermediaries mentioned in this section? Maybe some
guidances are helpful here.