Re: [secdir] SECDIR Reveiw of draft-ietf-hip-dex-11
Robert Moskowitz <rgm@labs.htt-consult.com> Tue, 21 January 2020 20:41 UTC
Return-Path: <rgm@labs.htt-consult.com>
X-Original-To: secdir@ietfa.amsl.com
Delivered-To: secdir@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id CF17912003F; Tue, 21 Jan 2020 12:41:37 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.898
X-Spam-Level:
X-Spam-Status: No, score=-1.898 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id KRkDoSPiPDe9; Tue, 21 Jan 2020 12:41:32 -0800 (PST)
Received: from z9m9z.htt-consult.com (z9m9z.htt-consult.com [23.123.122.147]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 10EBE12001B; Tue, 21 Jan 2020 12:41:32 -0800 (PST)
Received: from localhost (localhost [127.0.0.1]) by z9m9z.htt-consult.com (Postfix) with ESMTP id 6323062129; Tue, 21 Jan 2020 15:41:30 -0500 (EST)
X-Virus-Scanned: amavisd-new at htt-consult.com
Received: from z9m9z.htt-consult.com ([127.0.0.1]) by localhost (z9m9z.htt-consult.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id Td61wU1bX6aF; Tue, 21 Jan 2020 15:41:20 -0500 (EST)
Received: from lx140e.htt-consult.com (unknown [192.168.160.12]) (using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by z9m9z.htt-consult.com (Postfix) with ESMTPSA id C61F062123; Tue, 21 Jan 2020 15:41:19 -0500 (EST)
To: Donald Eastlake <d3e3e3@gmail.com>, draft-ietf-hip-dex.all@ietf.org
Cc: "iesg@ietf.org" <iesg@ietf.org>, secdir <secdir@ietf.org>
References: <CAF4+nEH=x4Lggm+mmr2aFz9eEy6ajWK9upJE7BQk60p6xLDBxw@mail.gmail.com>
From: Robert Moskowitz <rgm@labs.htt-consult.com>
Message-ID: <00644d2c-82b8-e486-981c-ee52e46c5492@labs.htt-consult.com>
Date: Tue, 21 Jan 2020 15:41:14 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2
MIME-Version: 1.0
In-Reply-To: <CAF4+nEH=x4Lggm+mmr2aFz9eEy6ajWK9upJE7BQk60p6xLDBxw@mail.gmail.com>
Content-Type: multipart/alternative; boundary="------------E35558D7E8181E59D64AABE0"
Content-Language: en-US
Archived-At: <https://mailarchive.ietf.org/arch/msg/secdir/yl5S3bqvJ2D4j88FbCUO8I55efI>
Subject: Re: [secdir] SECDIR Reveiw of draft-ietf-hip-dex-11
X-BeenThere: secdir@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Security Area Directorate <secdir.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/secdir>, <mailto:secdir-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/secdir/>
List-Post: <mailto:secdir@ietf.org>
List-Help: <mailto:secdir-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/secdir>, <mailto:secdir-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 21 Jan 2020 20:41:38 -0000
thanks I am overdue to finish my editing. I will add these.... On 1/20/20 11:18 PM, Donald Eastlake wrote: > I have reviewed this document as (a very late) part of the security > directorate's ongoing effort to review all IETF documents being > processed by the IESG. > > The summary of the review is Ready with Nits. > > Sorry to get this review in so late but, while approved by the IESG, > the draft is still in revised draft needed state so this may do some > good. On the security front, although the draft is pretty complex and > I am not that familiar with HIP, I did not see any significant > security issues that were not already called out in the draft. So I > concentrated on possible editorial issues. > > Editorial: > > Section 1.1, 3rd paragraph, page 5. Delete "However," a the beginning > of the 2nd sentence. It doesn't make sense. > > Section 2.3, Definitions should be in alphabetic order. > > Section 2.3: It seems to me that people who are puzzled about what > something means are most likely to be puzzled by the acronym. So I > would put the acronym first, where there is an acronym or acronym-like > term to use, then the expansion in parenthesis or in the body of the > definition. This done for a couple of entries like CMAC and CKDF but > most are the other way. Too much original cutting and pasting from multiple sources. Good comment. > > Section 3 last paragraph and Section 12.10 5th bullet: "to use" -> "use of" > > I think OGA and KEYMAT should be in the Definitions list and KEYMAT, > which I assume just is short for "keying material", should be expanded > on first use in Section 6.3. Alternatively, you could just replace all > occurrences of KEYMAT with "Keying Material". > > Section 5.3.2, page 23. The first sentence of the first paragraph > starting on that page has problems. Maybe "chose" should be "choses" > but I'm not sure: > "The DH_GROUP_LIST parameter contains the Responder's order of > preference based on which the Responder chose the ECDH key contained > in the HOST_ID parameter (see below)." > > Appendix A, first sentence, "allows to identify" -> "allows identifying" > > Appendix B, "IEDG" -> "IESG" > > Appendix B, around the middle of page 51, right after the line > beginning with "Section 6," there are three line with a blank line > before and after. I found this confusing at first. I suggest those > three line also be indented. > > Appendix B, page 52, "SHOUDS" -> "SHOUDs" > > Thanks, > Donald > =============================== > Donald E. Eastlake 3rd +1-508-333-2270 (cell) > 2386 Panoramic Circle, Apopka, FL 32703 USA > d3e3e3@gmail.com -- Standard Robert Moskowitz Owner HTT Consulting C:248-219-2059 F:248-968-2824 E:rgm@labs.htt-consult.com There's no limit to what can be accomplished if it doesn't matter who gets the credit
- [secdir] SECDIR Reveiw of draft-ietf-hip-dex-11 Donald Eastlake
- Re: [secdir] SECDIR Reveiw of draft-ietf-hip-dex-… Eric Vyncke (evyncke)
- Re: [secdir] SECDIR Reveiw of draft-ietf-hip-dex-… Donald Eastlake
- Re: [secdir] SECDIR Reveiw of draft-ietf-hip-dex-… Robert Moskowitz
- Re: [secdir] SECDIR Reveiw of draft-ietf-hip-dex-… Robert Moskowitz
- Re: [secdir] SECDIR Reveiw of draft-ietf-hip-dex-… Donald Eastlake
- Re: [secdir] SECDIR Reveiw of draft-ietf-hip-dex-… Robert Moskowitz