[secdir] SECDIR review of draft-josefsson-gss-capsulate-04

Chris Lonvick <clonvick@cisco.com> Wed, 20 April 2011 23:29 UTC

Return-Path: <clonvick@cisco.com>
X-Original-To: secdir@ietfc.amsl.com
Delivered-To: secdir@ietfc.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfc.amsl.com (Postfix) with ESMTP id 4624DE06F9; Wed, 20 Apr 2011 16:29:51 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -110.599
X-Spam-Level:
X-Spam-Status: No, score=-110.599 tagged_above=-999 required=5 tests=[BAYES_00=-2.599, RCVD_IN_DNSWL_HI=-8, USER_IN_WHITELIST=-100]
Received: from mail.ietf.org ([208.66.40.236]) by localhost (ietfc.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id eJCLT7J1vpQN; Wed, 20 Apr 2011 16:29:50 -0700 (PDT)
Received: from sj-iport-2.cisco.com (sj-iport-2.cisco.com [171.71.176.71]) by ietfc.amsl.com (Postfix) with ESMTP id 56B0AE0673; Wed, 20 Apr 2011 16:29:50 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=clonvick@cisco.com; l=912; q=dns/txt; s=iport; t=1303342190; x=1304551790; h=date:from:to:subject:message-id:mime-version; bh=KDnPPGenuXuTpbx4eDzY2ytzNJE+C0TXBXUzVxFs9zA=; b=e0IbiGzcpELUjQIlVja/GtmGEww/lRD3rOGJZR2sQtE70b5QSBjjxEJ/ SEAWgR+wr9HJD9mfPv240y4rmzOqLr3eMnBXunVgc8phMDUj7lFtG1htK YPxWWVUcZ2QiduRGDUqdjHQs0sK754omxhqlM0Wj/aomgPOwFRMgWPj1o U=;
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: Ar0FACprr02rRDoH/2dsb2JhbACXegGNS3eqZZxihXEEhXQ
X-IronPort-AV: E=Sophos;i="4.64,248,1301875200"; d="scan'208";a="341669571"
Received: from mtv-core-2.cisco.com ([171.68.58.7]) by sj-iport-2.cisco.com with ESMTP; 20 Apr 2011 23:29:49 +0000
Received: from sjc-cde-011.cisco.com (sjc-cde-011.cisco.com [171.69.16.68]) by mtv-core-2.cisco.com (8.14.3/8.14.3) with ESMTP id p3KNTnhw009451; Wed, 20 Apr 2011 23:29:49 GMT
Date: Wed, 20 Apr 2011 16:29:49 -0700
From: Chris Lonvick <clonvick@cisco.com>
To: iesg@ietf.org, secdir@ietf.org, draft-josefsson-gss-capsulate.all@tools.ietf.org
Message-ID: <Pine.GSO.4.63.1104151342060.1613@sjc-cde-011.cisco.com>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset="US-ASCII"; format="flowed"
Subject: [secdir] SECDIR review of draft-josefsson-gss-capsulate-04
X-BeenThere: secdir@ietf.org
X-Mailman-Version: 2.1.12
Precedence: list
List-Id: Security Area Directorate <secdir.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/secdir>, <mailto:secdir-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/secdir>
List-Post: <mailto:secdir@ietf.org>
List-Help: <mailto:secdir-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/secdir>, <mailto:secdir-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 20 Apr 2011 23:29:51 -0000

Hi,

I have reviewed this document as part of the security directorate's
ongoing effort to review all IETF documents being processed by the
IESG.  These comments were written primarily for the benefit of the
security area directors.  Document editors and WG chairs should treat
these comments just like any other last call comments.

Overall, I find the document to be of good quality and ready to progress.

One editorial suggestion I'd make would be to either include or directly 
reference the security section of RFC 2743 in your own security 
considerations section.

Also, I'm just not partial towards the use of "otherwise" to describe a 
return code from gss_oid_equal.  Personally, I think it should be directly 
specified.

Finally, I think you have a formatting inconsistency in Section 4.1; the 
"otherwise" should be tabbed out to line up in the other column.

Regards,
Chris