[secdir] Secdir telechat review of draft-ietf-spring-srv6-network-programming-19

Brian Weis via Datatracker <noreply@ietf.org> Tue, 22 September 2020 17:56 UTC

Return-Path: <noreply@ietf.org>
X-Original-To: secdir@ietf.org
Delivered-To: secdir@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id 90AE93A18B7; Tue, 22 Sep 2020 10:56:35 -0700 (PDT)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
From: Brian Weis via Datatracker <noreply@ietf.org>
To: <secdir@ietf.org>
Cc: draft-ietf-spring-srv6-network-programming.all@ietf.org, last-call@ietf.org, spring@ietf.org
X-Test-IDTracker: no
X-IETF-IDTracker: 7.17.0
Auto-Submitted: auto-generated
Precedence: bulk
Message-ID: <160079739555.27095.23366687198553864@ietfa.amsl.com>
Reply-To: Brian Weis <bew.stds@gmail.com>
Date: Tue, 22 Sep 2020 10:56:35 -0700
Archived-At: <https://mailarchive.ietf.org/arch/msg/secdir/zh9zTVkXXtDFkwpcx8dSr2Sg8YE>
Subject: [secdir] Secdir telechat review of draft-ietf-spring-srv6-network-programming-19
X-BeenThere: secdir@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Security Area Directorate <secdir.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/secdir>, <mailto:secdir-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/secdir/>
List-Post: <mailto:secdir@ietf.org>
List-Help: <mailto:secdir-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/secdir>, <mailto:secdir-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 22 Sep 2020 17:56:36 -0000

Reviewer: Brian Weis
Review result: Ready

I have reviewed this document as part of the security directorate's ongoing
effort to review all IETF documents being processed by the IESG. These comments
were written primarily for the benefit of the security area directors. Document
editors and WG chairs should treat these comments just like any other last call
comments.

This is a re-review; thanks to the authors for addressing suggestions made in
the first review. The new  security considerations text is good, and logically
correct so I've marked this document as "Ready". But let me explain one way I
think that it could be improved.

The last email exchange was about suggesting that the HMAC TLV be used even
when an SRH is not included in the packet. The newest text "regardless of the 
number of segments in the segment list" implies this case, but there is still a
concern is that implementors won't get this hint about the possible need to
protect just one segment where the SRH is omitted because it's not needed. It
would be nice if this sentence could be more explicit about the need for an
HMAC TLV in this case. For example, something like:
    <old> "regardless of the     number of segments in the segment list." </old>
    <new> "regardless of whether the segments are defined in an SRH header or a
    single segment is passed in the Destination Address." </new>

Thanks.