[secdir] Secdir last call review of draft-ietf-mmusic-msrp-usage-data-channel-22
Alexey Melnikov <alexey.melnikov@isode.com> Mon, 20 July 2020 12:46 UTC
Return-Path: <alexey.melnikov@isode.com>
X-Original-To: secdir@ietfa.amsl.com
Delivered-To: secdir@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 634DB3A095D; Mon, 20 Jul 2020 05:46:46 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.099
X-Spam-Level:
X-Spam-Status: No, score=-2.099 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=isode.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 2X3tcql_Gorz; Mon, 20 Jul 2020 05:46:45 -0700 (PDT)
Received: from statler.isode.com (Statler.isode.com [62.232.206.189]) by ietfa.amsl.com (Postfix) with ESMTP id 41CF93A0969; Mon, 20 Jul 2020 05:46:45 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1595249204; d=isode.com; s=june2016; i=@isode.com; bh=AtxAM79xYEqFWLP7CzWusiwi3iF467WN0jmpYPQtR4g=; h=From:Sender:Reply-To:Subject:Date:Message-ID:To:Cc:MIME-Version: In-Reply-To:References:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description; b=GR4YyCTCakawl14rHtlnUv21AY+teH9YpdUl+Bex2ZUHnGdWtAI/XEd+pSkMahRdhulXQr hNpCQrLwtOzK364AL84lXSWk8GO44EJa7jWfKKrb3YEBrAUj87Jve/B/7wfJHMpvUUgDpA WDw+XunBlxAnmsdOt7oxJXxVGy4okho=;
Received: from [172.27.248.196] (connect.isode.net [172.20.0.72]) by statler.isode.com (submission channel) via TCP with ESMTPSA id <XxWSMwAFTzsu@statler.isode.com>; Mon, 20 Jul 2020 13:46:43 +0100
To: "secdir@ietf.org" <secdir@ietf.org>
Cc: last-call@ietf.org, draft-ietf-mmusic-msrp-usage-data-channel.all@ietf.org
From: Alexey Melnikov <alexey.melnikov@isode.com>
Message-ID: <bc966e2a-a06b-0156-9672-961092d411dc@isode.com>
Date: Mon, 20 Jul 2020 13:46:42 +0100
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.9.0
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"; format="flowed"
Content-Language: en-GB
Content-transfer-encoding: quoted-printable
Archived-At: <https://mailarchive.ietf.org/arch/msg/secdir/zn9sism1JFwskO1HJ7mpIyqeK40>
Subject: [secdir] Secdir last call review of draft-ietf-mmusic-msrp-usage-data-channel-22
X-BeenThere: secdir@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Security Area Directorate <secdir.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/secdir>, <mailto:secdir-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/secdir/>
List-Post: <mailto:secdir@ietf.org>
List-Help: <mailto:secdir-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/secdir>, <mailto:secdir-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 20 Jul 2020 12:46:47 -0000
Reviewer: Alexey Melnikov Review result: Ready with Nits I have reviewed this document as part of the security directorate's ongoing effort to review all IETF documents being processed by the IESG. These comments were written primarily for the benefit of the security area directors. Document editors and WG chairs should treat these comments just like any other last call comments. The subject matter is outside my area of expertise and proper understanding of the document requires reading of several referenced documents. But I think I got the gist of what the document is trying to do. The Security Consideration talks about data channels providing confidentiality, integrity and source authentication for MSRP traffic, which is good. It also points out to discussion of MSRP message attribution in RFC 4975. However, session setup is done over SIP, which has different security considerations and nothing is mentioned about that. In particular, one of normatively referenced documents RFC 5547 has very good Security Considerations section (section 10) that talks about possible attacks on file transfer negotiation. I think this should be referenced in the document. I also feel that more can be said about possible use of MSRP for transferring of malicious files/images. In Section 6: o The gateway SHALL use CEMA towards the non-data channel endpoint. Please explain and/or add a reference for CEMA.
- [secdir] Secdir last call review of draft-ietf-mm… Alexey Melnikov
- Re: [secdir] Secdir last call review of draft-iet… Christer Holmberg
- Re: [secdir] [Last-Call] Secdir last call review … Alexey Melnikov
- Re: [secdir] [Last-Call] Secdir last call review … Christer Holmberg
- Re: [secdir] [Last-Call] Secdir last call review … Benjamin Kaduk