Re: [sfc] Shepherd's review of draft-ietf-sfc-nsh-integrity
Greg Mirsky <gregimirsky@gmail.com> Tue, 23 March 2021 17:55 UTC
Return-Path: <gregimirsky@gmail.com>
X-Original-To: sfc@ietfa.amsl.com
Delivered-To: sfc@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1])
by ietfa.amsl.com (Postfix) with ESMTP id F1DC33A0E17;
Tue, 23 Mar 2021 10:55:19 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.098
X-Spam-Level:
X-Spam-Status: No, score=-2.098 tagged_above=-999 required=5
tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1,
DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,
HTML_MESSAGE=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001]
autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key)
header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44])
by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024)
with ESMTP id D3nVu7zngV7Q; Tue, 23 Mar 2021 10:55:17 -0700 (PDT)
Received: from mail-lf1-x12a.google.com (mail-lf1-x12a.google.com
[IPv6:2a00:1450:4864:20::12a])
(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
(No client certificate requested)
by ietfa.amsl.com (Postfix) with ESMTPS id CCECB3A0E0A;
Tue, 23 Mar 2021 10:54:08 -0700 (PDT)
Received: by mail-lf1-x12a.google.com with SMTP id b4so4013675lfi.6;
Tue, 23 Mar 2021 10:54:08 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
h=mime-version:references:in-reply-to:from:date:message-id:subject:to;
bh=pV7Ey8NdLDHJxpZYBF0coCzorAPFTubXQTFuDlhF8Pk=;
b=Gm6s6Uy6Iz9KCEMT6hh5G8kkfgv8Yq+tmS0nw3Dacj7NzfOeMWJJVGM5T0AslTFg5Y
/2U7kluLpq0m12KqAeggJ1jdD/tIcdl0TzCum3qIpqQc6MHbrj4RLcR28vpn/M0GoK0o
Cq6sADwd+2uV8Bs5A9OFUG0dkDmdUXtuRpf3ssekTIKzVuUW23kt/KQRLlX/AKtTKDc1
cX6PYaNt8NUSd13tetjtEDlWL2g3bHomJD+o0sUYOxBZxETyINUNtFVnV2ZdGStaTKIp
dfrvbBm8T9AGcFrPh+Iu0cwN6eve6QR8Wng/cOLNij0h7qS4L+jovklHs4SbcOcVQEqo
QbDg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20161025;
h=x-gm-message-state:mime-version:references:in-reply-to:from:date
:message-id:subject:to;
bh=pV7Ey8NdLDHJxpZYBF0coCzorAPFTubXQTFuDlhF8Pk=;
b=GOk0KDQ2G57lI5PkGeVUEdtQHnWTQmZbxGacP/4P1+JMJxxkZ0YncNblZsxlJR6wgh
QNu6Iq06HcRUinNbiNbPpky2PEgMIpjSG7c0O4Xyrsq8TqCygMWb3zvwSsUiIXhnZLYg
DYOiwVk48pJuNDEbctO1S2Im3PxW9Q4ZLiRTIH+K8wnEdG9ZbhSb2jLIkUSLNi6WyGHE
GFlOe7TjtMADUIv4LpAOVvdmft4PzkZYJXwGEjh8ghIPNq8mV0i2fSq6kemBtXZ3Saxt
8Upd1AJawjfrF2Ik43QnndXG78oY2OsnUq49U2NqTPZksEiMmXb0vW6hr3VLTBRebE2x
1MIg==
X-Gm-Message-State: AOAM530XvuRvrpHVCpw9hZOr3xWVrKl5Kmu74sMtB0zpagSxScLgCtgi
Pe/oER3AqPENowr+xosbReXAWanR7ZpP71Kin0UKpJ93R6jWjQ==
X-Google-Smtp-Source: ABdhPJylesQW8gaolwDmYTqeaORP+4SZXW+/2ucWA80antjLa1StS14/h947iEQ7GlJjdLElrcnva2a4Xl39BfiGmzc=
X-Received: by 2002:ac2:430b:: with SMTP id l11mr3439980lfh.350.1616522044763;
Tue, 23 Mar 2021 10:54:04 -0700 (PDT)
MIME-Version: 1.0
References: <CA+RyBmX1yOY0ia_eNUPcoNS-mP6f7kQYdF8ZGWh-TDR8_+2ajw@mail.gmail.com>
In-Reply-To: <CA+RyBmX1yOY0ia_eNUPcoNS-mP6f7kQYdF8ZGWh-TDR8_+2ajw@mail.gmail.com>
From: Greg Mirsky <gregimirsky@gmail.com>
Date: Tue, 23 Mar 2021 10:53:54 -0700
Message-ID: <CA+RyBmVxcKnfyk7=AAT2rtkMEo-3aNoADBzxSROBHbZu_KHq+A@mail.gmail.com>
To: draft-ietf-sfc-nsh-integrity@ietf.org, sfc-chairs@ietf.org,
Service Function Chaining IETF list <sfc@ietf.org>
Content-Type: multipart/alternative; boundary="0000000000003ff0fe05be37deb5"
Archived-At: <https://mailarchive.ietf.org/arch/msg/sfc/7aAOF1I8l-vmfmawoLgRJqdZouI>
Subject: Re: [sfc] Shepherd's review of draft-ietf-sfc-nsh-integrity
X-BeenThere: sfc@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Network Service Chaining <sfc.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/sfc>,
<mailto:sfc-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/sfc/>
List-Post: <mailto:sfc@ietf.org>
List-Help: <mailto:sfc-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/sfc>,
<mailto:sfc-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 23 Mar 2021 17:55:20 -0000
Dear Authors, I should have checked IDnits results early. From me looking at it, two DownRefs marked as the most severe issues: - normative reference to RFC 7665 SFC Architecture - normative reference to RFC 8877 Guidelines for Defining Packet Timestamps In my opinion, the former is reasonable as a reader must be familiar with the SFC architecture. Do you think that the latter reference can be moved to the Informational References list? Regards, Greg On Tue, Mar 23, 2021 at 9:27 AM Greg Mirsky <gregimirsky@gmail.com> wrote: > Dear Authors, > thank you for your work on this very important and well-written document. > It is easy to read and grasp the technical concept of the proposed > solutions. Below, please find my notes and proposals addressing editorial > nits: > > - s/referred to is/referred to as/ > - s/integrity protected/integrity-protected/g > - s/access to an information/access to information/ > - s/See for example,/See, for example,/ > - Is there a need to use the normative language in the following text > or make the "should adopt" text more assertive: > > An NSH-aware SF can also be instructed about the behavior it > should adopt after consuming a context information that was > supplied in the NSH. > > > - s/a context information/context information/ > - s/A first level/The first level/ > - s/A second level/The second level/ > - s/four octet/four-octet/ > - s/The documents does not/The document does not/ > - s/for certain amount/for a certain amount/ > - s/variable length/variable-length/ > - s/excluding/, excluding/g > - s/In typical deployments/In typical deployments,/ > - s/used to integrity protect/used to protect the integrity of/g > - s/proceeds then/proceeds/ > - s/been tampered/been tampered with/ > - s/such those/such as those/ > - s/out of scope/out of the scope/ > - s/rate limited/rate-limited/ > - s/secdir/SecDir/ or extend it completely > > Regards, > Greg >
- [sfc] Shepherd's review of draft-ietf-sfc-nsh-int… Greg Mirsky
- Re: [sfc] Shepherd's review of draft-ietf-sfc-nsh… Greg Mirsky
- Re: [sfc] Shepherd's review of draft-ietf-sfc-nsh… mohamed.boucadair
- Re: [sfc] Shepherd's review of draft-ietf-sfc-nsh… mohamed.boucadair
- Re: [sfc] Shepherd's review of. draft-ietf-sfc-ns… Greg Mirsky