Re: [sfc] Shepherd's review of draft-ietf-sfc-nsh-integrity

[[e-mail]]

Re-,

Thank you for the review.

You can track the changes at: https://tinyurl.com/nsh-integrity-latest.

Please see inline.

Cheers,
Med

De : Greg Mirsky [mailto:[e-mail]]
Envoyé : mardi 23 mars 2021 17:27
À : [e-mail]; [e-mail]; Service Function Chaining IETF list <[e-mail]>
Objet : Shepherd's review of draft-ietf-sfc-nsh-integrity

Dear Authors,
thank you for your work on this very important and well-written document. It is easy to read and grasp the technical concept of the proposed solutions. Below, please find my notes and proposals addressing editorial nits:

  *   s/referred to is/referred to as/
[Med] The OLD one is correct.

  *   s/integrity protected/integrity-protected/g
[Med] Fixed.

  *   s/access to an information/access to information/
[Med] Changed to “NSH-supplied information”

  *   s/See for example,/See, for example,/
[Med] Fixed.

  *   Is there a need to use the normative language in the following text or make the "should adopt" text more assertive:
      An NSH-aware SF can also be instructed about the behavior it
      should adopt after consuming a context information that was
      supplied in the NSH.
[Med] I don’t think so. This is more on the control plane side.

  *   s/a context information/context information/
[Med] OK

  *   s/A first level/The first level/
[Med] Fixed

  *   s/A second level/The second level/
[Med] Idem.

  *   s/four octet/four-octet/
[Med] OK

  *   s/The documents does not/The document does not/
[Med] Fixed. Thanks.

  *   s/for certain amount/for a certain amount/
[Med] Fixed.

  *   s/variable length/variable-length/
[Med] OK

  *   s/excluding/, excluding/g
[Med] OK

  *   s/In typical deployments/In typical deployments,/
[Med] OK

  *   s/used to integrity protect/used to protect the integrity of/g
[Med] OK

  *   s/proceeds then/proceeds/
[Med] Fixed

  *   s/been tampered/been tampered with/
[Med] Left the OLD one.

  *   s/such those/such as those/
[Med] Sure.

  *   s/out of scope/out of the scope/
[Med] OK

  *   s/rate limited/rate-limited/
[Med] OK

  *   s/secdir/SecDir/ or extend it completely
[Med] Expanded it
Regards,
Greg

_________________________________________________________________________________________________________________________

Ce message et ses pieces jointes peuvent contenir des informations confidentielles ou privilegiees et ne doivent donc
pas etre diffuses, exploites ou copies sans autorisation. Si vous avez recu ce message par erreur, veuillez le signaler
a l'expediteur et le detruire ainsi que les pieces jointes. Les messages electroniques etant susceptibles d'alteration,
Orange decline toute responsabilite si ce message a ete altere, deforme ou falsifie. Merci.

This message and its attachments may contain confidential or privileged information that may be protected by law;
they should not be distributed, used or copied without authorisation.
If you have received this email in error, please notify the sender and delete this message and its attachments.
As emails may be altered, Orange is not liable for messages that have been modified, changed or falsified.
Thank you.