[sfc] Shepherd's review of draft-ietf-sfc-nsh-integrity
Greg Mirsky <gregimirsky@gmail.com> Tue, 23 March 2021 16:27 UTC
Return-Path: <gregimirsky@gmail.com>
X-Original-To: sfc@ietfa.amsl.com
Delivered-To: sfc@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1])
by ietfa.amsl.com (Postfix) with ESMTP id 9B96A3A0656;
Tue, 23 Mar 2021 09:27:32 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.098
X-Spam-Level:
X-Spam-Status: No, score=-2.098 tagged_above=-999 required=5
tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1,
DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,
HTML_MESSAGE=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001]
autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key)
header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44])
by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024)
with ESMTP id Nkon9J9CvHOl; Tue, 23 Mar 2021 09:27:28 -0700 (PDT)
Received: from mail-lf1-x133.google.com (mail-lf1-x133.google.com
[IPv6:2a00:1450:4864:20::133])
(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
(No client certificate requested)
by ietfa.amsl.com (Postfix) with ESMTPS id EFF6D3A0657;
Tue, 23 Mar 2021 09:27:27 -0700 (PDT)
Received: by mail-lf1-x133.google.com with SMTP id i26so11659422lfl.1;
Tue, 23 Mar 2021 09:27:27 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
h=mime-version:from:date:message-id:subject:to;
bh=a22Zv2g8SbmVjiDIrmJm18bIiBmzbWWTU2DraWBvJUI=;
b=NBZH06euxQ1w7DeUFh3BEHU62iG3Zfg13YQZu/TQ6Mmw2gaR3ze9NXzP9VNleOrY/d
VcBqAsODcDNk+dCZxtoXx0UhgyNw//20OoKWAg+Z0HTfups2FLE77JLWksDKC1YTvHkf
iIuZyGd91dqb3lzUfWLwddnKtCTKxn0W2ZW/nOR5icgnQ+6AiAbBpDSJMYJ3X84cjhyn
FauzSNOSWJR6V+nXpPpwB1Ywgrh0wZ/qNjuU4R+WQkchLyS0OJtg5d9opvccXfiebTbf
6P/QlKPlgJOyguP1eKOKYg9defRxa9zsUU0l88CMiDiaXfcBe2XtVaHNqTNurFOvO19e
h3ig==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20161025;
h=x-gm-message-state:mime-version:from:date:message-id:subject:to;
bh=a22Zv2g8SbmVjiDIrmJm18bIiBmzbWWTU2DraWBvJUI=;
b=PMb4ykYxB0qIO0m1FfT9lIb/fMYbT+GlbQj4maGL31dwkWR6yn9HRQvjw6uatwHFg5
/jEg2+TBrEd+0+IUdMBIheNBS7RH/ffEoIhemP225DvWSRbrYAYoltTfLYF8AXL1uWGR
gY42PeBRtM5W6AObVsNjtB90amts7eTDO0wF+zFFzPR7TvX1DdW3kgnEsIg3API0clKQ
PzdItjyxAsJwom8SmYpikNB1YYyaiRXvaIgWVnwZNJJTKVyU8wqdCut55PbktFvhU25L
K12VL2/zv+4h81mm0GkXrVsFptZtIop55Ag6YPfh106XVCdkCLlDB7VfAjPy2SGRdGIj
YsZw==
X-Gm-Message-State: AOAM530SSAGzuDYP9eKAbFkuQ0VRNdVMz4UO29+hch1gVhBFMFQg9nyp
ITc5OYFjI1s0kV/F5udIHe/5dPmS6L9Ozq91mrgx3ISJ6qn+Fw==
X-Google-Smtp-Source: ABdhPJzqp3DS8CI1/uo1def8NbNOO4zpSzJPx53FOaDls5mQzYqKmWS5ZJkX3rjt5oUaTXL/EsoBZ1UU19E4gdCm4NY=
X-Received: by 2002:ac2:430b:: with SMTP id l11mr3246327lfh.350.1616516845056;
Tue, 23 Mar 2021 09:27:25 -0700 (PDT)
MIME-Version: 1.0
From: Greg Mirsky <gregimirsky@gmail.com>
Date: Tue, 23 Mar 2021 09:27:13 -0700
Message-ID: <CA+RyBmX1yOY0ia_eNUPcoNS-mP6f7kQYdF8ZGWh-TDR8_+2ajw@mail.gmail.com>
To: draft-ietf-sfc-nsh-integrity@ietf.org, sfc-chairs@ietf.org,
Service Function Chaining IETF list <sfc@ietf.org>
Content-Type: multipart/alternative; boundary="00000000000052b50e05be36a8ad"
Archived-At: <https://mailarchive.ietf.org/arch/msg/sfc/eWxkWMd3BGS127xaMFZT3mp4td8>
Subject: [sfc] Shepherd's review of draft-ietf-sfc-nsh-integrity
X-BeenThere: sfc@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Network Service Chaining <sfc.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/sfc>,
<mailto:sfc-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/sfc/>
List-Post: <mailto:sfc@ietf.org>
List-Help: <mailto:sfc-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/sfc>,
<mailto:sfc-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 23 Mar 2021 16:27:33 -0000
Dear Authors,
thank you for your work on this very important and well-written document.
It is easy to read and grasp the technical concept of the proposed
solutions. Below, please find my notes and proposals addressing editorial
nits:
- s/referred to is/referred to as/
- s/integrity protected/integrity-protected/g
- s/access to an information/access to information/
- s/See for example,/See, for example,/
- Is there a need to use the normative language in the following text or
make the "should adopt" text more assertive:
An NSH-aware SF can also be instructed about the behavior it
should adopt after consuming a context information that was
supplied in the NSH.
- s/a context information/context information/
- s/A first level/The first level/
- s/A second level/The second level/
- s/four octet/four-octet/
- s/The documents does not/The document does not/
- s/for certain amount/for a certain amount/
- s/variable length/variable-length/
- s/excluding/, excluding/g
- s/In typical deployments/In typical deployments,/
- s/used to integrity protect/used to protect the integrity of/g
- s/proceeds then/proceeds/
- s/been tampered/been tampered with/
- s/such those/such as those/
- s/out of scope/out of the scope/
- s/rate limited/rate-limited/
- s/secdir/SecDir/ or extend it completely
Regards,
Greg
- [sfc] Shepherd's review of draft-ietf-sfc-nsh-int… Greg Mirsky
- Re: [sfc] Shepherd's review of draft-ietf-sfc-nsh… Greg Mirsky
- Re: [sfc] Shepherd's review of draft-ietf-sfc-nsh… mohamed.boucadair
- Re: [sfc] Shepherd's review of draft-ietf-sfc-nsh… mohamed.boucadair
- Re: [sfc] Shepherd's review of. draft-ietf-sfc-ns… Greg Mirsky