Re: [sfc] Shepherd's review of. draft-ietf-sfc-nsh-integrity
Greg Mirsky <gregimirsky@gmail.com> Wed, 24 March 2021 01:52 UTC
Return-Path: <gregimirsky@gmail.com>
X-Original-To: sfc@ietfa.amsl.com
Delivered-To: sfc@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 44A803A1CE0; Tue, 23 Mar 2021 18:52:56 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.097
X-Spam-Level:
X-Spam-Status: No, score=-2.097 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id sU_0JtOxTYss; Tue, 23 Mar 2021 18:52:51 -0700 (PDT)
Received: from mail-lf1-x12e.google.com (mail-lf1-x12e.google.com [IPv6:2a00:1450:4864:20::12e]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 336593A1CDC; Tue, 23 Mar 2021 18:52:51 -0700 (PDT)
Received: by mail-lf1-x12e.google.com with SMTP id q29so29401215lfb.4; Tue, 23 Mar 2021 18:52:51 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=el9UcZd49swYrrvaQL+2EnsEKwSBZM7JVF5AJ0tP2YY=; b=vDZKJQN8WWRO6At901bEhlBO7Rw7uv90Do78tmblSzbahmP+yOgJV39DWfc4Is/VLv pTkZIe5CtB8XYgqbsxX1umTCv8AgMBr625/2Fw6GsCRKDYy9Aegd+JQMdoSDfP60C9dv kabQnfIjJRtt4ilUH8jAuTdMY+hK91NvU+bnb/C3boJaoMtEz4+MCV/QJNIFLIVC0fMR tsUphDGAcPx1WY2hKSCxtuo/zXMIhf9tTsOBcMOsH5z+CmKOY9iCevCdlqYnlGtT2DFx 9U3L0Rv9YUIToJ5a+FAWzZ5+ckrxZghLHzO+NcNi1BlfDpvPyV4qsjBLwnouUQM05TiN 6h+Q==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=el9UcZd49swYrrvaQL+2EnsEKwSBZM7JVF5AJ0tP2YY=; b=BlKX6s5UtxjzGY0uiF8Xo1CxEsuIVSU0QrNEJmVjXL73AyBRAk/OES1l5Eb9zAz2oy 0WahWKD4BsV0Aww7/XGgC43HgJSGEi2ET2GWf7OzD14t2uWu0cmxvYt90XRssfbpEGM/ EcIkeR+8MSJ5xmLfoM6tLzSHcYxRf50fQ8jl8x64bG+ekREPH+hLUmFZMUKM6zP9ONtv cVcmzny+jbcAQpKoftyLJDoKqvRp9n1kY0vtkAbLVLeZAVQtgi/f5Wh4WnPjqoqHweoA Wnpshv1Khbj7odYHC1lqJQtc1lUI+m6/3nhi4jFXcXqxZR7tgqKA+hMRYsI4W0GNhTeZ flcw==
X-Gm-Message-State: AOAM533a44Ql8lStkZrJpRz8094eRUAkPcLhsHtd5krfQhG7nh29tYqd 4WxZJ86fRaSnW5DQpd/c0bSazSPXefNaNUQ7BsM=
X-Google-Smtp-Source: ABdhPJxdNx8gFusAsGoMdmW7nFNBpgxgn/aIxb1+B20miWqwFpxBZg/SVOYOq9LoYFQ/rXTJ7PCbSF+WCgxRbJa+yuA=
X-Received: by 2002:a05:6512:3a81:: with SMTP id q1mr501948lfu.388.1616550767511; Tue, 23 Mar 2021 18:52:47 -0700 (PDT)
MIME-Version: 1.0
References: <CA+RyBmX1yOY0ia_eNUPcoNS-mP6f7kQYdF8ZGWh-TDR8_+2ajw@mail.gmail.com> <20293_1616523092_605A2F54_20293_445_1_787AE7BB302AE849A7480A190F8B93303535A933@OPEXCAUBMA2.corporate.adroot.infra.ftgroup>
In-Reply-To: <20293_1616523092_605A2F54_20293_445_1_787AE7BB302AE849A7480A190F8B93303535A933@OPEXCAUBMA2.corporate.adroot.infra.ftgroup>
From: Greg Mirsky <gregimirsky@gmail.com>
Date: Tue, 23 Mar 2021 18:58:13 -0700
Message-ID: <CA+RyBmVn9Rb6k7aVeXvzm-N5mifxP5o3aZF0rcuzX=sRocjGwg@mail.gmail.com>
To: Med Boucadair <mohamed.boucadair@orange.com>
Cc: draft-ietf-sfc-nsh-integrity@ietf.org, sfc-chairs@ietf.org, Service Function Chaining IETF list <sfc@ietf.org>
Content-Type: multipart/alternative; boundary="000000000000424be505be3e8e7f"
Archived-At: <https://mailarchive.ietf.org/arch/msg/sfc/mny885LZN2-lZw7q1CjAWKRlNgw>
Subject: Re: [sfc] Shepherd's review of. draft-ietf-sfc-nsh-integrity
X-BeenThere: sfc@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Network Service Chaining <sfc.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/sfc>, <mailto:sfc-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/sfc/>
List-Post: <mailto:sfc@ietf.org>
List-Help: <mailto:sfc-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/sfc>, <mailto:sfc-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 24 Mar 2021 01:52:56 -0000
Hi Med, thank you for your thoughtful response. I am OK with the proposed updates, they address my comments perfectly. Regards, Greg On Tue, Mar 23, 2021, 11:11 <mohamed.boucadair@orange.com> wrote: > Re-, > > > > Thank you for the review. > > > > You can track the changes at: https://tinyurl.com/nsh-integrity-latest. > > > > Please see inline. > > > > Cheers, > > Med > > > > *De :* Greg Mirsky [mailto:gregimirsky@gmail.com] > *Envoyé :* mardi 23 mars 2021 17:27 > *À :* draft-ietf-sfc-nsh-integrity@ietf.org; sfc-chairs@ietf.org; Service > Function Chaining IETF list <sfc@ietf.org> > *Objet :* Shepherd's review of draft-ietf-sfc-nsh-integrity > > > > Dear Authors, > > thank you for your work on this very important and well-written document. > It is easy to read and grasp the technical concept of the proposed > solutions. Below, please find my notes and proposals addressing editorial > nits: > > - s/referred to is/referred to as/ > > *[Med] The OLD one is correct. * > > - s/integrity protected/integrity-protected/g > > *[Med] Fixed. * > > - s/access to an information/access to information/ > > *[Med] Changed to “NSH-supplied information”* > > - s/See for example,/See, for example,/ > > *[Med] Fixed. * > > - Is there a need to use the normative language in the following text > or make the "should adopt" text more assertive: > > An NSH-aware SF can also be instructed about the behavior it > should adopt after consuming a context information that was > supplied in the NSH. > > *[Med] I don’t think so. This is more on the control plane side. * > > > - s/a context information/context information/ > > *[Med] OK* > > - s/A first level/The first level/ > > *[Med] Fixed* > > - s/A second level/The second level/ > > *[Med] Idem. * > > - s/four octet/four-octet/ > > *[Med] OK* > > - s/The documents does not/The document does not/ > > *[Med] Fixed. Thanks. * > > - s/for certain amount/for a certain amount/ > > *[Med] Fixed. * > > - s/variable length/variable-length/ > > *[Med] OK* > > - s/excluding/, excluding/g > > *[Med] OK* > > - s/In typical deployments/In typical deployments,/ > > *[Med] OK* > > - s/used to integrity protect/used to protect the integrity of/g > > *[Med] OK* > > - s/proceeds then/proceeds/ > > *[Med] Fixed* > > - s/been tampered/been tampered with/ > > *[Med] Left the OLD one. * > > - s/such those/such as those/ > > *[Med] Sure.* > > - s/out of scope/out of the scope/ > > *[Med] OK* > > - s/rate limited/rate-limited/ > > *[Med] OK* > > - s/secdir/SecDir/ or extend it completely > > *[Med] Expanded it* > > Regards, > > Greg > > _________________________________________________________________________________________________________________________ > > Ce message et ses pieces jointes peuvent contenir des informations confidentielles ou privilegiees et ne doivent donc > pas etre diffuses, exploites ou copies sans autorisation. Si vous avez recu ce message par erreur, veuillez le signaler > a l'expediteur et le detruire ainsi que les pieces jointes. Les messages electroniques etant susceptibles d'alteration, > Orange decline toute responsabilite si ce message a ete altere, deforme ou falsifie. Merci. > > This message and its attachments may contain confidential or privileged information that may be protected by law; > they should not be distributed, used or copied without authorisation. > If you have received this email in error, please notify the sender and delete this message and its attachments. > As emails may be altered, Orange is not liable for messages that have been modified, changed or falsified. > Thank you. > >
- [sfc] Shepherd's review of draft-ietf-sfc-nsh-int… Greg Mirsky
- Re: [sfc] Shepherd's review of draft-ietf-sfc-nsh… Greg Mirsky
- Re: [sfc] Shepherd's review of draft-ietf-sfc-nsh… mohamed.boucadair
- Re: [sfc] Shepherd's review of draft-ietf-sfc-nsh… mohamed.boucadair
- Re: [sfc] Shepherd's review of. draft-ietf-sfc-ns… Greg Mirsky