Re: [sidr] Adam Roach's Discuss on draft-ietf-sidr-slurm-07: (with DISCUSS and COMMENT)

Adam Roach <adam@nostrum.com> Wed, 04 April 2018 19:33 UTC

Return-Path: <adam@nostrum.com>
X-Original-To: sidr@ietfa.amsl.com
Delivered-To: sidr@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 92EE4126DCA; Wed, 4 Apr 2018 12:33:16 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.89
X-Spam-Level:
X-Spam-Status: No, score=-1.89 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, T_RP_MATCHES_RCVD=-0.01, T_SPF_HELO_PERMERROR=0.01, T_SPF_PERMERROR=0.01] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id sk4uX57NPj_F; Wed, 4 Apr 2018 12:33:15 -0700 (PDT)
Received: from nostrum.com (raven-v6.nostrum.com [IPv6:2001:470:d:1130::1]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 1DDB81200B9; Wed, 4 Apr 2018 12:33:14 -0700 (PDT)
Received: from Svantevit.local (99-152-146-228.lightspeed.dllstx.sbcglobal.net [99.152.146.228]) (authenticated bits=0) by nostrum.com (8.15.2/8.15.2) with ESMTPSA id w34JXBOR047374 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NO); Wed, 4 Apr 2018 14:33:12 -0500 (CDT) (envelope-from adam@nostrum.com)
X-Authentication-Warning: raven.nostrum.com: Host 99-152-146-228.lightspeed.dllstx.sbcglobal.net [99.152.146.228] claimed to be Svantevit.local
From: Adam Roach <adam@nostrum.com>
To: The IESG <iesg@ietf.org>
Cc: morrowc@ops-netman.net, draft-ietf-sidr-slurm@ietf.org, sidr@ietf.org, sidr-chairs@ietf.org, aretana.ietf@gmail.com
References: <152286976586.23998.1170348122023610014.idtracker@ietfa.amsl.com>
Message-ID: <90f50a1f-7104-cbad-a101-a1dbb28949a5@nostrum.com>
Date: Wed, 4 Apr 2018 14:33:06 -0500
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:52.0) Gecko/20100101 Thunderbird/52.6.0
MIME-Version: 1.0
In-Reply-To: <152286976586.23998.1170348122023610014.idtracker@ietfa.amsl.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US
Archived-At: <https://mailarchive.ietf.org/arch/msg/sidr/3p-uc9HZ2H-uBupJfpon6RsDqdw>
Subject: Re: [sidr] Adam Roach's Discuss on draft-ietf-sidr-slurm-07: (with DISCUSS and COMMENT)
X-BeenThere: sidr@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: Secure Interdomain Routing <sidr.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/sidr>, <mailto:sidr-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/sidr/>
List-Post: <mailto:sidr@ietf.org>
List-Help: <mailto:sidr-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/sidr>, <mailto:sidr-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 04 Apr 2018 19:33:16 -0000

I realized after I sent this that my suggested text has a couple of 
errors in t.

On 4/4/18 2:22 PM, Adam Roach wrote:
>
> Fixing this should be pretty easy; the document simply needs text added that
> describes the JSON structure explicitly, with clear indications of how values
> are to be encoded. For example, the preceding text I quote becomes:
>
>     A SLURM file consists of a single JSON object containing the following
>     members:
>
>     o  A  "slurmVersion" member that MUST be set to 1, encoded as a number
>
>     o  A "slurmTarget" member (Section 3.3) If more than one target line is
>        present, all targets MUST be acceptable to the RP. The "slurmTarget"
>        member is encoded as an array of zero or more objects. Each object in the
>        array contains exactly one member.  In this version of SLURM, the member
>        may be named either:

I copied the "target line" language over without reading it carefully. I 
don't think "line" makes sense here. Perhaps:

    o  A "slurmTarget" member (Section 3.3). The "slurmTarget" member is 
encoded
       as an array of zero or more objects, each representing a target.  If
       more than one target is present, all targets MUST be acceptable 
to the
       RP.  Each object in the array contains exactly one member.  In this
       version of SLURM, the member may be named either:


>
>        * "asn", in which case it contains an ASN, or

This should should say "...an ASN, encoded as a number."

>
>        * "hostname", in which case it contains a Fully Qualified Domain
>           Name (FQDN).
>
>     o  A "validationOutputFilters" member (Section 3.4), whose value is an
>        object. The object MUST contain exactly two members:
>
>        *  A "prefixFilters" member, whose value is described in
>           Section 3.4.1
>
>        *  A "bgpsecFilters" member, whose value is described in
>           Section 3.4.2
>
>     o  A "locallyAddedAssertions" member (Section 3.5), whose value is an
>        object. The object MUST contain exactly two members:
>
>        *  A "prefixAssertions" member, whose value is described in
>           Section 3.5.1
>
>        *  A "bgpsecAssertions" member, whose value is described in
>           Section 3.5.2