[sidr] Review of draft-ietf-sidr-publication-09
Peter Yee <firstname.lastname@example.org> Sat, 07 January 2017 07:20 UTC
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id ED64D1298BB; Fri, 6 Jan 2017 23:20:54 -0800 (PST)
Content-Type: text/plain; charset="utf-8"
From: Peter Yee <email@example.com>
Date: Fri, 06 Jan 2017 23:20:54 -0800
Cc: firstname.lastname@example.org, email@example.com, firstname.lastname@example.org
Subject: [sidr] Review of draft-ietf-sidr-publication-09
List-Id: Secure Interdomain Routing <sidr.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/sidr>, <mailto:email@example.com?subject=unsubscribe>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/sidr>, <mailto:firstname.lastname@example.org?subject=subscribe>
X-List-Received-Date: Sat, 07 Jan 2017 07:20:55 -0000
Reviewer: Peter Yee Review result: Ready with Nits I am the assigned Gen-ART reviewer for this draft. The General Area Review Team (Gen-ART) reviews all IETF documents being processed by the IESG for the IETF Chair. Please treat these comments just like any other last call comments. For more information, please see the FAQ at <https://trac.ietf.org/trac/gen/wiki/GenArtfaq>. Document: draft-ietf-sidr-publication-09 Reviewer: Peter Yee Review Date: 2017-01-06 IETF LC End Date: 2017-01-06 IESG Telechat date: 2017-01-19 Summary: This specification defines a protocol for handling objects in an RPKI repository. The document seems fairly straightforward and simple to understand. Major issues: Minor issues: Nits/editorial comments: Page 5, Section 2.2, last paragraph, last sentence: perhaps change "are permitted to" to "MAY"? Page 7, Section 2.6, 1st paragraph: change "RelaxNG" to "RELAX NG". (Hey, I had to look it up.) Page 14, Section 4, 1st paragraph after rsync enumation: "safely" is used but no subsequent mention is made of what is unsafe about the non-overlapping rsync directories. Is the reader expected to know something about rsync's safety? Nothing in the Security Considerations deals with this topic. Page 16, Section 6, 3rd paragraph, 2nd sentence: insert "private" before "keys". Insert "to" before "delete". Page 17, Section 7: it might be good to include references to: XML, RelaxNG, and maybe rsync (yeah, I know that one is a little tough).