[sidr] Ben Campbell's No Objection on draft-ietf-sidr-slurm-07: (with COMMENT)

Ben Campbell <ben@nostrum.com> Tue, 03 April 2018 19:43 UTC

Return-Path: <ben@nostrum.com>
X-Original-To: sidr@ietf.org
Delivered-To: sidr@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id 5A3CD126DFF; Tue, 3 Apr 2018 12:43:24 -0700 (PDT)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
From: Ben Campbell <ben@nostrum.com>
To: "The IESG" <iesg@ietf.org>
Cc: draft-ietf-sidr-slurm@ietf.org, Chris Morrow <morrowc@ops-netman.net>, aretana.ietf@gmail.com, sidr-chairs@ietf.org, morrowc@ops-netman.net, sidr@ietf.org
X-Test-IDTracker: no
X-IETF-IDTracker: 6.77.1
Auto-Submitted: auto-generated
Precedence: bulk
Message-ID: <152278460436.22775.8518027666585390285.idtracker@ietfa.amsl.com>
Date: Tue, 03 Apr 2018 12:43:24 -0700
Archived-At: <https://mailarchive.ietf.org/arch/msg/sidr/drnFgJRKEwCxaTKrn9SGsfwM8Pg>
Subject: [sidr] Ben Campbell's No Objection on draft-ietf-sidr-slurm-07: (with COMMENT)
X-BeenThere: sidr@ietf.org
X-Mailman-Version: 2.1.22
List-Id: Secure Interdomain Routing <sidr.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/sidr>, <mailto:sidr-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/sidr/>
List-Post: <mailto:sidr@ietf.org>
List-Help: <mailto:sidr-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/sidr>, <mailto:sidr-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 03 Apr 2018 19:43:24 -0000

Ben Campbell has entered the following ballot position for
draft-ietf-sidr-slurm-07: No Objection

When responding, please keep the subject line intact and reply to all
email addresses included in the To and CC lines. (Feel free to cut this
introductory paragraph, however.)


Please refer to https://www.ietf.org/iesg/statement/discuss-criteria.html
for more information about IESG DISCUSS and COMMENT positions.


The document, along with other ballot positions, can be found here:
https://datatracker.ietf.org/doc/draft-ietf-sidr-slurm/



----------------------------------------------------------------------
COMMENT:
----------------------------------------------------------------------

Major Comments:

§6: I also agree with Benjamin's sadness about the security considerations. The
section really should at least discuss the potential consequences of an
adversary inserting a false slurm file, modifying one on the fly, or
eavesdropping on one.

Minor Comments:

§1.1: The document contains at least a few lower case instances of "must".
Please consider using the boilerplate from RFC 8174.

§3.3, 1st paragraph: "RP SHOULD verify that the target is an acceptable value"
What is the criteria for acceptability?

§8.2, " [RFC4648]": The document requires Base64 encoding. Doesn't that make
this a normative reference?

Editorial Comments and Nits:

 [significant] Abstract (and throughout the document):

I don't find the term "local view of the RPKI" to be descriptive. IIUC, we are
talking about overriding assertions that come from the RPKI based on local (or
possibly 3rd party) knowledge. This seems to me to be a different thing than
providing a "local view of the RPKI", and I certainly would not have gotten a
sense of that difference from the Abstract alone, and possibly not the
introduction.

§1, last paragraph: Please expand or define rpki-rtr on first mention.

§3.4.1: Please expand SKI on first mention. (You do so in the second mention
:-) )