Re: [Sidrops] I-D Action: draft-ietf-sidrops-rpki-prefixlist-01.txt
Job Snijders <job@fastly.com> Wed, 24 January 2024 22:11 UTC
Return-Path: <job@fastly.com>
X-Original-To: sidrops@ietfa.amsl.com
Delivered-To: sidrops@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 0F98BC151527 for <sidrops@ietfa.amsl.com>; Wed, 24 Jan 2024 14:11:59 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.104
X-Spam-Level:
X-Spam-Status: No, score=-2.104 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001, T_SCC_BODY_TEXT_LINE=-0.01, URIBL_BLOCKED=0.001, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=fastly.com
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id y6Mnz-xlhPTf for <sidrops@ietfa.amsl.com>; Wed, 24 Jan 2024 14:11:55 -0800 (PST)
Received: from mail-ej1-x62f.google.com (mail-ej1-x62f.google.com [IPv6:2a00:1450:4864:20::62f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 5696BC151094 for <sidrops@ietf.org>; Wed, 24 Jan 2024 14:11:55 -0800 (PST)
Received: by mail-ej1-x62f.google.com with SMTP id a640c23a62f3a-a316a062854so12582066b.2 for <sidrops@ietf.org>; Wed, 24 Jan 2024 14:11:55 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastly.com; s=google; t=1706134313; x=1706739113; darn=ietf.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=qeJNLh3UIx9bUwYEST78I1HS6oKhHNOv2db+4/pYHGM=; b=aO0Lr4rBfNqg9PDA/RCpIfD2GGFKkv9XGv/kSSXOsBHxtWc8JOv3qjHRDZZVunoJy6 /fbEc4N8IIdyfgQ0h8H4cn3OKF+iUiyQWhJhS2d5Yi86mDfmQaPMQ/06u8Uy07H8jWDV tTezJd0TEHannrmxUCvZ3f7Jx/cLbKwYor2RM=
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706134313; x=1706739113; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=qeJNLh3UIx9bUwYEST78I1HS6oKhHNOv2db+4/pYHGM=; b=gzzgcKHPeYVFAMYzOiHoysHFLrUEEBcTFKWyOTa+x5u2issLnrWjjt8bwQJ0ZOVL8Q ERxVLYIH+oN0aWNCU4os4Ow0cSTFTn3a4uwekYV+p1+INem90XXMZzNApaHyygI4GEME PXtUSBvhZ3oRLh/D5Pb2wcowx6300dkYCUOmO/KuvKtj+qfy9F7a4u3C+09LCtJM1/i8 ZLmRUqKkumAuwISbwzK36QOOUVfBC+3VIHbQu/FOYNJaLhNxTNhWbUvEgslRQ49w/55S /ZoBa7BWp6Vl3Dcw2uvjzCxez/rKbYqaszG4GcOs0FmBFTB2Mzo8l/daQUIJxFUqSGDy aWGA==
X-Gm-Message-State: AOJu0YxbKM6HH1bafhPkOkQRiG3Rrp3tIpAcZhPZh4AY4hfo5Jl/He3F CPQ99wtiAtgjKuc3KhmlQPdBzvZxGbVkAtGm6XBB46ryETuDyvq0gSU+mzxKKeCpVQV00LHQtdU b
X-Google-Smtp-Source: AGHT+IGy360xgOX14wsynJ2nzfcvXF8wrHBuDabPnXNzsYq8S3mcO0P2VgPQEyVIh5WbgUIsNn5pZA==
X-Received: by 2002:a17:906:eb18:b0:a26:88f4:3fae with SMTP id mb24-20020a170906eb1800b00a2688f43faemr1136071ejb.67.1706134313044; Wed, 24 Jan 2024 14:11:53 -0800 (PST)
Received: from snel ([2a10:3781:276:3:16f6:d8ff:fe47:2eb7]) by smtp.gmail.com with ESMTPSA id g21-20020a17090613d500b00a3006857c55sm312269ejc.130.2024.01.24.14.11.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Jan 2024 14:11:52 -0800 (PST)
Date: Wed, 24 Jan 2024 23:11:51 +0100
From: Job Snijders <job@fastly.com>
To: Russ Housley <housley@vigilsec.com>
Cc: sidrops <sidrops@ietf.org>
Message-ID: <ZbGLJ1hmpoz_XTAg@snel>
References: <170612503890.46313.7195737912432658695@ietfa.amsl.com> <2360628E-B1CF-47B0-B5D9-AC81954F147F@vigilsec.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <2360628E-B1CF-47B0-B5D9-AC81954F147F@vigilsec.com>
X-Clacks-Overhead: GNU Terry Pratchett
Archived-At: <https://mailarchive.ietf.org/arch/msg/sidrops/71aGkSjZKon1v2YTnprOcn7TW2M>
Subject: Re: [Sidrops] I-D Action: draft-ietf-sidrops-rpki-prefixlist-01.txt
X-BeenThere: sidrops@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: A list for the SIDR Operations WG <sidrops.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/sidrops>, <mailto:sidrops-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/sidrops/>
List-Post: <mailto:sidrops@ietf.org>
List-Help: <mailto:sidrops-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/sidrops>, <mailto:sidrops-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 24 Jan 2024 22:11:59 -0000
Dear Russ,
Thanks for the review.
On Wed, Jan 24, 2024 at 04:07:06PM -0500, Russ Housley wrote:
> I am confused by this change in the syntax:
>
> IPv4Prefixes ::= SEQUENCE (SIZE(1..MAX)) OF AddressPrefix{32}
> IPv6Prefixes ::= SEQUENCE (SIZE(1..MAX)) OF AddressPrefix{128}
>
> AddressPrefix {INTEGER: len} ::= BIT STRING (SIZE(0..len))
>
> What does it mean when the prefix is a zero length BIT STRING?
That would be 0.0.0.0/0 or ::/0, right?
As I understand it a BIT STRING value can have any length, including
zero. Same approach is used in draft-ietf-sidrops-rfc6482bis.
> Nit: you might want to change len to maxlen to make it clear that it
> is a bound, not the actual length of the prefix.
How about this?
https://github.com/job/draft-sidrops-rpki-prefixlist/commit/4397b06cdb277b4f1774d66af1d0bd53d83182c0
Kind regards,
Job
- [Sidrops] I-D Action: draft-ietf-sidrops-rpki-pre… internet-drafts
- Re: [Sidrops] I-D Action: draft-ietf-sidrops-rpki… Russ Housley
- Re: [Sidrops] I-D Action: draft-ietf-sidrops-rpki… Job Snijders
- Re: [Sidrops] I-D Action: draft-ietf-sidrops-rpki… Russ Housley
- Re: [Sidrops] I-D Action: draft-ietf-sidrops-rpki… Job Snijders