[Sidrops] Tsvart last call review of draft-ietf-sidrops-8210bis-06

Michael Tüxen via Datatracker <noreply@ietf.org> Fri, 29 April 2022 22:01 UTC

Return-Path: <noreply@ietf.org>
X-Original-To: sidrops@ietf.org
Delivered-To: sidrops@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id 34DFBC15E3E6; Fri, 29 Apr 2022 15:01:59 -0700 (PDT)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
From: Michael Tüxen via Datatracker <noreply@ietf.org>
To: tsv-art@ietf.org
Cc: draft-ietf-sidrops-8210bis.all@ietf.org, last-call@ietf.org, sidrops@ietf.org
X-Test-IDTracker: no
X-IETF-IDTracker: 8.1.0
Auto-Submitted: auto-generated
Precedence: bulk
Message-ID: <165126971920.48486.5512389938771478355@ietfa.amsl.com>
Reply-To: Michael Tüxen <tuexen@fh-muenster.de>
Date: Fri, 29 Apr 2022 15:01:59 -0700
Archived-At: <https://mailarchive.ietf.org/arch/msg/sidrops/FRkMOMVnplkHVaHb_mV-_qd-FXo>
Subject: [Sidrops] Tsvart last call review of draft-ietf-sidrops-8210bis-06
X-BeenThere: sidrops@ietf.org
X-Mailman-Version: 2.1.34
List-Id: A list for the SIDR Operations WG <sidrops.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/sidrops>, <mailto:sidrops-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/sidrops/>
List-Post: <mailto:sidrops@ietf.org>
List-Help: <mailto:sidrops-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/sidrops>, <mailto:sidrops-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 29 Apr 2022 22:01:59 -0000

Reviewer: Michael Tüxen
Review result: Ready with Nits

This document has been reviewed as part of the transport area review team's
ongoing effort to review key IETF documents. These comments were written
primarily for the transport area directors, but are copied to the document's
authors and WG to allow them to address any issues raised and also to the IETF
discussion list for information.

When done at the time of IETF Last Call, the authors should consider this
review as part of the last-call comments they receive. Please always CC
tsv-art@ietf.org if you reply to or forward this review.

Addressing the following comments might help to improve the document:

1. In the first paragraph of Section 4, the term 'connection' is used.
   I guess this is referring to a 'transport connection'. If that is
   true, using 'transport connection' improves readability.

2. Section 4 talks about connection establishment. When should a
   connection be terminated?

3. Section 4 talks about connection establishment. What happens
   if a connection is terminated in a graceful or non-graceful way?

4. Section 6 provides values for timers. The minimum values for the
   Refresh Interval and the Retry Interval, both 1 second, might
   interfere with loss recovery timers of the underlying transport
   protocol. Is there any mechanism in the protocol to deal with this?

5. Section 9 describes that end points SHOULD use keep-alives, if
   available at the transport layer. Any recommendation regarding the
   time after which it should be sent and about the frequency?

Best regards
Michael