Re: [Sidrops] AD Review of: draft-ietf-sidrops-rfc6482bis - "A Profile for Route Origin Authorizations (ROAs)"

Martin Hoffmann <martin@nlnetlabs.nl> Wed, 20 September 2023 11:13 UTC

Return-Path: <martin@nlnetlabs.nl>
X-Original-To: sidrops@ietfa.amsl.com
Delivered-To: sidrops@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id E3B58C1524DD; Wed, 20 Sep 2023 04:13:25 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -7.107
X-Spam-Level:
X-Spam-Status: No, score=-7.107 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, URIBL_BLOCKED=0.001, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=nlnetlabs.nl
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id lPHu0_xitmcO; Wed, 20 Sep 2023 04:13:21 -0700 (PDT)
Received: from outbound.soverin.net (outbound.soverin.net [185.233.34.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id D753BC1524A3; Wed, 20 Sep 2023 04:13:20 -0700 (PDT)
Received: from smtp.soverin.net (c04cst-smtp-sov02.int.sover.in [10.10.4.100]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by outbound.soverin.net (Postfix) with ESMTPS id 4RrG9T6Gq4zHB; Wed, 20 Sep 2023 11:13:17 +0000 (UTC)
Received: from smtp.soverin.net (smtp.soverin.net [10.10.4.100]) by soverin.net (Postfix) with ESMTPSA id 4RrG9T04W8zLb; Wed, 20 Sep 2023 11:13:17 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=nlnetlabs.nl; s=soverin; t=1695208397; bh=kTP6QRw4Q+nhEoyI0Z94hhHXHb3sptXUaZUdmGpknr4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=OcX1d8wPQrQGwWBPaLVc1mSGf3b6K+fZoP5T2C3jptlqvpRkSH7xhk9bqhiFJ36/M v3I946+iL5TMAz5RQhVqoWtEEaqtdZordzU988wecYxcaRsmfUDUqe7wLXKjR/xcXN 6W2xYV62e36heN9wIw0NZi5ZR0/sNfCWmmRdeBVfxcnlW+oHGyrzZUA6U2tgpTCzBD v2L2lk5Y0/XBrjRdAOgbPgSxfLqCTScwN9JwEPnxfgeUSY4KBbPM/F9/Udx/QCmlMv 0kAOuG8Yh1dUyZUIJCvoxiMpKNEaTz4Z+i3625ZVU0ruC5YSPDu7yK+0mW9zQX8EJQ VMT/b94sHbRKA==
Date: Wed, 20 Sep 2023 13:13:16 +0200
X-Soverin-Authenticated: true
From: Martin Hoffmann <martin@nlnetlabs.nl>
To: Job Snijders <job=40fastly.com@dmarc.ietf.org>
Cc: Warren Kumari <warren@kumari.net>, SIDR Operations WG <sidrops@ietf.org>, draft-ietf-sidrops-rfc6482bis@ietf.org
Message-ID: <20230920131316.080d60b0@glaurung.nlnetlabs.nl>
In-Reply-To: <ZQrNn4mgpA9vJijj@snel>
References: <CAHw9_iKi5FLrrPW2GX0SJLgWq2g802r0JcsFsbgeYnYxfOigVg@mail.gmail.com> <CAMFGGcALstVA=04kZqoVAZanAKDa0rke=QYOyv2LNsWevLWgqg@mail.gmail.com> <CAHw9_iJJwx3R9AiBcmnST7qtdmSM_WMAtVur2RXH=dsZkFscOg@mail.gmail.com> <ZQrNn4mgpA9vJijj@snel>
Organization: NLnet Labs
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: <https://mailarchive.ietf.org/arch/msg/sidrops/XLm8s1X2uPxQjVSYAIyyo7WSUX0>
Subject: Re: [Sidrops] AD Review of: draft-ietf-sidrops-rfc6482bis - "A Profile for Route Origin Authorizations (ROAs)"
X-BeenThere: sidrops@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: A list for the SIDR Operations WG <sidrops.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/sidrops>, <mailto:sidrops-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/sidrops/>
List-Post: <mailto:sidrops@ietf.org>
List-Help: <mailto:sidrops-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/sidrops>, <mailto:sidrops-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 20 Sep 2023 11:13:26 -0000

Job Snijders wrote:
> On Sun, Sep 17, 2023 at 10:10:22AM -0700, Warren Kumari wrote:
> > How about, at the end of "5.  ROA Validation", at the end of:
> > "Before a relying party can use a ROA to validate a routing
> > announcement, the relying party MUST first validate the ROA.  To
> > validate a ROA, the relying party MUST perform all the validation
> > checks specified in [RFC6488] as well as the following additional
> > ROA-specific validation steps." you add: "If any of these
> > constraints fail, the profile is deemed corrupt, and the entire ROA
> > should be discarded (probably after reporting an error)." or
> > similar.  
> 
> Thank you for the suggestion, how about the following?
> 
> https://github.com/job/draft-rfc6482bis/commit/25f14dd674625a4ac526dfcfef26f7345bd10cc1

I think it still needs to be specified in the validation section
(because that section claims to exhaustively list all condition for a
valid ROA) that if any of the requirements given in the Content Type
section is not met, validation fails.

This is not obvious to someone with a background in IETF protocols,
who would rather be inclined to salvage what’s usable.

 -- Martin