Re: [Sidrops] I-D Action: draft-ietf-sidrops-rpki-prefixlist-01.txt
Russ Housley <housley@vigilsec.com> Thu, 25 January 2024 14:32 UTC
Return-Path: <housley@vigilsec.com>
X-Original-To: sidrops@ietfa.amsl.com
Delivered-To: sidrops@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id ABA99C14F6BF for <sidrops@ietfa.amsl.com>; Thu, 25 Jan 2024 06:32:22 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.91
X-Spam-Level:
X-Spam-Status: No, score=-1.91 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id i9TIjz4LYvrj for <sidrops@ietfa.amsl.com>; Thu, 25 Jan 2024 06:32:20 -0800 (PST)
Received: from mail3.g24.pair.com (mail3.g24.pair.com [66.39.134.11]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 99846C14F6BE for <sidrops@ietf.org>; Thu, 25 Jan 2024 06:32:20 -0800 (PST)
Received: from mail3.g24.pair.com (localhost [127.0.0.1]) by mail3.g24.pair.com (Postfix) with ESMTP id F0A1E1B22C7; Thu, 25 Jan 2024 09:32:19 -0500 (EST)
Received: from smtpclient.apple (unknown [96.241.2.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail3.g24.pair.com (Postfix) with ESMTPSA id E2A041B240B; Thu, 25 Jan 2024 09:32:19 -0500 (EST)
Content-Type: text/plain; charset="us-ascii"
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.700.6\))
From: Russ Housley <housley@vigilsec.com>
In-Reply-To: <ZbGLJ1hmpoz_XTAg@snel>
Date: Thu, 25 Jan 2024 09:32:09 -0500
Cc: sidrops <sidrops@ietf.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <9BB525E7-0797-4827-B36F-0E17AC002270@vigilsec.com>
References: <170612503890.46313.7195737912432658695@ietfa.amsl.com> <2360628E-B1CF-47B0-B5D9-AC81954F147F@vigilsec.com> <ZbGLJ1hmpoz_XTAg@snel>
To: Job Snijders <job@fastly.com>
X-Mailer: Apple Mail (2.3731.700.6)
X-Scanned-By: mailmunge 3.11 on 66.39.134.11
Archived-At: <https://mailarchive.ietf.org/arch/msg/sidrops/aNyBh3E9x1lTuXhcnMPL5pt2IAY>
Subject: Re: [Sidrops] I-D Action: draft-ietf-sidrops-rpki-prefixlist-01.txt
X-BeenThere: sidrops@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: A list for the SIDR Operations WG <sidrops.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/sidrops>, <mailto:sidrops-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/sidrops/>
List-Post: <mailto:sidrops@ietf.org>
List-Help: <mailto:sidrops-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/sidrops>, <mailto:sidrops-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 25 Jan 2024 14:32:22 -0000
Job:
> Thanks for the review.
>
> On Wed, Jan 24, 2024 at 04:07:06PM -0500, Russ Housley wrote:
>> I am confused by this change in the syntax:
>>
>> IPv4Prefixes ::= SEQUENCE (SIZE(1..MAX)) OF AddressPrefix{32}
>> IPv6Prefixes ::= SEQUENCE (SIZE(1..MAX)) OF AddressPrefix{128}
>>
>> AddressPrefix {INTEGER: len} ::= BIT STRING (SIZE(0..len))
>>
>> What does it mean when the prefix is a zero length BIT STRING?
>
> That would be 0.0.0.0/0 or ::/0, right?
>
> As I understand it a BIT STRING value can have any length, including
> zero. Same approach is used in draft-ietf-sidrops-rfc6482bis.
I was trying to figure out where rpki-prefixlist would use 0.0.0.0/0 or ::/0.
>> Nit: you might want to change len to maxlen to make it clear that it
>> is a bound, not the actual length of the prefix.
>
> How about this?
> https://github.com/job/draft-sidrops-rpki-prefixlist/commit/4397b06cdb277b4f1774d66af1d0bd53d83182c0
Even better. Thanks.
Russ
- [Sidrops] I-D Action: draft-ietf-sidrops-rpki-pre… internet-drafts
- Re: [Sidrops] I-D Action: draft-ietf-sidrops-rpki… Russ Housley
- Re: [Sidrops] I-D Action: draft-ietf-sidrops-rpki… Job Snijders
- Re: [Sidrops] I-D Action: draft-ietf-sidrops-rpki… Russ Housley
- Re: [Sidrops] I-D Action: draft-ietf-sidrops-rpki… Job Snijders