Re: [Sidrops] Opsdir last call review of draft-ietf-sidrops-bgpsec-algs-rfc8208-bis-04

"Borchert, Oliver (Fed)" <oliver.borchert@nist.gov> Thu, 11 April 2019 21:09 UTC

Return-Path: <oliver.borchert@nist.gov>
X-Original-To: sidrops@ietfa.amsl.com
Delivered-To: sidrops@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id AA4C3120751; Thu, 11 Apr 2019 14:09:40 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.001
X-Spam-Level:
X-Spam-Status: No, score=-2.001 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=nist.gov
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ItiUOCCNNtBk; Thu, 11 Apr 2019 14:09:38 -0700 (PDT)
Received: from GCC01-CY1-obe.outbound.protection.outlook.com (mail-eopbgr830102.outbound.protection.outlook.com [40.107.83.102]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 5E39C120384; Thu, 11 Apr 2019 14:09:38 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nist.gov; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/VeSC81Lkt4rKJu36qx5LNR83Q557gLIDP9xpVgQiw8=; b=PVd4tv5tGZWqDKl4Q6c3xdad2XbbdcpoL3Z/WODsOd6n4AbMDP8XwThENEGXExOtrJavzF2JgKfV4S7gOtfdGADl/wJVe3HZzSRPARk3Ve1Lt9Tr0FN2ucnDUJFAsc6yM8MxSFireg7qDazOGTqEuB9Duj9Yki8Y4HZjoFyw4TA=
Received: from SN6PR09MB3167.namprd09.prod.outlook.com (20.177.250.204) by SN6PR09MB3166.namprd09.prod.outlook.com (20.177.250.203) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1792.14; Thu, 11 Apr 2019 21:09:36 +0000
Received: from SN6PR09MB3167.namprd09.prod.outlook.com ([fe80::694c:8a72:b9a7:5832]) by SN6PR09MB3167.namprd09.prod.outlook.com ([fe80::694c:8a72:b9a7:5832%2]) with mapi id 15.20.1771.021; Thu, 11 Apr 2019 21:09:36 +0000
From: "Borchert, Oliver (Fed)" <oliver.borchert@nist.gov>
To: Mehmet Ersue <mersue@gmail.com>, "ops-dir@ietf.org" <ops-dir@ietf.org>
CC: "sidrops@ietf.org" <sidrops@ietf.org>, "ietf@ietf.org" <ietf@ietf.org>, "draft-ietf-sidrops-bgpsec-algs-rfc8208-bis.all@ietf.org" <draft-ietf-sidrops-bgpsec-algs-rfc8208-bis.all@ietf.org>
Thread-Topic: Opsdir last call review of draft-ietf-sidrops-bgpsec-algs-rfc8208-bis-04
Thread-Index: AQHU3XJwhFhuItnwVUWWyb34eg0i0KY3lwkA
Date: Thu, 11 Apr 2019 21:09:36 +0000
Message-ID: <SN6PR09MB3167537C5CF4C74D4BF3F3E4982F0@SN6PR09MB3167.namprd09.prod.outlook.com>
References: <155290366133.26147.15826331095937544086@ietfa.amsl.com>
In-Reply-To: <155290366133.26147.15826331095937544086@ietfa.amsl.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: spf=none (sender IP is ) smtp.mailfrom=oliver.borchert@nist.gov;
x-originating-ip: [129.6.140.119]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 2d4422ce-64ef-400e-6d53-08d6bec200f7
x-ms-office365-filtering-ht: Tenant
x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600139)(711020)(4605104)(4618075)(2017052603328)(7193020); SRVR:SN6PR09MB3166;
x-ms-traffictypediagnostic: SN6PR09MB3166:
x-ms-exchange-purlcount: 2
x-microsoft-antispam-prvs: <SN6PR09MB31663D56FC4B0F8DED6E1660982F0@SN6PR09MB3166.namprd09.prod.outlook.com>
x-forefront-prvs: 00046D390F
x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(39860400002)(376002)(366004)(346002)(396003)(136003)(13464003)(189003)(199004)(81166006)(7696005)(305945005)(966005)(7736002)(6116002)(68736007)(106356001)(478600001)(74316002)(105586002)(53936002)(8936002)(3846002)(26005)(53546011)(86362001)(6436002)(2906002)(186003)(97736004)(76176011)(6506007)(14454004)(9686003)(4326008)(6306002)(102836004)(8676002)(33656002)(71200400001)(52536014)(316002)(5660300002)(71190400001)(99286004)(229853002)(55016002)(81156014)(54906003)(110136005)(66066001)(2501003)(256004)(476003)(446003)(45080400002)(6246003)(11346002)(486006)(25786009); DIR:OUT; SFP:1102; SCL:1; SRVR:SN6PR09MB3166; H:SN6PR09MB3167.namprd09.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1;
received-spf: None (protection.outlook.com: nist.gov does not designate permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam-message-info: vRk8vrkw+hcZJsjirazZOcJDGTr8a93rGJGSoCQDjk5l5PZITx5Z7H93C7HB31GbS1LtxL4u7k4OGCCV4KCf3LE34tQ+IfGCPAf7eHOBzoTONvIhEM/END24NH2jMGZYXtZ2p4PUQ+MbaWN/tnt8DFUYaObafpGK0mlfsKooSvFIWnSJzEiSAG1Lx5Erhm5gY/3P3Rc2il0u6elm62kLkfkNp8isBgkzk1dowbW2I5gh//2eMn2sVNCMBfs/8+v0mIzq3AJUC+I+V2OTrU56KZUi7xljPQcFyN2fX0SVUsd5oZWxeHMFzPHrF+TaWXH0dTg3LyrXKORFdiJaMvJnM8QCWm0XAA39rZ3KN7/PWNoQhEF/edJbGmy43pvgrW8AaxuFJLUxVZFDjkUqFxE89C+UZ9dw1JCIlnmOZr+K9Vs=
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: nist.gov
X-MS-Exchange-CrossTenant-Network-Message-Id: 2d4422ce-64ef-400e-6d53-08d6bec200f7
X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Apr 2019 21:09:36.6530 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 2ab5d82f-d8fa-4797-a93e-054655c61dec
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR09MB3166
Archived-At: <https://mailarchive.ietf.org/arch/msg/sidrops/pEJQrBF9svdxQYHlDD9HlJ6uPZg>
Subject: Re: [Sidrops] Opsdir last call review of draft-ietf-sidrops-bgpsec-algs-rfc8208-bis-04
X-BeenThere: sidrops@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: A list for the SIDR Operations WG <sidrops.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/sidrops>, <mailto:sidrops-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/sidrops/>
List-Post: <mailto:sidrops@ietf.org>
List-Help: <mailto:sidrops-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/sidrops>, <mailto:sidrops-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 11 Apr 2019 21:09:45 -0000

Hi Mehmet,

Regarding:
  Checking nits according to https://www.ietf.org/id-info/checklist :
  ----------------------------------------------------------------------------

  == There are 1 instance of lines with non-RFC3849-compliant IPv6 addresses
     in the document.  If these are example addresses, they should be changed.

I modified the NextHop IPv6 Address in the example from a routable IPv6 address to use 
a private use IPv6 address instead.
With this the signatures in the example are all still valid because it is not signed over it.

Oliver




-----Original Message-----
From: Mehmet Ersue via Datatracker <noreply@ietf.org> 
Sent: Monday, March 18, 2019 6:08 AM
To: ops-dir@ietf.org
Cc: sidrops@ietf.org; ietf@ietf.org; draft-ietf-sidrops-bgpsec-algs-rfc8208-bis.all@ietf.org
Subject: Opsdir last call review of draft-ietf-sidrops-bgpsec-algs-rfc8208-bis-04
Importance: High

Reviewer: Mehmet Ersue
Review result: Has Nits

I reviewed the document "BGPsec Algorithms, Key Formats, and Signature Formats"
(draft-ietf-sidrops-bgpsec-algs-rfc8208-bis-04.txt) as part of the Operational directorate's ongoing effort to review all IETF documents being processed by the IESG. These comments were written primarily for the benefit of the operational area directors.  Document editors and WG chairs should treat these comments just like any other last call comments.

Intended status: Standards Track
Current IESG state: Waiting for Writeup
IANA State: IANA - Review Needed

Summary:
The document specifies the algorithms, algorithm parameters, asymmetric key formats, asymmetric key sizes, and signature formats used in BGPsec.  The document updates RFC 8208 ("BGPsec Algorithms, Key Formats, and Signature
Formats") by adding Special-Use Algorithm IDs and correcting the range of unassigned algorithms IDs to fill the complete range.

There are some nits in the document like
- Normative reference to an Informational RFCs and
- Non-RFC (?) normative references
See
https://gcc01.safelinks.protection.outlook.com/?url=https%3A%2F%2Ftools.ietf.org%2Fidnits%3Furl%3Dhttps%3A%2F%2Ftools.ietf.org%2Fid%2Fdraft-ietf-sidrops-bgpsec-algs-rfc8208-bis-04.txt&amp;data=02%7C01%7Coliver.borchert%40nist.gov%7Ce1415efaec2e40da074008d6ab899186%7C2ab5d82fd8fa4797a93e054655c61dec%7C1%7C0%7C636885004677850528&amp;sdata=HlpFKh1FEljT04PW6aIeQS7Fe7%2B%2FovL2fpKIlYC4pPI%3D&amp;reserved=0

As far as I can tell the document does not cause any issues related to operations and management.

Mehmet