Re: Include 04 export/import

Cyrus Daboo <cyrus@daboo.name> Thu, 15 June 2006 00:32 UTC

Received: from balder-227.proper.com (localhost [127.0.0.1]) by balder-227.proper.com (8.13.5/8.13.5) with ESMTP id k5F0WQE0009398; Wed, 14 Jun 2006 17:32:26 -0700 (MST) (envelope-from owner-ietf-mta-filters@mail.imc.org)
Received: (from majordom@localhost) by balder-227.proper.com (8.13.5/8.13.5/Submit) id k5F0WQXj009397; Wed, 14 Jun 2006 17:32:26 -0700 (MST) (envelope-from owner-ietf-mta-filters@mail.imc.org)
X-Authentication-Warning: balder-227.proper.com: majordom set sender to owner-ietf-mta-filters@mail.imc.org using -f
Received: from out4.smtp.messagingengine.com (out4.smtp.messagingengine.com [66.111.4.28]) by balder-227.proper.com (8.13.5/8.13.5) with ESMTP id k5F0WQJ3009390 for <ietf-mta-filters@imc.org>; Wed, 14 Jun 2006 17:32:26 -0700 (MST) (envelope-from cyrus@daboo.name)
Received: from frontend3.internal (frontend3.internal [10.202.2.152]) by frontend1.messagingengine.com (Postfix) with ESMTP id 8B16CD6C57F; Wed, 14 Jun 2006 20:32:24 -0400 (EDT)
Received: from heartbeat2.messagingengine.com ([10.202.2.161]) by frontend3.internal (MEProxy); Wed, 14 Jun 2006 20:32:28 -0400
X-Sasl-enc: 2XYqX2gqhuecLpq0CJuFDcJ9wgQ7k+axGJA3q+z8VuFT 1150331548
Received: from [10.0.1.4] (static-71-240-120-213.pitt.east.verizon.net [71.240.120.213]) by www.fastmail.fm (Postfix) with ESMTP id A7D0D1250; Wed, 14 Jun 2006 20:32:24 -0400 (EDT)
Date: Wed, 14 Jun 2006 20:32:26 -0400
From: Cyrus Daboo <cyrus@daboo.name>
To: Kjetil Torgrim Homme <kjetilho@ifi.uio.no>, Aaron Stone <aaron@serendipity.cx>
cc: ietf-mta-filters <ietf-mta-filters@imc.org>
Subject: Re: Include 04 export/import
Message-ID: <49770033B243A96140CFB8E5@ninevah.local>
In-Reply-To: <1150323154.16538.34.camel@mattugur.ifi.uio.no>
References: <1150302510.17583.122.camel@localhost> <1150323154.16538.34.camel@mattugur.ifi.uio.no>
X-Mailer: Mulberry/4.0.5 (Mac OS X)
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; format="flowed"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Sender: owner-ietf-mta-filters@mail.imc.org
Precedence: bulk
List-Archive: <http://www.imc.org/ietf-mta-filters/mail-archive/>
List-ID: <ietf-mta-filters.imc.org>
List-Unsubscribe: <mailto:ietf-mta-filters-request@imc.org?body=unsubscribe>

Hi Kjetil,

--On June 15, 2006 12:12:33 AM +0200 Kjetil Torgrim Homme 
<kjetilho@ifi.uio.no> wrote:

> I agree.
>
>    If an "import" command lists a variable that has not been exported
>    and set by any other script at that point during the SIEVE execution
>    process, then an error MUST occur.
>
> I suggest that "and set" is removed.  remember that changes made to the
> imported variable will be visible in the parent.  this is how values are
> returned from "calling" sub-scripts, and it would be strange to require
> the parent to set it prior to the call.  this should probably made clear
> in the draft.

OK, that makes sense and I will update the draft accordingly. However, one 
questions: what should happen if an "export" command references a variable 
not defined in the remainder of the script? I don't think I called out that 
case explicitly. Should that be an error, or should it be allowed?

> another issue -- the examples say:
>
>     |   require ["variables", "include"];
>     |   export ${test}
>
> further up it says the argument is a string list, so it would have to be
>
>     export "${test}";
>
> I would prefer that the variable name was used unadorned, however, as I
> would expect ${test} to be expanded to the value, no matter how
> nonsensical that is...  so:
>
>     export "test";
>
> it should also be made clear that the strings in the list need to be
> constant strings, ie. without ${variable} references.

OK, I will fix the examples as you suggest.

-- 
Cyrus Daboo