Re: [sieve] Fwd: New Version Notification for draft-bosch-sieve-duplicate-01.txt

Stephan Bosch <stephan@rename-it.nl> Thu, 21 March 2013 12:06 UTC

Return-Path: <stephan@rename-it.nl>
X-Original-To: sieve@ietfa.amsl.com
Delivered-To: sieve@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 622D821F8E1C for <sieve@ietfa.amsl.com>; Thu, 21 Mar 2013 05:06:19 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -0.504
X-Spam-Level:
X-Spam-Status: No, score=-0.504 tagged_above=-999 required=5 tests=[BAYES_00=-2.599, HELO_EQ_NL=0.55, HOST_EQ_NL=1.545]
Received: from mail.ietf.org ([12.22.58.30]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id eYjmWx6bmsnT for <sieve@ietfa.amsl.com>; Thu, 21 Mar 2013 05:06:18 -0700 (PDT)
Received: from drpepper.rename-it.nl (drpepper.rename-it.nl [217.119.238.16]) by ietfa.amsl.com (Postfix) with ESMTP id 8F72621F8E10 for <sieve@ietf.org>; Thu, 21 Mar 2013 05:06:17 -0700 (PDT)
Received: from [217.119.239.130] (port=57490 helo=[192.168.1.109]) by drpepper.rename-it.nl with esmtpsa (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.72) (envelope-from <stephan@rename-it.nl>) id 1UIeG0-0007r6-Kn; Thu, 21 Mar 2013 13:06:15 +0100
Message-ID: <514AF7A9.3040502@rename-it.nl>
Date: Thu, 21 Mar 2013 13:06:01 +0100
From: Stephan Bosch <stephan@rename-it.nl>
User-Agent: Mozilla/5.0 (Windows NT 6.0; rv:17.0) Gecko/20130307 Thunderbird/17.0.4
MIME-Version: 1.0
To: Ned Freed <ned.freed@mrochek.com>
References: <20130210000420.4778.87812.idtracker@ietfa.amsl.com> <5116E5ED.20307@rename-it.nl> <513B1839.3050202@rename-it.nl> <01ORB1SUSLYS000054@mauve.mrochek.com>
In-Reply-To: <01ORB1SUSLYS000054@mauve.mrochek.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-RenameIT-MailScanner-SpamScore: -2.3 (--)
X-RenameIT-MailScanner-SpamCheck: No, score=-2.3 required=5.0 tests=ALL_TRUSTED, BAYES_00 autolearn=ham version=3.3.1
Cc: Sieve mailing list <sieve@ietf.org>
Subject: Re: [sieve] Fwd: New Version Notification for draft-bosch-sieve-duplicate-01.txt
X-BeenThere: sieve@ietf.org
X-Mailman-Version: 2.1.12
Precedence: list
List-Id: SIEVE Working Group <sieve.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/sieve>, <mailto:sieve-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/sieve>
List-Post: <mailto:sieve@ietf.org>
List-Help: <mailto:sieve-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/sieve>, <mailto:sieve-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 21 Mar 2013 12:06:19 -0000

Hi Ned,

Op 3/15/2013 6:39 PM, Ned Freed wrote:
>> Any thoughts about this?
>
> Sorry to take so long to respond; I finally managed to complete my
> implementation yesterday.
>
> In implementing this, I saw nothing about the semantics of the test I 
> would
> like to see changed. I really like the clever way the single word 
> "duplicate"
> ends up doing the right thing in most cases.
>
> The draft also seems pretty complete, although a couple of clarifications
> are needed:
>
> (0) A clear execution model is really important here. In particular, 
> the way
>    this has to be implemented is that during sieve execution queries
>    whatever back end database you're using but does *not* update it.
>    Only after the sieve has been evalauted without error and the actions
>    it specified have been perform should the database be updated.

Ok, I'll improve that a bit.

>    I note that the same applies in environments that support multiple 
> sieves -
>    you evaluate them all, apply the results, and for the subset of sieves
>    that evaluated without error, perform the updates. I'll also note 
>    that how duplicate tests in multiple scripts interact is tricky. I
>    eventually decided to qualify duplicate with the sieve "owner", which
>    then acts like another handle.
>
>    I don't see any reason to get into the multiple scripts bit in the 
> draft;
>    I'm just noting it in case someone is interested.

Agreed. Perhaps when someone finishes the multiscript draft at some 
point, it could be mentioned there.

> (1) The draft says nothing about what happens when the specified header
>    field does not exist. The test should fail unconditionally in this 
> case.

Agreed.

> (2) The draft says nothing about what happens when there are more than 
> one
>    of the specified fields present. It should say that the first one
>    that is found is used.

Yes, good catch. This is what my current implementation does too.

> (3) The draft probably should say that duplicate does not support 
> either the
>    index or mime extensions directly (:index, :mime:, and :anychild), and
>    that if you want to perform such checks you can do them with variables
>    and :value.

Yes, always good to give hints in the right direction.

> And finally, a few nits:
>
> (1) The "MUST throw a compile time error if both :header and :value are
>    specified" is a bit strong. For one thing, such a check is 
> inappropriate
>    if ihave is in effect. And for another, while I was able to implement
>    it, it may not be convenient for all implementations to perform this
>    check at compile time.

I'm not sure what you mean here. Do you want me to make the kind of 
error more open, e.g. by adopting the wording used for the :zone and 
:originalzone arguments for the date extension?

`It is an error to specify both :zone and :originalzone.'

Which basically leaves the kind of error up to the implementer. I have no problem with that.

> (2) I'm wondering if it wouldn't be best to suggest a default timeout.
>    12 hours? A day?

It can be useful. Anyone else got suggestions or comments about this?

> (3) A MUST be case-sensitive is probably a good idea, perhaps with a note
>    as to how you can use the set action to muck around with case.

Yes, otherwise users could get surprised at some point.

> That's it! Thanks for producing such a good draft!

Thanks. I'll make a new version some time next week.

Regards,

Stephan.