Re: [sieve] Fwd: New Version Notification for draft-bosch-sieve-duplicate-01.txt

NED+mta-filters@mauve.mrochek.com Fri, 15 March 2013 18:23 UTC

Return-Path: <NED+mta-filters@mauve.mrochek.com>
X-Original-To: sieve@ietfa.amsl.com
Delivered-To: sieve@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 9F3DE21F84E9 for <sieve@ietfa.amsl.com>; Fri, 15 Mar 2013 11:23:42 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.599
X-Spam-Level:
X-Spam-Status: No, score=-2.599 tagged_above=-999 required=5 tests=[BAYES_00=-2.599]
Received: from mail.ietf.org ([12.22.58.30]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 8wo4V6VMSFtS for <sieve@ietfa.amsl.com>; Fri, 15 Mar 2013 11:23:41 -0700 (PDT)
Received: from mauve.mrochek.com (mauve.mrochek.com [66.59.230.40]) by ietfa.amsl.com (Postfix) with ESMTP id CFE1321F84DF for <sieve@ietf.org>; Fri, 15 Mar 2013 11:23:41 -0700 (PDT)
Received: from dkim-sign.mauve.mrochek.com by mauve.mrochek.com (PMDF V6.1-1 #35243) id <01ORB1SW3CCW001GEA@mauve.mrochek.com> for sieve@ietf.org; Fri, 15 Mar 2013 11:18:40 -0700 (PDT)
MIME-version: 1.0
Content-type: TEXT/PLAIN; CHARSET=iso-8859-1; Format=flowed
Received: from mauve.mrochek.com by mauve.mrochek.com (PMDF V6.1-1 #35243) id <01OQTDV5JHPC000054@mauve.mrochek.com> (original mail from NED@mauve.mrochek.com) for sieve@ietf.org; Fri, 15 Mar 2013 11:18:38 -0700 (PDT)
From: NED+mta-filters@mauve.mrochek.com
Message-id: <01ORB1SUSLYS000054@mauve.mrochek.com>
Date: Fri, 15 Mar 2013 10:39:36 -0700 (PDT)
In-reply-to: "Your message dated Sat, 09 Mar 2013 12:08:41 +0100" <513B1839.3050202@rename-it.nl>
References: <20130210000420.4778.87812.idtracker@ietfa.amsl.com> <5116E5ED.20307@rename-it.nl> <513B1839.3050202@rename-it.nl>
To: Stephan Bosch <stephan@rename-it.nl>
Cc: Sieve mailing list <sieve@ietf.org>
Subject: Re: [sieve] Fwd: New Version Notification for draft-bosch-sieve-duplicate-01.txt
X-BeenThere: sieve@ietf.org
X-Mailman-Version: 2.1.12
Precedence: list
List-Id: SIEVE Working Group <sieve.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/sieve>, <mailto:sieve-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/sieve>
List-Post: <mailto:sieve@ietf.org>
List-Help: <mailto:sieve-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/sieve>, <mailto:sieve-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 15 Mar 2013 18:23:42 -0000

> Any thoughts about this?

Sorry to take so long to respond; I finally managed to complete my
implementation yesterday.

In implementing this, I saw nothing about the semantics of the test I would
like to see changed. I really like the clever way the single word "duplicate"
ends up doing the right thing in most cases.

The draft also seems pretty complete, although a couple of clarifications
are needed:

(0) A clear execution model is really important here. In particular, the way
    this has to be implemented is that during sieve execution queries
    whatever back end database you're using but does *not* update it.
    Only after the sieve has been evalauted without error and the actions
    it specified have been perform should the database be updated.

    I note that the same applies in environments that support multiple sieves -
    you evaluate them all, apply the results, and for the subset of sieves
    that evaluated without error, perform the updates. I'll also note 
    that how duplicate tests in multiple scripts interact is tricky. I
    eventually decided to qualify duplicate with the sieve "owner", which
    then acts like another handle.

    I don't see any reason to get into the multiple scripts bit in the draft;
    I'm just noting it in case someone is interested.

(1) The draft says nothing about what happens when the specified header
    field does not exist. The test should fail unconditionally in this case.

(2) The draft says nothing about what happens when there are more than one
    of the specified fields present. It should say that the first one
    that is found is used.

(3) The draft probably should say that duplicate does not support either the
    index or mime extensions directly (:index, :mime:, and :anychild), and
    that if you want to perform such checks you can do them with variables
    and :value.

And finally, a few nits:

(1) The "MUST throw a compile time error if both :header and :value are
    specified" is a bit strong. For one thing, such a check is inappropriate
    if ihave is in effect. And for another, while I was able to implement
    it, it may not be convenient for all implementations to perform this
    check at compile time.

(2) I'm wondering if it wouldn't be best to suggest a default timeout.
    12 hours? A day?

(3) A MUST be case-sensitive is probably a good idea, perhaps with a note
    as to how you can use the set action to muck around with case.

That's it! Thanks for producing such a good draft!

				Ned