Re: Working Group Last Call: draft-ietf-sieve-3431bis-01.txt (relational test)

Cyrus Daboo <daboo@isamet.com> Tue, 20 September 2005 16:23 UTC

Received: from above.proper.com (localhost.vpnc.org [127.0.0.1]) by above.proper.com (8.12.11/8.12.9) with ESMTP id j8KGN4P3069156; Tue, 20 Sep 2005 09:23:04 -0700 (PDT) (envelope-from owner-ietf-mta-filters@mail.imc.org)
Received: (from majordom@localhost) by above.proper.com (8.12.11/8.12.9/Submit) id j8KGN4vQ069155; Tue, 20 Sep 2005 09:23:04 -0700 (PDT)
X-Authentication-Warning: above.proper.com: majordom set sender to owner-ietf-mta-filters@mail.imc.org using -f
Received: from darius.cyrusoft.com (darius.cyrusoft.com [63.163.82.2]) by above.proper.com (8.12.11/8.12.9) with ESMTP id j8KGN3vq069148 for <ietf-mta-filters@imc.org>; Tue, 20 Sep 2005 09:23:03 -0700 (PDT) (envelope-from daboo@isamet.com)
Received: from ninevah.cyrusoft.com (ninevah.cyrusoft.com [63.163.82.9]) (authenticated bits=0) by darius.cyrusoft.com (8.12.9/8.12.9) with ESMTP id j8KGLKuG003504 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for <ietf-mta-filters@imc.org>; Tue, 20 Sep 2005 12:21:20 -0400
Date: Tue, 20 Sep 2005 12:23:01 -0400
From: Cyrus Daboo <daboo@isamet.com>
To: MTA filtering mailing list <ietf-mta-filters@imc.org>
Subject: Re: Working Group Last Call: draft-ietf-sieve-3431bis-01.txt (relational test)
Message-ID: <96D266F8F31EB00262C348D6@ninevah.cyrusoft.com>
In-Reply-To: <431D6F44.6060409@isode.com>
References: <431D6F44.6060409@isode.com>
X-Mailer: Mulberry/4.0.3 (Mac OS X)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"; format="flowed"
Content-Disposition: inline
X-Spam-Status: No, hits=1.0 tests=SUBJ_HAS_SPACES
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from quoted-printable to 8bit by above.proper.com id j8KGN4vq069150
Sender: owner-ietf-mta-filters@mail.imc.org
Precedence: bulk
List-Archive: <http://www.imc.org/ietf-mta-filters/mail-archive/>
List-ID: <ietf-mta-filters.imc.org>
List-Unsubscribe: <mailto:ietf-mta-filters-request@imc.org?body=unsubscribe>

My 3431bis comments:

--
§2 ¶1

Change:

   MUST be declared a require clause as defined in [SIEVE].

To:

   MUST be declared in a require clause as defined in [SIEVE].

                    ^^

--
§2 and elsewhere: change [ACAP] reference to i18n document.

--

Various places: 'syntax' -> 'usage'

--
§3 perhaps there ought to be an informative reference to 'C', or at least 
define it somewhere as 'the C programming language'.

--
§3.2

The phrase 'number of recipients' is not strictly right as From addresses 
can be tested and that is not a 'recipient'.

Exactly what are we talking about here? The number of 'addr-spec' elements 
as defined by 2822?

Also, I am not sure about the comment on groups. A group can have a list of 
email addresses included - do those get counted or not? It would be useful 
to have an example illustrating this if its not clear. Perhaps text should 
be:

	Group names are ignored, but the list of addresses in a group,
	if provided, are counted.

--
§3.2 ¶6

Change:

	comparing the total number of "to" and "cc" addresses;

To:

	compares the total number of "to" and "cc" addresses;
	
	      ^^

--
Examples: all of the examples use [...] around single string-list items, 
which is not strictly necessary. I always prefer to see the most 'compact' 
syntax representation where ever possible. This is just a personal 
preference.

--
§5 Examples:

Change:

	elseif

To:

	elsif

--

§5: the 'if allof' statement is missing a closing right-paren.

--

§5: 'fileinto' needs to be in the 'require' statement.


--
§8: update SIEVE reference to 3028bis.


-- 
Cyrus Daboo