Re: [sip-clf] WG Last Call: draft-ietf-sipclf-format-03

Peter Musgrave <musgravepj@gmail.com> Wed, 07 December 2011 15:03 UTC

Return-Path: <musgravepj@gmail.com>
X-Original-To: sip-clf@ietfa.amsl.com
Delivered-To: sip-clf@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id AFBA521F8C2A for <sip-clf@ietfa.amsl.com>; Wed, 7 Dec 2011 07:03:09 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3.599
X-Spam-Level:
X-Spam-Status: No, score=-3.599 tagged_above=-999 required=5 tests=[BAYES_00=-2.599, RCVD_IN_DNSWL_LOW=-1]
Received: from mail.ietf.org ([12.22.58.30]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id hRLdvg1RryAk for <sip-clf@ietfa.amsl.com>; Wed, 7 Dec 2011 07:03:09 -0800 (PST)
Received: from mail-vw0-f44.google.com (mail-vw0-f44.google.com [209.85.212.44]) by ietfa.amsl.com (Postfix) with ESMTP id 226BA21F8C15 for <sip-clf@ietf.org>; Wed, 7 Dec 2011 07:03:04 -0800 (PST)
Received: by vbbez10 with SMTP id ez10so529109vbb.31 for <sip-clf@ietf.org>; Wed, 07 Dec 2011 07:03:04 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=subject:mime-version:content-type:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to:x-mailer; bh=aJ/tOmLJqsvlHSkiqG0QmmaofnfhHoappS+cQVEZM/Q=; b=A13KfShI2zcDc7LJ61ZJ5aZ2hCAN8lu3wbdBK8Ma7AFRdUUFjqR05vzYOHkvDhf39o HurVxPl4GhgtksFh+v5+FNxWZvz86q8LdrprOXcRLvB4bRxqAvzmADScNrm/9eyuza3E td1UM89pIFNO0PenPpKj4Rdu/L47Qha9qYtik=
Received: by 10.52.34.78 with SMTP id x14mr10809070vdi.122.1323270184442; Wed, 07 Dec 2011 07:03:04 -0800 (PST)
Received: from [192.168.1.109] ([204.237.37.240]) by mx.google.com with ESMTPS id ir2sm1460608vdb.9.2011.12.07.07.03.02 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 07 Dec 2011 07:03:03 -0800 (PST)
Mime-Version: 1.0 (Apple Message framework v1084)
Content-Type: text/plain; charset=us-ascii
From: Peter Musgrave <musgravepj@gmail.com>
In-Reply-To: <6B7FE711-B51A-4166-90A2-E9ADE5DB2982@gmail.com>
Date: Wed, 7 Dec 2011 10:03:01 -0500
Content-Transfer-Encoding: quoted-printable
Message-Id: <0E0AFFE0-29A3-4B24-8FB0-443ECA3BCE4C@gmail.com>
References: <6B7FE711-B51A-4166-90A2-E9ADE5DB2982@gmail.com>
To: Gonzalo Salgueiro <gsalguei@cisco.com>
X-Mailer: Apple Mail (2.1084)
Cc: sip-clf@ietf.org
Subject: Re: [sip-clf] WG Last Call: draft-ietf-sipclf-format-03
X-BeenThere: sip-clf@ietf.org
X-Mailman-Version: 2.1.12
Precedence: list
List-Id: SIP Common Log File format discussion list <sip-clf.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/sip-clf>, <mailto:sip-clf-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/sip-clf>
List-Post: <mailto:sip-clf@ietf.org>
List-Help: <mailto:sip-clf-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/sip-clf>, <mailto:sip-clf-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 07 Dec 2011 15:03:09 -0000

Hi Gonzalo, 

Great job on the final version. I have two comments, one picky; one more substantive:


4.2
For the timestamp and fractional seconds the order is most significant character first I assume? Is it worth stating this explicitly?

4.3
The optional fields have a 2 byte hex length indicator. It is stated earlier that hex is to be specified in ASCII characters. This limits the size of an optional value to 255 bytes - which I suspect was not the intent.
Does this field need to made large enough to hold 4096 byte lengths?

Thanks

Peter

On 2011-12-07, at 9:41 AM, Peter Musgrave wrote:

> Hi all, 
> 
> I would like to start a WG last call on the recent (hopefully final) update to the sip-clf format doc. 
> 
> Please provide your comments by Friday Dec. 16th - including just a simple "looks good".
> 
> I would really like to get this WG wrapped up in time for Xmas!
> 
> Regards, 
> 
> Peter Musgrave