Re: [sip-clf] WG Last Call: draft-ietf-sipclf-format-03

[Gonzalo Salgueiro <[e-mail]>]

Peter - 

Thanks for the review. A few comments inline...

On Dec 7, 2011, at 10:03 AM, Peter Musgrave wrote:

> Hi Gonzalo, 
> 
> Great job on the final version. I have two comments, one picky; one more substantive:
> 
> 
> 4.2
> For the timestamp and fractional seconds the order is most significant character first I assume? Is it worth stating this explicitly?
> 
Once we specified that Unix Epoch time is used that this would be understood, but I think a bit of text stating that this explicitly could be helpful. I will add this in the next version.
> 4.3
> The optional fields have a 2 byte hex length indicator. It is stated earlier that hex is to be specified in ASCII characters. This limits the size of an optional value to 255 bytes - which I suspect was not the intent.
> Does this field need to made large enough to hold 4096 byte lengths?
> 
Thanks for spotting this. It was an oversight on my part and this will definitely be addressed in the next version with updated field length of 4 bytes.

Regards,

Gonzalo

> Thanks
> 
> Peter
> 
> On 2011-12-07, at 9:41 AM, Peter Musgrave wrote:
> 
>> Hi all, 
>> 
>> I would like to start a WG last call on the recent (hopefully final) update to the sip-clf format doc. 
>> 
>> Please provide your comments by Friday Dec. 16th - including just a simple "looks good".
>> 
>> I would really like to get this WG wrapped up in time for Xmas!
>> 
>> Regards, 
>> 
>> Peter Musgrave
> 
>