Re: [sip-clf] WG Last Call: draft-ietf-sipclf-format-03

Gonzalo Salgueiro <gsalguei@cisco.com> Wed, 07 December 2011 18:10 UTC

Return-Path: <gsalguei@cisco.com>
X-Original-To: sip-clf@ietfa.amsl.com
Delivered-To: sip-clf@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id D2B0421F8B4E for <sip-clf@ietfa.amsl.com>; Wed, 7 Dec 2011 10:10:40 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -10.598
X-Spam-Level:
X-Spam-Status: No, score=-10.598 tagged_above=-999 required=5 tests=[BAYES_00=-2.599, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_HI=-8]
Received: from mail.ietf.org ([12.22.58.30]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id wlBaeK9icmMJ for <sip-clf@ietfa.amsl.com>; Wed, 7 Dec 2011 10:10:21 -0800 (PST)
Received: from av-tac-rtp.cisco.com (hen.cisco.com [64.102.19.198]) by ietfa.amsl.com (Postfix) with ESMTP id 355FD21F8BCB for <sip-clf@ietf.org>; Wed, 7 Dec 2011 10:10:10 -0800 (PST)
X-TACSUNS: Virus Scanned
Received: from chook.cisco.com (localhost.cisco.com [127.0.0.1]) by av-tac-rtp.cisco.com (8.13.8+Sun/8.13.8) with ESMTP id pB7IA9q9023413 for <sip-clf@ietf.org>; Wed, 7 Dec 2011 13:10:09 -0500 (EST)
Received: from dhcp-64-102-210-155.cisco.com (dhcp-64-102-210-155.cisco.com [64.102.210.155]) by chook.cisco.com (8.13.8+Sun/8.13.8) with ESMTP id pB7IA8UD020725; Wed, 7 Dec 2011 13:10:08 -0500 (EST)
Mime-Version: 1.0 (Apple Message framework v1084)
Content-Type: multipart/alternative; boundary=Apple-Mail-47--770658359
From: Gonzalo Salgueiro <gsalguei@cisco.com>
In-Reply-To: <0E0AFFE0-29A3-4B24-8FB0-443ECA3BCE4C@gmail.com>
Date: Wed, 7 Dec 2011 13:10:08 -0500
Message-Id: <867FAA7E-B3D4-4F53-A7C1-B3088C4CD67F@cisco.com>
References: <6B7FE711-B51A-4166-90A2-E9ADE5DB2982@gmail.com> <0E0AFFE0-29A3-4B24-8FB0-443ECA3BCE4C@gmail.com>
To: Peter Musgrave <musgravepj@gmail.com>
X-Mailer: Apple Mail (2.1084)
Cc: sip-clf@ietf.org
Subject: Re: [sip-clf] WG Last Call: draft-ietf-sipclf-format-03
X-BeenThere: sip-clf@ietf.org
X-Mailman-Version: 2.1.12
Precedence: list
List-Id: SIP Common Log File format discussion list <sip-clf.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/sip-clf>, <mailto:sip-clf-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/sip-clf>
List-Post: <mailto:sip-clf@ietf.org>
List-Help: <mailto:sip-clf-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/sip-clf>, <mailto:sip-clf-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 07 Dec 2011 18:10:41 -0000

Peter - 

Thanks for the review. A few comments inline...

On Dec 7, 2011, at 10:03 AM, Peter Musgrave wrote:

> Hi Gonzalo, 
> 
> Great job on the final version. I have two comments, one picky; one more substantive:
> 
> 
> 4.2
> For the timestamp and fractional seconds the order is most significant character first I assume? Is it worth stating this explicitly?
> 
Once we specified that Unix Epoch time is used that this would be understood, but I think a bit of text stating that this explicitly could be helpful. I will add this in the next version.
> 4.3
> The optional fields have a 2 byte hex length indicator. It is stated earlier that hex is to be specified in ASCII characters. This limits the size of an optional value to 255 bytes - which I suspect was not the intent.
> Does this field need to made large enough to hold 4096 byte lengths?
> 
Thanks for spotting this. It was an oversight on my part and this will definitely be addressed in the next version with updated field length of 4 bytes.

Regards,

Gonzalo

> Thanks
> 
> Peter
> 
> On 2011-12-07, at 9:41 AM, Peter Musgrave wrote:
> 
>> Hi all, 
>> 
>> I would like to start a WG last call on the recent (hopefully final) update to the sip-clf format doc. 
>> 
>> Please provide your comments by Friday Dec. 16th - including just a simple "looks good".
>> 
>> I would really like to get this WG wrapped up in time for Xmas!
>> 
>> Regards, 
>> 
>> Peter Musgrave
> 
>