[sip-clf] draft-ietf-sipclf-format-00 comments

Anders Nygren <anders.nygren@gmail.com> Fri, 11 March 2011 18:00 UTC

Return-Path: <anders.nygren@gmail.com>
X-Original-To: sip-clf@core3.amsl.com
Delivered-To: sip-clf@core3.amsl.com
Received: from localhost (localhost [127.0.0.1]) by core3.amsl.com (Postfix) with ESMTP id 0BA7B3A6A5A for <sip-clf@core3.amsl.com>; Fri, 11 Mar 2011 10:00:35 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3.599
X-Spam-Level:
X-Spam-Status: No, score=-3.599 tagged_above=-999 required=5 tests=[BAYES_00=-2.599, RCVD_IN_DNSWL_LOW=-1]
Received: from mail.ietf.org ([64.170.98.32]) by localhost (core3.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id KvxqdEtXXZ-c for <sip-clf@core3.amsl.com>; Fri, 11 Mar 2011 10:00:34 -0800 (PST)
Received: from mail-ww0-f44.google.com (mail-ww0-f44.google.com [74.125.82.44]) by core3.amsl.com (Postfix) with ESMTP id 84F2D3A6A0C for <sip-clf@ietf.org>; Fri, 11 Mar 2011 10:00:30 -0800 (PST)
Received: by wwa36 with SMTP id 36so2439529wwa.13 for <sip-clf@ietf.org>; Fri, 11 Mar 2011 10:01:49 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:date:message-id:subject:from:to :content-type; bh=McnugBreA5svyD9YLFTj/hDloonC40Fpbm/QnG0al8s=; b=k/YqcpU1KYJ8UqdPO3lRq5rQ2nhJPKwC6ZhmjCrsgR25/DF47NuM0nwducCyuTF2ZY ZpVdyjfApfupaI43wTwEJrSghlrAd9Njk6VUOvZlrYIr1Bb1frXXkkYR6Sw2SHyntFva VkMH9RZMoNNUISE6CkRHLmf2g1DQqi0EcKPrM=
DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:date:message-id:subject:from:to:content-type; b=N5QzGsWoR2OrvyotZF3UUisMVupDVYwevj90j/1SdDFM2aR3ojxWmhtb9Qaa9KTD+B AIaN+3i69vmoBS+20lHr1qZqZjcbyvhS/vbNK9HhPbtupiEdczZKS/0lNIWxeH4dAC9E OekDG3bQ1TDvy2u/D/OtAQABM5kqWCkCN2Loo=
MIME-Version: 1.0
Received: by 10.216.79.11 with SMTP id h11mr8131022wee.77.1299866509433; Fri, 11 Mar 2011 10:01:49 -0800 (PST)
Received: by 10.216.25.17 with HTTP; Fri, 11 Mar 2011 10:01:49 -0800 (PST)
Date: Fri, 11 Mar 2011 12:01:49 -0600
Message-ID: <AANLkTimXr_8sHoUCOBkJtLR073=Z-m2A=jqbs4FXyNs+@mail.gmail.com>
From: Anders Nygren <anders.nygren@gmail.com>
To: sip-clf@ietf.org
Content-Type: text/plain; charset=ISO-8859-1
Subject: [sip-clf] draft-ietf-sipclf-format-00 comments
X-BeenThere: sip-clf@ietf.org
X-Mailman-Version: 2.1.9
Precedence: list
List-Id: SIP Common Log File format discussion list <sip-clf.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/listinfo/sip-clf>, <mailto:sip-clf-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/sip-clf>
List-Post: <mailto:sip-clf@ietf.org>
List-Help: <mailto:sip-clf-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/sip-clf>, <mailto:sip-clf-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 11 Mar 2011 18:00:35 -0000

Hi
I am not sure what is the correct way for commenting on the SIP-CLF spec,
so I will do it here until someone tells me that there is a better
place to do it.

I am trying to implement a log reader and writer according to
draft-ietf-sipclf-format-00 and have found a few small errors.

page 8:
   "Record Length (6 bytes):  Hexadecimal encoded total length of this
    log record, including "Flags" and "Record Length" fields, and
    terminating line-feed."

Should that include the version field as well?

page 12:
   "Length Field (2 bytes):  Indicates the length of the value coded in
    this TLV, hexadecimal encoded.  This length does NOT include the
    TLV header."

The length field is shown as 4 bytes in figure 5.

/Anders Nygren