Re: [sip-clf] draft-ietf-sipclf-format-00 comments

Anders Nygren <anders.nygren@gmail.com> Fri, 11 March 2011 23:53 UTC

Return-Path: <anders.nygren@gmail.com>
X-Original-To: sip-clf@core3.amsl.com
Delivered-To: sip-clf@core3.amsl.com
Received: from localhost (localhost [127.0.0.1]) by core3.amsl.com (Postfix) with ESMTP id 133153A6AAF for <sip-clf@core3.amsl.com>; Fri, 11 Mar 2011 15:53:07 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3.599
X-Spam-Level:
X-Spam-Status: No, score=-3.599 tagged_above=-999 required=5 tests=[BAYES_00=-2.599, RCVD_IN_DNSWL_LOW=-1]
Received: from mail.ietf.org ([64.170.98.32]) by localhost (core3.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id VOlS5vahEioQ for <sip-clf@core3.amsl.com>; Fri, 11 Mar 2011 15:53:04 -0800 (PST)
Received: from mail-ww0-f44.google.com (mail-ww0-f44.google.com [74.125.82.44]) by core3.amsl.com (Postfix) with ESMTP id 682AE3A6A25 for <sip-clf@ietf.org>; Fri, 11 Mar 2011 15:53:04 -0800 (PST)
Received: by wwa36 with SMTP id 36so2648455wwa.13 for <sip-clf@ietf.org>; Fri, 11 Mar 2011 15:54:23 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=aKBxwIR5RVvCUgjzjbLuRlGOJyQeVAsk7AqTqjL+NoI=; b=hvlKJa47BfQpjKbbsMryzeIbtNxTq8u6WdVYEq09ACoFLy0tOD0MX5HQ10Tx73bbkJ 3Jiooyzg8hYlGiWewrRF2WXqX3glHXv5+BmTT6qE59i4HwODc8ffG8uiRgCjaxdcnEHy xvhyq2KNXmps9E2DEj/OXhOl69Pjg/GCBTpas=
DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=nd75Vlr0XLWCt5bVeQSjeEO0W5WaTp+7t/jnlThWDklJA3UWukYZU8lKYxry8NWYU7 4mbs9JQI7gQ8FZTHl2GfYegZfV0V7m4aOj9e+2KcPnEVOKZiaJof7HEVZlnYsJYnqGWo aWxhwL+EdgYSH+CjlMv31xwG2f1fiqMI6o1LE=
MIME-Version: 1.0
Received: by 10.216.120.193 with SMTP id p43mr8284702weh.92.1299887663326; Fri, 11 Mar 2011 15:54:23 -0800 (PST)
Received: by 10.216.25.17 with HTTP; Fri, 11 Mar 2011 15:54:23 -0800 (PST)
In-Reply-To: <7321A81E-1E05-4EBF-8250-1AF9DD09CEA4@cisco.com>
References: <AANLkTimXr_8sHoUCOBkJtLR073=Z-m2A=jqbs4FXyNs+@mail.gmail.com> <B116D9C8-C234-44C7-B2D4-3F2C9860A8BD@cisco.com> <AANLkTi=c842r67B=BZU0Ep-_+mijeTvBw55M3qTEVvf1@mail.gmail.com> <7321A81E-1E05-4EBF-8250-1AF9DD09CEA4@cisco.com>
Date: Fri, 11 Mar 2011 17:54:23 -0600
Message-ID: <AANLkTikyir9cWQTmfQOaOYFq9yhY9QQ+Zh01zDwO4yJG@mail.gmail.com>
From: Anders Nygren <anders.nygren@gmail.com>
To: Gonzalo Salgueiro <gsalguei@cisco.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Cc: sip-clf@ietf.org
Subject: Re: [sip-clf] draft-ietf-sipclf-format-00 comments
X-BeenThere: sip-clf@ietf.org
X-Mailman-Version: 2.1.9
Precedence: list
List-Id: SIP Common Log File format discussion list <sip-clf.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/listinfo/sip-clf>, <mailto:sip-clf-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/sip-clf>
List-Post: <mailto:sip-clf@ietf.org>
List-Help: <mailto:sip-clf-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/sip-clf>, <mailto:sip-clf-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 11 Mar 2011 23:53:07 -0000

Hi
In chapter 4.1, the text
  "The <IndexPointers> portion of the SIP CLF record is a 64-byte header
   that indicates meta-data about the record."
is repeated before and after the figure 3.

chapter 4.3 figure 5 shows a 0x0A after the TLVs. But I think that
0x0A is not part of the
optional parameters portion but is the termination of the record, and
should be included
even if there are no optional parameters in the record.

/Anders


On Fri, Mar 11, 2011 at 5:07 PM, Gonzalo Salgueiro <gsalguei@cisco.com> wrote:
> Thanks Anders. This reflected an earlier intent for microsecond accuracy
> that has since been rescinded. I have amended the text.
> Regards,
> Gonzalo
> On Mar 11, 2011, at 5:43 PM, Anders Nygren wrote:
>
> One more thing,
> page 9,
> The text says that fractional seconds is 6 bytes but figure 4 shows 3 bytes.
>
> /Anders
>
> On Fri, Mar 11, 2011 at 1:38 PM, Gonzalo Salgueiro <gsalguei@cisco.com>
> wrote:
>
> Anders -
>
> Thanks for providing your feedback, it is much appreciated as we work
> through developing this format.
>
> I'm very glad to hear you are implementing this already and would be willing
> to follow up with you offline to get some data points on how you decided to
> do this, how difficult it was, and how useful you found it, what you would
> change, etc.
>
> Comments inline...
>
> On Mar 11, 2011, at 1:01 PM, Anders Nygren wrote:
>
> Hi
>
> I am not sure what is the correct way for commenting on the SIP-CLF spec,
>
> so I will do it here until someone tells me that there is a better
>
> place to do it.
>
> [GS] This is indeed the place.
>
> I am trying to implement a log reader and writer according to
>
> draft-ietf-sipclf-format-00 and have found a few small errors.
>
> page 8:
>
>   "Record Length (6 bytes):  Hexadecimal encoded total length of this
>
>    log record, including "Flags" and "Record Length" fields, and
>
>    terminating line-feed."
>
> Should that include the version field as well?
>
> [GS] Yes this does include the Version field. It is the length of the ENTIRE
> record including all of <IndexPointers>, <MandatoryFields>, <OptionalFields>
>
> The list of items in the text you have selected is not meant to be  complete
> listing of all fields, rather a representative list indicating that
> everything is included. If you think there is value in specifically
> mentioning the Version field, then I will modify the text as follows:
>
> Hexadecimal encoded total length of this log record, including "Version",
> "Record Length", "Flags" fields, and terminating line-feed.
>
>
>
> page 12:
>
>   "Length Field (2 bytes):  Indicates the length of the value coded in
>
>    this TLV, hexadecimal encoded.  This length does NOT include the
>
>    TLV header."
>
> The length field is shown as 4 bytes in figure 5.
>
> Thanks. Great catch.  This is indeed wrong. The figure is correct. I will
> change the text to 4 bytes.
>
> Warm Regards,
>
> Gonzalo
>
> /Anders Nygren
>
> _______________________________________________
>
> sip-clf mailing list
>
> sip-clf@ietf.org
>
> https://www.ietf.org/mailman/listinfo/sip-clf
>
>
>
>