Re: [sip-overload] draft-ietf-soc-overload-control-01 submitted

["Vijay K. Gurbani" <[e-mail]>]

On 01/25/2011 02:08 AM, Antoine Roly wrote:
> Hi,
>
> There are some small differences between the example in section 3 and
> the syntax definition in section 14. It could be a good thing to correct
> them for readability.

Antoine: Thanks for a close read.  More inline.

> - In section 14, it is:
> oc-validity = "oc_validity" [EQUAL delta-ms]
> but in section 3, in the response
> ...;oc-validity=500;...
>
> Which one is correct? With "-" or "_" ?

Good catch; the one with a "-" is correct.  I have modified this in
my working copy and the modification will show up in the next
revision.

> - In section 14 it is:
> oc-seq = (1*12DIGIT "." 1*5DIGIT)
> but in the example it is
> ;oc-seq=1282321615.781;...
>
> IIUC the definition and the example does not match.
> I think it should be something like :
> oc-seq = "oc-seq" EQUAL 1*12DIGIT "." 1*5DIGIT

Right.  I have changed it as such.  The "oc-algo" production
rule suffered from the same fate; I have fixed that as well.
All these changes will show up in the next revision.

Thanks again.

- vijay
-- 
Vijay K. Gurbani, Bell Laboratories, Alcatel-Lucent
1960 Lucent Lane, Rm. 9C-533, Naperville, Illinois 60566 (USA)
Email: vkg@{bell-labs.com,acm.org} / [e-mail]
Web:   http://ect.bell-labs.com/who/vkg/