Re: [Sipbrandy] WGLC: draft-ietf-sipbrandy-osrtp-04 - Christer's review

Christer Holmberg <christer.holmberg@ericsson.com> Fri, 20 April 2018 07:58 UTC

Return-Path: <christer.holmberg@ericsson.com>
X-Original-To: sipbrandy@ietfa.amsl.com
Delivered-To: sipbrandy@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id AFEC9124D6C for <sipbrandy@ietfa.amsl.com>; Fri, 20 Apr 2018 00:58:04 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -4.312
X-Spam-Level:
X-Spam-Status: No, score=-4.312 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=ericsson.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id UfdfXVYyD1-3 for <sipbrandy@ietfa.amsl.com>; Fri, 20 Apr 2018 00:58:03 -0700 (PDT)
Received: from sessmg23.ericsson.net (sessmg23.ericsson.net [193.180.251.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 9BCDD1204DA for <sipbrandy@ietf.org>; Fri, 20 Apr 2018 00:58:02 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; d=ericsson.com; s=mailgw201801; c=relaxed/simple; q=dns/txt; i=@ericsson.com; t=1524211080; h=From:Sender:Reply-To:Subject:Date:Message-ID:To:Cc:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=lbRMoyyzg9XD+7pNxSiNSgjEwST529W99/Oai2HSSF8=; b=HFnYPdRi48Kq7aAHvjki85pUOstZero+Y3vi+Ha+VCy4ysou8/Am0WrXwyZ/Ih5m bo7QWeYnyP+/UPROycwnUsv6CV8RCdCLHD0m2f7iR91USrGrBRr25vy+UZQ+09kC KWfVXLuTqyit5eTOoDW0f5v7znIyMvHGqKQIS+wjbL0=;
X-AuditID: c1b4fb2d-815ff70000003563-9e-5ad99d885505
Received: from ESESSHC011.ericsson.se (Unknown_Domain [153.88.183.51]) by sessmg23.ericsson.net (Symantec Mail Security) with SMTP id 57.50.13667.88D99DA5; Fri, 20 Apr 2018 09:58:00 +0200 (CEST)
Received: from ESESSMB109.ericsson.se ([169.254.9.34]) by ESESSHC011.ericsson.se ([153.88.183.51]) with mapi id 14.03.0382.000; Fri, 20 Apr 2018 09:58:00 +0200
From: Christer Holmberg <christer.holmberg@ericsson.com>
To: "sipbrandy@ietf.org" <sipbrandy@ietf.org>
Thread-Topic: [Sipbrandy] WGLC: draft-ietf-sipbrandy-osrtp-04 - Christer's review
Thread-Index: AQHT2H1MtettfGxkckGZ8W9pjatITQ==
Date: Fri, 20 Apr 2018 07:58:00 +0000
Message-ID: <D6FF722F.2E7B0%christer.holmberg@ericsson.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Microsoft-MacOutlook/14.7.7.170905
x-originating-ip: [131.160.50.130]
Content-Type: text/plain; charset="iso-8859-1"
Content-ID: <23A010B5E4FCA0438FA36BF9BAAA1A96@ericsson.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrALMWRmVeSWpSXmKPExsUyM2K7sW7H3JtRBqfaLC1WrDvF5MDosWTJ T6YAxigum5TUnMyy1CJ9uwSujItPdrEUTBSpuH3KrIFxlkAXIyeHhICJxJrH99m6GLk4hASO MEoc/nKUFcJZzCjRvG4bUxcjBwebgIVE9z9tkAYRAV2JySsuMoLYwgJBEj1TdrNBxIMlHvWd ZIGw9SSmf/gNFmcRUJXYNWcaWD2vgLXEudUvwWoYBcQkvp9awwRiMwuIS9x6Mp8J4iABiSV7 zjND2KISLx//YwWxRYFmbjhxmx3kHAkBJYnbG5wgWvUkbkydwgZhW0s03j3NCGFrSyxb+JoZ Yq2gxMmZT1gmMIrMQrJtFpL2WUjaZyFpn4WkfQEj6ypG0eLU4uLcdCNjvdSizOTi4vw8vbzU kk2MwHg4uOW37g7G1a8dDzEKcDAq8fDebLsZJcSaWFZcmXuIUYKDWUmEN8EMKMSbklhZlVqU H19UmpNafIhRmoNFSZxXb9WeKCGB9MSS1OzU1ILUIpgsEwenVANjyq4y1oaPn7XPFnvum30s 89K8qc9NPuztMLx7rXnxGx2xUx0GPJIc82aWHj72PPVfZNYfyY4ja8U6NF6KxlnqR+Xa3Ju6 5ZN9682stV76jdM3rGGNyg253mPrzPzBsP4AK9PTT9sZf3afma98bdVGu4wJjoXH3m5vYI4W 0Xp35fxOr83cp5bVKbEUZyQaajEXFScCAOoSw3mDAgAA
Archived-At: <https://mailarchive.ietf.org/arch/msg/sipbrandy/raN4zgTxuPldnLh_U5jcc7BAF5w>
Subject: Re: [Sipbrandy] WGLC: draft-ietf-sipbrandy-osrtp-04 - Christer's review
X-BeenThere: sipbrandy@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: SIPBRANDY working group discussion list <sipbrandy.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/sipbrandy>, <mailto:sipbrandy-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/sipbrandy/>
List-Post: <mailto:sipbrandy@ietf.org>
List-Help: <mailto:sipbrandy-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/sipbrandy>, <mailto:sipbrandy-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 20 Apr 2018 07:58:05 -0000

Hi,

Below is my WGLC review.

I base my review based on the assumption that the associated MMUSIC draft
is not going to be progressed, and that draft-ietf-sipbrandy-osrtp is the
ONLY deliverable related to OSRTP and SDP O/A.

Also, some of my comments is repeating what I have said previously, but I
include them in my review in order to have everything in one place.


GENERAL:
--------

QG_1: The draft will be published as an Informational RFC (I know the
reason, so no need to discuss that). Because of that, many SDOs will not
be able to normatively reference it. So, if such SDO wants to adopt SDP
O/A procedures of OSRTP (I know there are SDOs, or at least SDO members,
interested in OSRTP), they would have to ³re-define² the procedures
themselves.

I wonder whether it would be useful to include some text/guidance
regarding that in the document, i.e., recommending that such procedures
are based on the procedures in the draft, for interoperability purpose etc?


QG_2: There are no BUNDLE considerations. Even though it may seem obvious,
I think it would be useful to indicate that the same security selection
needs to be applied to all RTP-based m- sections within a BUNDLE group.


Section 1:
----------


Q1_1: Shall we really reference individual drafts that will not progress?
Couldn¹t we simply talk about ³based on previous work and studies done by
Hadriel Kaplan" 


Section 3:
----------

Q3_1: I don¹t understand the title of the section. Shouldn¹t it be ³SDP
Offer/Answer Procedures²?

Q3_2: Eventhough the document is Informational, since Section 3 does
contain O/A text I think it should be done properly, describing how the
offer is generated, how the answer is generated etc.

Q3_3: There is no text on subsequent offers. If security has been
negotiated in a previous O/A exchange, what profile values etc do I
include in subsequent offers?


Section 4:
----------

Q4_1: Doesn¹t the last paragraph belong in the Applicability section?


Regards,

Christer







On 19/04/18 14:21, "Sipbrandy on behalf of Gonzalo Camarillo"
<sipbrandy-bounces@ietf.org on behalf of Gonzalo.Camarillo@ericsson.com>
wrote:

>Folks,
>
>I would like to start a WGLC on the following draft. This WGLC will
>end on May 10th:
>
>https://tools.ietf.org/html/draft-ietf-sipbrandy-osrtp-04
>
>Thanks,
>
>Gonzalo
>
>_______________________________________________
>Sipbrandy mailing list
>Sipbrandy@ietf.org
>https://www.ietf.org/mailman/listinfo/sipbrandy