Re: [sipcore] I-D Action: draft-ietf-sipcore-sip-push-23.txt

Paul Kyzivat <pkyzivat@alum.mit.edu> Mon, 28 January 2019 15:59 UTC

Return-Path: <pkyzivat@alum.mit.edu>
X-Original-To: sipcore@ietfa.amsl.com
Delivered-To: sipcore@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 623BD130E8D for <sipcore@ietfa.amsl.com>; Mon, 28 Jan 2019 07:59:54 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.901
X-Spam-Level:
X-Spam-Status: No, score=-1.901 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id IhexDbztUIN5 for <sipcore@ietfa.amsl.com>; Mon, 28 Jan 2019 07:59:52 -0800 (PST)
Received: from outgoing-alum.mit.edu (outgoing-alum.mit.edu [18.7.68.33]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 88A92130E89 for <sipcore@ietf.org>; Mon, 28 Jan 2019 07:59:52 -0800 (PST)
Received: from PaulKyzivatsMBP.localdomain (c-24-62-227-142.hsd1.ma.comcast.net [24.62.227.142]) (authenticated bits=0) (User authenticated as pkyzivat@ALUM.MIT.EDU) by outgoing-alum.mit.edu (8.14.7/8.12.4) with ESMTP id x0SFxmO0018077 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NOT); Mon, 28 Jan 2019 10:59:49 -0500
To: Christer Holmberg <christer.holmberg@ericsson.com>, "sipcore@ietf.org" <sipcore@ietf.org>
References: <154806928171.8056.16604437906150841112@ietfa.amsl.com> <a68e014f-1989-0a21-141c-29c0ead3fbbe@alum.mit.edu> <HE1PR07MB31616F291AC0AACF23178503939F0@HE1PR07MB3161.eurprd07.prod.outlook.com> <C30A8941-57D6-46B3-AC15-81154CD12088@ericsson.com>
From: Paul Kyzivat <pkyzivat@alum.mit.edu>
Message-ID: <6cd24024-5a39-52a7-f411-d378ee5eb4d9@alum.mit.edu>
Date: Mon, 28 Jan 2019 10:59:48 -0500
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:60.0) Gecko/20100101 Thunderbird/60.4.0
MIME-Version: 1.0
In-Reply-To: <C30A8941-57D6-46B3-AC15-81154CD12088@ericsson.com>
Content-Type: text/plain; charset="utf-8"; format="flowed"
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Archived-At: <https://mailarchive.ietf.org/arch/msg/sipcore/6dS-fHj7IcuIk-UIhGbBRjlBeYs>
Subject: Re: [sipcore] I-D Action: draft-ietf-sipcore-sip-push-23.txt
X-BeenThere: sipcore@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: SIP Core Working Group <sipcore.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/sipcore>, <mailto:sipcore-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/sipcore/>
List-Post: <mailto:sipcore@ietf.org>
List-Help: <mailto:sipcore-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/sipcore>, <mailto:sipcore-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 28 Jan 2019 15:59:54 -0000

On 1/22/19 3:27 AM, Christer Holmberg wrote:
> Hi,
> 
> I was taking a second look in RFC 3261, and the text already says:
> 
> “o  URI uri-parameter components are compared as follows:
> 
>           -  Any uri-parameter appearing in both URIs must match.”
> 
> So, in my opinion that means that 3261 already covers the pn- 
> parameters, and the only thing we need to do in draft-sip-push is to 
> point that out.
> 
> However, draft-sip-push also allows a partial match, and that needs to 
> be normative.
> 
> So, perhaps something like:
> 
>     “When a SIP proxy compares two SIP URIs, the proxy uses the URI
> 
>     comparison rules defined in [RFC3261], meaning that in order
> 
>     for a comparison to be successful the pn-prid, pn-provider and
> 
>     pn-param SIP URI parameters must also match.”
> 
> So, a proxy will always use these rules when comparing SIP URIs, not 
> only when comparing a Contact URI with a Request-URI.
> 
> Pull request with suggested modficiation:
> 
> https://github.com/cdh4u/draft-sip-push/pull/34

I reviewed this change in -24. It resolves my concern.

	Thanks,
	Paul