Re: [sipcore] Alexey Melnikov's No Objection on draft-ietf-sipcore-digest-scheme-12: (with COMMENT)
Rifaat Shekh-Yusef <rifaat.ietf@gmail.com> Thu, 31 October 2019 13:11 UTC
Return-Path: <rifaat.ietf@gmail.com>
X-Original-To: sipcore@ietfa.amsl.com
Delivered-To: sipcore@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 80991120099; Thu, 31 Oct 2019 06:11:39 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.997
X-Spam-Level:
X-Spam-Status: No, score=-1.997 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id qFp6Tg17sjQo; Thu, 31 Oct 2019 06:11:37 -0700 (PDT)
Received: from mail-il1-x142.google.com (mail-il1-x142.google.com [IPv6:2607:f8b0:4864:20::142]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 8320B120058; Thu, 31 Oct 2019 06:11:37 -0700 (PDT)
Received: by mail-il1-x142.google.com with SMTP id z10so5316558ilo.8; Thu, 31 Oct 2019 06:11:37 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=OWfT/kGZ/2NXGOPa1Skg5c1fMVN8DoRWbo7lU1Ifh1g=; b=C9PV7EK88i+eKZ1bkvJiMwUMYtjvLdm4/PISbdwhKrwB75VJUO0iGagDPh6uwMBrBn 5xp1baj4VgPA+I0Yjr1t1PapzCmYGGEO9c7H3+vyigx13vDr6BCA1a5wylSYEECjLTfw 0DCmxTSzSe+LOGlJ4OG9oear1fzDn2LFnFVfxFKbHSYjnMWYTu+df22ncVUtCvZGZtCa 7zxkdJmR7c9Hi1JZFGcpOfpA0ykbjCQeSW2GdqFs7oBU3XHUZ9t13KKK2yzsEMwiUpb+ Nc/P42IASHOyaDaV4FMcvYRCTrzKit8w77G+zb3WeXZ2ZyZhnMGoOwm2c62tECoVQGp0 A0XA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=OWfT/kGZ/2NXGOPa1Skg5c1fMVN8DoRWbo7lU1Ifh1g=; b=R0cixDi11bOwg8sh8M9MK6YABmyCyAdOWOI+h2X3zMXnxqEvEt/eVij57HogSHJfOX H7VVnjSJLDbSJSg72M4R6Ur9dg3nq92SUMJ53qdrm5mEu5qglQY5n9kubRz2raykkK1d uGXuYd7cmX92KMXMZjn0mIaISb4dXLLFlOA1E53Mh0qA0eiWbunfFsTabvo+lh0q7N6K 7ZZghmZLWJUf915eMt79g0yE3uz7KKeltkynkjzbcriUVxhqVZ+kKrLzsZ143YNMNKd7 pvI1yChcLMgzTGnvKNYFRsiehyVOUxQ5XN6a5FtndL5hraq7Vaequ7lxUzMH1Px25cMD OE2g==
X-Gm-Message-State: APjAAAW/4718HSEtnEz4HVcLrv1Ktg/s1kKaSYyXQb6qUvG8pFWIv9B/ 00IIbGx8vSPutdM29oknMgAuifn4FyVTWXnq1i4=
X-Google-Smtp-Source: APXvYqzw5lZ38eQWmABQeihMdWkLxYKtyPEkydw87YmqG3GdQ/XKSMtQeC8SjtzoHkZfBYQ4FOi25M4nvCV4BPjMbPI=
X-Received: by 2002:a92:8897:: with SMTP id m23mr5788704ilh.36.1572527496733; Thu, 31 Oct 2019 06:11:36 -0700 (PDT)
MIME-Version: 1.0
References: <157245577700.32490.10990766778571550817.idtracker@ietfa.amsl.com> <CAGL6epJgyr_VUYgKCgxDcP5ObKWErtDCHxaX7JusUYPXu=a6jQ@mail.gmail.com> <a9ebadcc-36ae-4bdb-af69-05486eef2569@www.fastmail.com>
In-Reply-To: <a9ebadcc-36ae-4bdb-af69-05486eef2569@www.fastmail.com>
From: Rifaat Shekh-Yusef <rifaat.ietf@gmail.com>
Date: Thu, 31 Oct 2019 09:11:25 -0400
Message-ID: <CAGL6ep+AK4BuGZ2Y1RMsomAYGLiy2NbEHgm5-941FLVKS6bY9Q@mail.gmail.com>
To: Alexey Melnikov <aamelnikov@fastmail.fm>
Cc: The IESG <iesg@ietf.org>, draft-ietf-sipcore-digest-scheme@ietf.org, "A. Jean Mahoney" <mahoney@nostrum.com>, sipcore-chairs@ietf.org, SIPCORE <sipcore@ietf.org>
Content-Type: multipart/alternative; boundary="000000000000d7aaef059634964c"
Archived-At: <https://mailarchive.ietf.org/arch/msg/sipcore/Q5JGJfhA5hd1Yf23LLX75H9orEc>
Subject: Re: [sipcore] Alexey Melnikov's No Objection on draft-ietf-sipcore-digest-scheme-12: (with COMMENT)
X-BeenThere: sipcore@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: SIP Core Working Group <sipcore.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/sipcore>, <mailto:sipcore-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/sipcore/>
List-Post: <mailto:sipcore@ietf.org>
List-Help: <mailto:sipcore-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/sipcore>, <mailto:sipcore-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 31 Oct 2019 13:11:40 -0000
Hi Alexey, I am fine with Paul's suggestion. Are you ok with "32*LHEX"? Regards, Rfaat On Thu, Oct 31, 2019 at 7:22 AM Alexey Melnikov <aamelnikov@fastmail.fm> wrote: > Hi Rifaat, > > On Wed, Oct 30, 2019, at 9:50 PM, Rifaat Shekh-Yusef wrote: > > Thanks Alexey! > > I am fine with the first two comments, and will fix these in the coming > version of the document. > > I am not sure I follow the 3rd one. Why do you see the need for a minimum > number of hex digits? > > You do say that the number of hex digits match the hash lenght, so it is > probably Ok. However empty value is never valid (and I am worried it might > hit some boundary condition bug in implementations), so prohibiting it in > ABNF would be the best. > > Best Regards, > Alexey > > > Regards, > Rifaat > > > > On Wed, Oct 30, 2019 at 1:16 PM Alexey Melnikov via Datatracker < > noreply@ietf.org> wrote: > > Alexey Melnikov has entered the following ballot position for > draft-ietf-sipcore-digest-scheme-12: No Objection > > When responding, please keep the subject line intact and reply to all > email addresses included in the To and CC lines. (Feel free to cut this > introductory paragraph, however.) > > > Please refer to https://www.ietf.org/iesg/statement/discuss-criteria.html > for more information about IESG DISCUSS and COMMENT positions. > > > The document, along with other ballot positions, can be found here: > https://datatracker.ietf.org/doc/draft-ietf-sipcore-digest-scheme/ > > > > ---------------------------------------------------------------------- > COMMENT: > ---------------------------------------------------------------------- > > I am agreeing with Alissa's DISCUSS. > > Also, I have a few comments of my own: > > 1) Last para of Section 2.1: > > 2.1. Hash Algorithms > > A UAS prioritizes which algorithm to use based on the ordering of the > challenge header fields in the response it is preparing. > > This looks either wrong or confusing to me. I think you are just saying > here > that the order is decided by the server at this point. > > That > process is specified in section 2.3 and parallels the process used in > HTTP specified by [RFC7616]. > > So based on the above, my suggested replacement for both sentences: > > A UAS prioritizes which algorithm to use based on its policy, > which is specified in section 2.3 and parallels the process used in > HTTP specified by [RFC7616]. > > 2) Last para of Section 2.4: > > If the UAC cannot respond to any of the challenges in the response, > then it SHOULD abandon attempts to send the request unless a local > policy dictates otherwise. > > Is trying other non Digest algorithms covered by "SHOULD abandon"? > If yes, maybe you should make this clearer. > > For example, if the UAC does not have > credentials or has stale credentials for any of the realms, the UAC > will abandon the request. > > 3) In Section 2.7: > > request-digest = LDQUOT *LHEX RDQUOT > > This now allows empty value. I suggest you specify a minimum number of hex > digits allowed in the ABNF. Or at least change "*LHEX" to "2*LHEX". > > > >
- [sipcore] Alexey Melnikov's No Objection on draft… Alexey Melnikov via Datatracker
- Re: [sipcore] Alexey Melnikov's No Objection on d… Rifaat Shekh-Yusef
- Re: [sipcore] Alexey Melnikov's No Objection on d… Paul Kyzivat
- Re: [sipcore] Alexey Melnikov's No Objection on d… Alexey Melnikov
- Re: [sipcore] Alexey Melnikov's No Objection on d… Rifaat Shekh-Yusef
- Re: [sipcore] Alexey Melnikov's No Objection on d… Alexey Melnikov
- Re: [sipcore] Alexey Melnikov's No Objection on d… Rifaat Shekh-Yusef
- Re: [sipcore] Alexey Melnikov's No Objection on d… Christer Holmberg
- Re: [sipcore] Alexey Melnikov's No Objection on d… Rifaat Shekh-Yusef
- Re: [sipcore] Alexey Melnikov's No Objection on d… Christer Holmberg
- Re: [sipcore] Alexey Melnikov's No Objection on d… Christer Holmberg
- Re: [sipcore] Alexey Melnikov's No Objection on d… Rifaat Shekh-Yusef
- Re: [sipcore] Alexey Melnikov's No Objection on d… Christer Holmberg
- Re: [sipcore] Alexey Melnikov's No Objection on d… Rifaat Shekh-Yusef
- Re: [sipcore] Alexey Melnikov's No Objection on d… Christer Holmberg
- Re: [sipcore] Alexey Melnikov's No Objection on d… Alexey Melnikov
- Re: [sipcore] Alexey Melnikov's No Objection on d… Christer Holmberg
- Re: [sipcore] Alexey Melnikov's No Objection on d… Rifaat Shekh-Yusef
- Re: [sipcore] Alexey Melnikov's No Objection on d… Christer Holmberg
- Re: [sipcore] Alexey Melnikov's No Objection on d… Rifaat Shekh-Yusef
- Re: [sipcore] Alexey Melnikov's No Objection on d… Christer Holmberg
- Re: [sipcore] Alexey Melnikov's No Objection on d… Rifaat Shekh-Yusef
- Re: [sipcore] Alexey Melnikov's No Objection on d… Paul Kyzivat
- Re: [sipcore] Alexey Melnikov's No Objection on d… Christer Holmberg