[sipcore] location conveyance looks good

"Thomson, Martin" <Martin.Thomson@andrew.com> Tue, 26 October 2010 05:49 UTC

Return-Path: <Martin.Thomson@andrew.com>
X-Original-To: sipcore@core3.amsl.com
Delivered-To: sipcore@core3.amsl.com
Received: from localhost (localhost [127.0.0.1]) by core3.amsl.com (Postfix) with ESMTP id C934C3A67E4 for <sipcore@core3.amsl.com>; Mon, 25 Oct 2010 22:49:17 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.872
X-Spam-Level:
X-Spam-Status: No, score=-2.872 tagged_above=-999 required=5 tests=[AWL=-0.273, BAYES_00=-2.599]
Received: from mail.ietf.org ([64.170.98.32]) by localhost (core3.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id d48grKOswBQN for <sipcore@core3.amsl.com>; Mon, 25 Oct 2010 22:49:09 -0700 (PDT)
Received: from csmailgw1.commscope.com (csmailgw1.commscope.com [198.135.207.244]) by core3.amsl.com (Postfix) with ESMTP id 7005A3A67AB for <sipcore@ietf.org>; Mon, 25 Oct 2010 22:49:09 -0700 (PDT)
Received: from [10.86.20.103] ([10.86.20.103]:54898 "EHLO ACDCE7HC2.commscope.com") by csmailgw1.commscope.com with ESMTP id S36570313Ab0JZFuz (ORCPT <rfc822; sipcore@ietf.org>); Tue, 26 Oct 2010 00:50:55 -0500
Received: from SISPE7HC2.commscope.com (10.97.4.13) by ACDCE7HC2.commscope.com (10.86.20.103) with Microsoft SMTP Server (TLS) id 8.1.436.0; Tue, 26 Oct 2010 00:50:55 -0500
Received: from SISPE7MB1.commscope.com ([fe80::9d82:a492:85e3:a293]) by SISPE7HC2.commscope.com ([fe80::58c3:2447:f977:57c3%10]) with mapi; Tue, 26 Oct 2010 13:50:52 +0800
From: "Thomson, Martin" <Martin.Thomson@andrew.com>
To: "James M. Polk" <jmpolk@cisco.com>, "Peterson, Jon" <jon.peterson@neustar.biz>
Date: Tue, 26 Oct 2010 13:50:50 +0800
Thread-Topic: location conveyance looks good
Thread-Index: Act00b5kRhXX8ZY4TqSBlXpFWsid/g==
Message-ID: <8B0A9FCBB9832F43971E38010638454F03F31EAF78@SISPE7MB1.commscope.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
acceptlanguage: en-US
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-BCN: Meridius 1000 Version 3.4 on csmailgw1.commscope.com
X-BCN-Sender: Martin.Thomson@andrew.com
Cc: "sipcore@ietf.org" <sipcore@ietf.org>
Subject: [sipcore] location conveyance looks good
X-BeenThere: sipcore@ietf.org
X-Mailman-Version: 2.1.9
Precedence: list
List-Id: SIP Core Working Group <sipcore.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/listinfo/sipcore>, <mailto:sipcore-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/sipcore>
List-Post: <mailto:sipcore@ietf.org>
List-Help: <mailto:sipcore-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/sipcore>, <mailto:sipcore-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 26 Oct 2010 05:49:18 -0000

Reviewing the changes in draft-ietf-sipcore-location-conveyance-04.  Nothing much to add except nits.

I could quibble.  I still don't like or want the entirety of Section 4.3 and the serial nature Figure 2 is a little mysterious to me, but it's down to subjective stuff like that, the effort just doesn't pay off.

So, ship it.
 
--Martin


Nits:

This seems odd, especially since the parameter is MUST-strength mandatory:

   ...  If no routing-allowed parameter	
   is present in a SIP request, a SIP intermediary MAY insert this	
   value with a RECOMMENDED value of "no" by default.

Cross references should capitalize the 's' in Section 3.4.

The MIME multipart headers are still in the wrong place (see Section 5 of RFC 2387 to see how this is done):

OLD:
--boundary

Content-Type: application/pidf+xml
Content-ID: <blahblah@example.com>
<?xml version="1.0" standalone="true"?>
<presence ...

NEW:
--boundary
Content-Type: application/pidf+xml
Content-ID: <blahblah@example.com>

<?xml version="1.0" standalone="true"?>
<presence ...