Re: [sipcore] Benjamin Kaduk's Discuss on draft-ietf-sipcore-sip-token-authnz-15: (with DISCUSS and COMMENT) - the pull request
Rifaat Shekh-Yusef <rifaat.ietf@gmail.com> Tue, 05 May 2020 21:11 UTC
Return-Path: <rifaat.ietf@gmail.com>
X-Original-To: sipcore@ietfa.amsl.com
Delivered-To: sipcore@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 68F8C3A0B35; Tue, 5 May 2020 14:11:53 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.097
X-Spam-Level:
X-Spam-Status: No, score=-2.097 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id CP1-oIpZVLfu; Tue, 5 May 2020 14:11:50 -0700 (PDT)
Received: from mail-il1-x136.google.com (mail-il1-x136.google.com [IPv6:2607:f8b0:4864:20::136]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 69DBB3A0B33; Tue, 5 May 2020 14:11:50 -0700 (PDT)
Received: by mail-il1-x136.google.com with SMTP id b18so208349ilf.2; Tue, 05 May 2020 14:11:50 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=39hqFcZbtS6JbxtL8wK7PMDOLohMhiNTe1Q9ygDjQLc=; b=ck7N05NuiTGcLahg48oMVAgXFQN5EcEJ43wX7N8JXHZD8VOOWnY/ZgBHeVIo8N/hkB ftnBXcUmC9IavW//FbJW0HJ1H2/++k+8g2mkzigzbMv9M+BNobaSKvO1eEEeY/0CnZEo DZefwWz0HhB/9/vqVf3qa8NJva5qD47R5HvGxzLVQdMglrYihlh4xOPS1YMYZeTWWXS9 7eIvcw3bzztKGPLGErQrtBhlJKi1KE8v52dqK5VTLuW/qCAV8f9qJ5xi82kLndJf+znF BV5i5yhY3Y4NK/RDcRGahoR9ZIuXelRXA+y+ga4unTtG3U+edlqqdMzLsWdzg/rRNFYw ttfQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=39hqFcZbtS6JbxtL8wK7PMDOLohMhiNTe1Q9ygDjQLc=; b=aNWxt4UVALB+8cTKTzGt2Vx/EKz7iEAyHQGwxzWLae2RJ9iIw/ILQEaBsdS6OWOWJ3 HI1m5eabJpRDQXuQMubskoc8pLvM8Tms3CIKm/BnmSPgMQgLt3Bk60d8gMtY0rXWAk9/ 25cFS6XL+mkXEaV5rGrByS98AaqWWrXTRVhK2j6SIeoPEJCUWOGIpLkxQ4umVsEazW5R ETRZfxlSEo2Vg1LVOtOdvE9okTj6GC7zSD1OLMOWYeco+z8eiTlYsVfoCp0De6U6I/k0 HIpEYkiajppvhtVk3Kx0e5XUD1rKmiJ9t7znQW2rGxIJu6qh+ZMTwPOh6pgmsAnB/HtG cC8A==
X-Gm-Message-State: AGi0PuYc9IC2pTLfs9TQwfDjnsjQ6pGezkJ7WMSn80TsD6Cem+dqjWV2 kzmaMTszwfyrKQkNCzvgRovplvbOtuXmxJLrVgnxTPO6fauukg==
X-Google-Smtp-Source: APiQypLMVhYCGqYPLDeJ+7JuwmBVTfHfkDPhXgTzQ7UJjnF76YFNSgxfJNpafGQy+2oW3BtFdIWpVyJTAK52dSZ7HMs=
X-Received: by 2002:a92:c8d0:: with SMTP id c16mr5395480ilq.278.1588713109545; Tue, 05 May 2020 14:11:49 -0700 (PDT)
MIME-Version: 1.0
References: <70D8F1BE-9596-4407-9C20-550449863330@ericsson.com>
In-Reply-To: <70D8F1BE-9596-4407-9C20-550449863330@ericsson.com>
From: Rifaat Shekh-Yusef <rifaat.ietf@gmail.com>
Date: Tue, 05 May 2020 17:11:38 -0400
Message-ID: <CAGL6ep+xfkJT8eejpETS2=KbGrr=emcz4EhQaQx8tgOy-U+-sA@mail.gmail.com>
To: Christer Holmberg <christer.holmberg@ericsson.com>
Cc: Benjamin Kaduk <kaduk@mit.edu>, The IESG <iesg@ietf.org>, "draft-ietf-sipcore-sip-token-authnz@ietf.org" <draft-ietf-sipcore-sip-token-authnz@ietf.org>, "sipcore-chairs@ietf.org" <sipcore-chairs@ietf.org>, SIPCORE <sipcore@ietf.org>, Jean Mahoney <mahoney@nostrum.com>
Content-Type: multipart/alternative; boundary="0000000000008b692105a4ed1859"
Archived-At: <https://mailarchive.ietf.org/arch/msg/sipcore/s6jBkKPWu80y_FAwcd75GkSkS_c>
Subject: Re: [sipcore] Benjamin Kaduk's Discuss on draft-ietf-sipcore-sip-token-authnz-15: (with DISCUSS and COMMENT) - the pull request
X-BeenThere: sipcore@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: SIP Core Working Group <sipcore.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/sipcore>, <mailto:sipcore-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/sipcore/>
List-Post: <mailto:sipcore@ietf.org>
List-Help: <mailto:sipcore-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/sipcore>, <mailto:sipcore-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 05 May 2020 21:11:54 -0000
Ben, Does this pull request address your latest DISCUSS and comments? Regards, Rifaat On Tue, May 5, 2020 at 3:31 PM Christer Holmberg < christer.holmberg@ericsson.com> wrote: > Hi, > > > > Based on Benjamin’s comments, I created a new pull request: > > > > https://github.com/rifaat-ietf/draft-ietf-sipcore-sip-token-authnz/pull/9 > > > > Regards, > > > > Christer > > > > > > *From: *Rifaat Shekh-Yusef <rifaat.ietf@gmail.com> > *Date: *Tuesday, 5 May 2020 at 22.10 > *To: *Benjamin Kaduk <kaduk@mit.edu> > *Cc: *"iesg@ietf.org" <iesg@ietf.org>, " > draft-ietf-sipcore-sip-token-authnz@ietf.org" < > draft-ietf-sipcore-sip-token-authnz@ietf.org>, "sipcore-chairs@ietf.org" < > sipcore-chairs@ietf.org>, "sipcore@ietf.org" <sipcore@ietf.org>, "A. > Mahoney" <mahoney@nostrum.com> > *Subject: *Re: Benjamin Kaduk's Discuss on > draft-ietf-sipcore-sip-token-authnz-15: (with DISCUSS and COMMENT) > *Resent from: *<alias-bounces@ietf.org> > *Resent to: *Rifaat Shekh-Yusef <rifaat.ietf@gmail.com>, Christer > Holmberg <christer.holmberg@ericsson.com>, Victor Pascual < > victor.pascual.avila@gmail.com> > *Resent date: *Tuesday, 5 May 2020 at 22.10 > > > > Inline... > > > > On Tue, May 5, 2020 at 2:46 PM Benjamin Kaduk via Datatracker < > noreply@ietf.org> wrote: > > Benjamin Kaduk has entered the following ballot position for > draft-ietf-sipcore-sip-token-authnz-15: Discuss > > When responding, please keep the subject line intact and reply to all > email addresses included in the To and CC lines. (Feel free to cut this > introductory paragraph, however.) > > > Please refer to https://www.ietf.org/iesg/statement/discuss-criteria.html > for more information about IESG DISCUSS and COMMENT positions. > > > The document, along with other ballot positions, can be found here: > https://datatracker.ietf.org/doc/draft-ietf-sipcore-sip-token-authnz/ > > > > ---------------------------------------------------------------------- > DISCUSS: > ---------------------------------------------------------------------- > > Thanks for the updates in the -14 (and -15); they cover most of my points. > > Unfortunately, the new security considerations text seems to introduce a > problematic recommendation: > > Because of that, it is critical to make sure that extra security > measures be taken to safeguard credentials used for Single Sign-On. > Examples of such measures include long passphrase instead of a > password, enabling multi-factor factor authentication, and the use of > embedded browser when possible, as defined in [RFC8252]. > > Looking at RFC 8252 (Section 8.12), it seems to be rather strongly > recommending > to *not* use an embedded browser, which is the opposite of the apparent > recommendation here. Are we missing a word "avoiding" or similar? > > > > Yeah, this should have been "browser" not "embedded browser". > > We will remove the "embedded browser" and replace it with "the native > platform browser". > > > > > > Also, I am not 100% sure my note about refresh tokens was fully addressed; > in Section 2.1.1 we see: > > The refresh token is only used between the UAC and the AS. If the AS > provides a refresh token to the UAC, the UAC uses it to request a new > access token and refresh token from the AS before the currently used > access token expires ([RFC6749], Section 1.5). If the AS does not > > Is it accurate to say that the refresh token is used "to request a new > access > token and refresh token" (specifically the "and refresh token" part)? I > know that > it is not always returned, but am less sure about whether the semantics > always > include an (implicit) request for a new one. > > > > Returning a refresh token is based on AS policy. > > We will remove the "and refresh token". > > > > > > > ---------------------------------------------------------------------- > COMMENT: > ---------------------------------------------------------------------- > > Some other comments on the new text that do not rise to Discuss-level. > > Thanks for adding the mention of a whitelist of trusted ASes; I would > consider > also mentioning it in Section 4 for the authz_server parameter, and/or in > the > security considerations. > > We will add that to the security consideration section. > > > > > > I also would have liked to see some guidance about when one > should/shouldn't > include the realm parameter in a challenge. > > I think this is out of scope, as we are not updating or changing the > existing SIP behavior on this issue. > > > > > > Section 2.1.1 > > UAC contacts the AS in order to obtain tokens, and includes the > requested scopes, based on a local configuration (Figure 1). The UAC > MUST check the AS URL received in the 401/407 response against a list > of trusted ASs configured on the UAC, in order to prevent several > classes of possible vulnerabilities when a client blindly attempt to > use any provided authorization. > > nits: "attempts", and maybe "any provided authorization server". > > Will fix it > > > > Section 3 > > nit: s/claimes/claims/ > > Will fix it > > > > > > Section 5 > > When a registrar chooses to challenge a REGISTER request, if the > registrar can provide access to different levels of services, it is > RECOMMENDED that the registrar includes a scope in the response in > order to indicate the minimum scope needed to register and access > basic services. The access token might include an extended scope > that gives the user access to more advanced features beyond basic > services. > > Is there anything to say about how the broader scope value might be > learned? > > In SIP, it is typically controlled by the admin, that controls the AS, and > dictates the level of access for the user. > > We will add a sentence to that extent. > > > > Regards, > > Rifaat > > >
- Re: [sipcore] Benjamin Kaduk's Discuss on draft-i… Christer Holmberg
- Re: [sipcore] Benjamin Kaduk's Discuss on draft-i… Rifaat Shekh-Yusef
- Re: [sipcore] Benjamin Kaduk's Discuss on draft-i… Benjamin Kaduk
- Re: [sipcore] Benjamin Kaduk's Discuss on draft-i… Rifaat Shekh-Yusef