Re: [sipcore] Secdir last call review of draft-ietf-sipcore-locparam-04

<R.Jesske@telekom.de> Wed, 22 January 2020 07:42 UTC

Return-Path: <R.Jesske@telekom.de>
X-Original-To: sipcore@ietfa.amsl.com
Delivered-To: sipcore@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 74C49120013; Tue, 21 Jan 2020 23:42:06 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -4.299
X-Spam-Level:
X-Spam-Status: No, score=-4.299 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_NONE=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=telekom.de
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id frTnKkY4fqov; Tue, 21 Jan 2020 23:42:04 -0800 (PST)
Received: from mailout31.telekom.de (mailout31.telekom.de [194.25.225.143]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 72057120052; Tue, 21 Jan 2020 23:42:03 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telekom.de; i=@telekom.de; q=dns/txt; s=dtag1; t=1579678924; x=1611214924; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=3kv12OAq/EI0EB3fy0+ZXewikyfGcNRF1m3cs2Oi7uo=; b=Yie1dUWsrbSP71vjG+ciD9HupFFjm+MYCVgO/fH3Q1+pdlfs4Df1ofVk +rUA4lvPBdx5YjZ09ZzxFXA5DClkNT1MVBXhV6GYc9buMEOP+JdxV3V5F /UXR0a3up1Zkr/iZKV0Wmvln+StgdhdYOrN3RCWqiay1BuDLwYIe4nXSB wj3IBKjd8kiN+kSV6zyskJB3wcw/7i25NzkAprQhbfClDBLEaZLuyuOkw oCJ3cftnEhSl4W69qbJNSDg21ivH3mZod8D6W/99xfJe2hzf1UA/zKwsO g2lAMZUzfP04Oy20mNKbX/B/7aIFPdaW1DFZ2mRS5cTpONYMsDj+upgai g==;
IronPort-SDR: k+Qro87l/M3/ryQ1iuLVFDj+J935a9m/z9UAeMPCZXfl/ajkRx4yzz8j6l5L9LVXx25cMcuktS j1qdZFGIVf7Q==
Received: from qdec94.de.t-internal.com ([10.171.255.41]) by MAILOUT31.dmznet.de.t-internal.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Jan 2020 08:42:01 +0100
IronPort-SDR: y8v9iC7hCKewA/0Y+GLKV4TNC7Sw/nqlmCfGNBx8/gUhPcfHJ0TQgdCSWHvJE0f+dmUvcKnxk0 gkwfEBvrrn69RkTGdo9+ZX09noOZKFf3o=
X-IronPort-AV: E=Sophos;i="5.70,348,1574118000"; d="scan'208";a="31466814"
X-MGA-submission: MDEoZuxr+8LZImwRdXtnoAwq1sd09awSqneGxujaUEN1yTKDOoPZrhmfo+gDRtOHS6kzzMtLPmftQokyinuqk+UMwNL7ZegYtmTJ6EoO3NzKoxJummroBACkS3k5Gfks298pHBz0iIDk3ZMeqEcyUTjnkDFS1Ixv6L1yKBN7Qqm2+A==
Received: from he199744.emea1.cds.t-internal.com ([10.169.119.52]) by QDEC97.de.t-internal.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA384; 22 Jan 2020 08:42:02 +0100
Received: from HE199743.EMEA1.cds.t-internal.com (10.169.119.51) by HE199744.emea1.cds.t-internal.com (10.169.119.52) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 22 Jan 2020 08:42:00 +0100
Received: from HE104163.emea1.cds.t-internal.com (10.171.40.38) by HE199743.EMEA1.cds.t-internal.com (10.169.119.51) with Microsoft SMTP Server (TLS) id 15.0.1497.2 via Frontend Transport; Wed, 22 Jan 2020 08:42:00 +0100
Received: from GER01-FRA-obe.outbound.protection.outlook.de (51.4.80.18) by O365mail05.telekom.de (172.30.0.230) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 22 Jan 2020 08:42:00 +0100
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=afi0BU7G9P3DsHuuFMlTUN/83lyqJWu3hpgaok6rQUcb0tD5omTocLRAaP7HCzhRpXEyNgQZYVrwXBpY3tzIAP8ygi1l4Zzekz6oFO7bi+3UR/66CGvrIeEAdGYk0UE/Glkpf/vPSIw1PC00Vh0i4tn8w7gmvilcdFVnJApBfVEzBTWnsMwDlnxgmxnqmrBxFHyp3Ti6PzjTY9MJsZIQdTzj1mGvadLqCACtFHINtwgdPvJpF/stet7jVzQjuOb43QtB5Ur+OP34uwsY5CVu9dXQWjvoHG7V8NvuXAPxtYpFEwnpgrb/EiIkSSRLAA0mEs0IxAlhYMPdd0dnv+QXOQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3kv12OAq/EI0EB3fy0+ZXewikyfGcNRF1m3cs2Oi7uo=; b=oEB5v6Zvq8sF2e5rOL6VcAsqKe3A0rl7f/YODVVwj8ljv/uBH2Rr3PyEcGBCBAiP50Y69Dsls0EWzL9iT6CjKLn0uWkzMUZBilwMOw8fwhYT3SzQWl4u64cjmZ+91mQoEe3BGbKfw4R6tJGfELXCO59+bNPyfDhXMM8Uhy0dOv/WwH9kukQ/oQ8iNtYw8PFKF5Gu3DQvaz/tNN9gEikLRVXFbOA2MtSZqJxundU2ei/3D3RbA/Hpl7QyEUkB1WuuZXEJqthcOLLQV0nLOTsdzX8TAla+iWQZgknRzN8ADg+zTbr2Xm0BR93R8ziuSlwF9JPjiauOTBJQapk8gusQNw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=telekom.de; dmarc=pass action=none header.from=telekom.de; dkim=pass header.d=telekom.de; arc=none
Received: from LEXPR01MB0045.DEUPRD01.PROD.OUTLOOK.DE (10.158.162.143) by LEXPR01MB0704.DEUPRD01.PROD.OUTLOOK.DE (10.158.167.137) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2644.25; Wed, 22 Jan 2020 07:42:00 +0000
Received: from LEXPR01MB0045.DEUPRD01.PROD.OUTLOOK.DE ([fe80::c111:a5e1:795:5c35]) by LEXPR01MB0045.DEUPRD01.PROD.OUTLOOK.DE ([fe80::c111:a5e1:795:5c35%6]) with mapi id 15.20.2644.027; Wed, 22 Jan 2020 07:42:00 +0000
From: R.Jesske@telekom.de
To: rsalz@akamai.com, secdir@ietf.org
CC: last-call@ietf.org, sipcore@ietf.org, draft-ietf-sipcore-locparam.all@ietf.org
Thread-Topic: Secdir last call review of draft-ietf-sipcore-locparam-04
Thread-Index: AQHVz7XOKkXn5J5ExEmDUjO7zxC7bqf2SpxQ
Date: Wed, 22 Jan 2020 07:42:00 +0000
Message-ID: <LEXPR01MB004521F34353627A79013B66F90C0@LEXPR01MB0045.DEUPRD01.PROD.OUTLOOK.DE>
References: <157954076633.1692.4566366506529807317@ietfa.amsl.com>
In-Reply-To: <157954076633.1692.4566366506529807317@ietfa.amsl.com>
Accept-Language: de-DE, en-US
Content-Language: de-DE
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: spf=none (sender IP is ) smtp.mailfrom=R.Jesske@telekom.de;
x-originating-ip: [164.19.4.101]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 40444fe1-0d8f-4c0a-3969-08d79f0e90c9
x-ms-traffictypediagnostic: LEXPR01MB0704:
x-microsoft-antispam-prvs: <LEXPR01MB0704BFB09D4F61CB35D07647F90C0@LEXPR01MB0704.DEUPRD01.PROD.OUTLOOK.DE>
x-ms-oob-tlc-oobclassifiers: OLM:8273;
x-forefront-prvs: 029097202E
x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(396003)(136003)(366004)(376002)(346002)(39860400002)(189003)(199004)(2906002)(8936002)(81166006)(478600001)(54906003)(81156014)(316002)(9686003)(55016002)(186003)(86362001)(26005)(66476007)(66946007)(76116006)(7696005)(110136005)(4326008)(71200400001)(8676002)(66556008)(33656002)(64756008)(5660300002)(66446008)(66574012); DIR:OUT; SFP:1101; SCL:1; SRVR:LEXPR01MB0704; H:LEXPR01MB0045.DEUPRD01.PROD.OUTLOOK.DE; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1;
received-spf: None (protection.outlook.com: telekom.de does not designate permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: PevN6ugcL7kLerTmBQzz2flM9COv5VElmyiGfF/Yu3yDjQujk3+2WQAPC9ikJ5t0REzO/HphFf0KOXSQ2Tu62RkoeBp+lsDc6NUzfhmJiZECCCK+cNqlY/JWCV0LcGEBiR0DC7TNV/U0U7L3PEkMPwyc94/jhhsa9mfDKUF5Aez8Tj+6RNq3KW9Hg2osMOJKEcaQdl2xvfMn7k1OOXi2OgC3eBtbPcxSlW12o1IslsYbOKc25nyobvAgJrazX0xzQdbCZQptpRRbl6M/YqdLz8hp6VGi6ytVdu69Tj3FLcw2zkXDr4mH7sLttK1PHgjuRPIKabU2nOWcLWzuCQHFqMt1lrlWka5TNDQrxbLSMF8foL3D7IS3tSUQk4cJ5yC3SgL6ePJCJE7dZp0/SiJTBstMLlDwURQAqaT7RP57yxjRtRYtQ1SNIiCUT7zQnG2Z
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 40444fe1-0d8f-4c0a-3969-08d79f0e90c9
X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Jan 2020 07:42:00.2660 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: bde4dffc-4b60-4cf6-8b04-a5eeb25f5c4f
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: kFXIfFr0ig9wtj/YmnEJ+mhopa5Lf4log1iiWgGTf+ti6l6SSwoSBklZ3N/IHar0MptutmEmYxlesbrEl6Lf4w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: LEXPR01MB0704
X-OriginatorOrg: telekom.de
Archived-At: <https://mailarchive.ietf.org/arch/msg/sipcore/ybKxN28J72vCH5yqWEi5PunjNg4>
Subject: Re: [sipcore] Secdir last call review of draft-ietf-sipcore-locparam-04
X-BeenThere: sipcore@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: SIP Core Working Group <sipcore.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/sipcore>, <mailto:sipcore-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/sipcore/>
List-Post: <mailto:sipcore@ietf.org>
List-Help: <mailto:sipcore-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/sipcore>, <mailto:sipcore-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 22 Jan 2020 07:42:07 -0000

Hello,
Thank you for your comments which I have incorporated into the draft.

For section 6: SIP proxies do add themselves into the Record-Route only when they want to stay within the SIP signalling path beyond the SIP INVITE. So it is not a usual procedure done in each use case. This is used when the proxy provide mid-call features.

Best Regards

Roland



-----Ursprüngliche Nachricht-----
Von: Rich Salz via Datatracker <noreply@ietf.org> 
Gesendet: Montag, 20. Januar 2020 18:19
An: secdir@ietf.org
Cc: last-call@ietf.org; sipcore@ietf.org; draft-ietf-sipcore-locparam.all@ietf.org
Betreff: Secdir last call review of draft-ietf-sipcore-locparam-04

Reviewer: Rich Salz
Review result: Has Nits

This is the security directorate (secdir) review for the sipcore-locparam draft. Secdir tries to review all documents. The primary intended recipient of this review if the security AD's; all others should consider this to be like any other last-call review.

Summary: ready with nits.

End of Sec 1 has a quote-based typo.

In Sec 3, "This document does not comment..." paragraph is a beautiful acceptance of reality.

In Sec 6, do proxies normally add themselves to the Record-Route field?  If so, that might be worth mentioning explicitly.

In Sec 7, looks good.  A couple of typo's "multiple*S* locations" and "hop-<SPACE>by-hop" and "an<SPACE>other domain."